Re: Review Request: Apply button enabling for some plasmoids.

2011-02-09 Thread Romário Rios


 On Feb. 9, 2011, 7:36 a.m., Anne-Marie Mahfouf wrote:
  For the clocks, the libplasmaclock should be done first 
  (kde-workspace/libs/plasmaclock/)
  Life, BBall and Knowledge are fine.

I'm working on libplasmaclock right now. Would you commit the other three 
widgets?


- Romário


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100614/#review1317
---


On Feb. 9, 2011, 5:53 a.m., Romário Rios wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/100614/
 ---
 
 (Updated Feb. 9, 2011, 5:53 a.m.)
 
 
 Review request for Plasma.
 
 
 Summary
 ---
 
 Just porting some plasmoids to support the new Apply button on config dailogs.
 
 
 Diffs
 -
 
   applets/bball/bball.cpp d44aa1c 
   applets/binary-clock/binaryclock.cpp 06db947 
   applets/fuzzy-clock/fuzzyClock.cpp 48d2f58 
   applets/knowledgebase/knowledgebase.cpp 0a0aec3 
   applets/life/life.cpp 611d09a 
 
 Diff: http://git.reviewboard.kde.org/r/100614/diff
 
 
 Testing
 ---
 
 Works fine at first sight.
 
 
 Thanks,
 
 Romário
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Apply button enabling for some plasmoids.

2011-02-09 Thread Anne-Marie Mahfouf


 On Feb. 9, 2011, 7:36 a.m., Anne-Marie Mahfouf wrote:
  For the clocks, the libplasmaclock should be done first 
  (kde-workspace/libs/plasmaclock/)
  Life, BBall and Knowledge are fine.
 
 Romário Rios wrote:
 I'm working on libplasmaclock right now. Would you commit the other three 
 widgets?

Done!


- Anne-Marie


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100614/#review1317
---


On Feb. 9, 2011, 5:53 a.m., Romário Rios wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/100614/
 ---
 
 (Updated Feb. 9, 2011, 5:53 a.m.)
 
 
 Review request for Plasma.
 
 
 Summary
 ---
 
 Just porting some plasmoids to support the new Apply button on config dailogs.
 
 
 Diffs
 -
 
   applets/bball/bball.cpp d44aa1c 
   applets/binary-clock/binaryclock.cpp 06db947 
   applets/fuzzy-clock/fuzzyClock.cpp 48d2f58 
   applets/knowledgebase/knowledgebase.cpp 0a0aec3 
   applets/life/life.cpp 611d09a 
 
 Diff: http://git.reviewboard.kde.org/r/100614/diff
 
 
 Testing
 ---
 
 Works fine at first sight.
 
 
 Thanks,
 
 Romário
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Apply button enabling for some plasmoids.

2011-02-08 Thread Romário Rios

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100614/
---

Review request for Plasma.


Summary
---

Just porting some plasmoids to support the new Apply button on config dailogs.


Diffs
-

  applets/bball/bball.cpp d44aa1c 
  applets/binary-clock/binaryclock.cpp 06db947 
  applets/fuzzy-clock/fuzzyClock.cpp 48d2f58 
  applets/knowledgebase/knowledgebase.cpp 0a0aec3 
  applets/life/life.cpp 611d09a 

Diff: http://git.reviewboard.kde.org/r/100614/diff


Testing
---

Works fine at first sight.


Thanks,

Romário

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Apply button enabling for some plasmoids.

2011-02-08 Thread Anne-Marie Mahfouf

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100614/#review1317
---


For the clocks, the libplasmaclock should be done first 
(kde-workspace/libs/plasmaclock/)
Life, BBall and Knowledge are fine.

- Anne-Marie


On Feb. 9, 2011, 5:53 a.m., Romário Rios wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/100614/
 ---
 
 (Updated Feb. 9, 2011, 5:53 a.m.)
 
 
 Review request for Plasma.
 
 
 Summary
 ---
 
 Just porting some plasmoids to support the new Apply button on config dailogs.
 
 
 Diffs
 -
 
   applets/bball/bball.cpp d44aa1c 
   applets/binary-clock/binaryclock.cpp 06db947 
   applets/fuzzy-clock/fuzzyClock.cpp 48d2f58 
   applets/knowledgebase/knowledgebase.cpp 0a0aec3 
   applets/life/life.cpp 611d09a 
 
 Diff: http://git.reviewboard.kde.org/r/100614/diff
 
 
 Testing
 ---
 
 Works fine at first sight.
 
 
 Thanks,
 
 Romário
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel