Review Request: Blur behind animated sliding popups

2011-12-10 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103375/
---

Review request for kwin and Plasma.


Description
---

Title says it all. This change allows to have the background of sliding popups 
blurred. Tested, no artifacts on panels, also not with hard cases such as 
Yakuake.

Requires the other sliding popup related patches. As far as my system is 
concerned it has no impact on performance. Nevertheless I will try to make it 
work with the cached blur version.

As it might impact performance, I'm not sure whether this is 4.8 material. I 
let Aaron decide :-)


Diffs
-

  kwin/effects/blur/blur.cpp c566e34 
  kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc 

Diff: http://git.reviewboard.kde.org/r/103375/diff/diff


Testing
---


Screenshots
---

Kickoff with blur during animation
  http://git.reviewboard.kde.org/r/103375/s/358/


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Blur behind animated sliding popups

2011-12-10 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103375/#review8863
---


This review has been submitted with commit 
cd78335fef23c290a09fec29d7d9600f0076d63a by Martin Gräßlin to branch master.

- Commit Hook


On Dec. 10, 2011, 12:43 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103375/
> ---
> 
> (Updated Dec. 10, 2011, 12:43 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> ---
> 
> Title says it all. This change allows to have the background of sliding 
> popups blurred. Tested, no artifacts on panels, also not with hard cases such 
> as Yakuake.
> 
> Requires the other sliding popup related patches. As far as my system is 
> concerned it has no impact on performance. Nevertheless I will try to make it 
> work with the cached blur version.
> 
> As it might impact performance, I'm not sure whether this is 4.8 material. I 
> let Aaron decide :-)
> 
> 
> Diffs
> -
> 
>   kwin/effects/blur/blur.cpp c566e34 
>   kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc 
> 
> Diff: http://git.reviewboard.kde.org/r/103375/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Kickoff with blur during animation
>   http://git.reviewboard.kde.org/r/103375/s/358/
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel