Review Request: Compile fix for geolocation dataengine with gpsd 2.90
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2443/ --- Review request for Plasma. Summary --- This patch makes it possible to compile the plasma geolocation dataengine with gpsd 2.90 and later versions. gpsd 2.90 is the version which is used in Debian sid. This patch is based on 27_geolocation_gpsd_2.90_compat.diff by Modestas Vainius which is used in the kdebase-workspace 4.3.4-1 package. It only adds conditional compilation based on gpsd API version, so that users with the old gpsd can continue to compile. Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/geolocation/location_gps.cpp 1065302 Diff: http://reviewboard.kde.org/r/2443/diff Testing --- compile tested. Thanks, jmho ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Compile fix for geolocation dataengine with gpsd 2.90
--- This is an automatically generated e-mail, which was bounced and now sent manually. To reply, visit: http://reviewboard.kde.org/r/2443/ --- Review request for Plasma. Summary --- This patch makes it possible to compile the plasma geolocation dataengine with gpsd 2.90 and later versions. gpsd 2.90 is the version which is used in Debian sid. This patch is based on 27_geolocation_gpsd_2.90_compat.diff by Modestas Vainius which is used in the kdebase-workspace 4.3.4-1 package. It only adds conditional compilation based on gpsd API version, so that users with the old gpsd can continue to compile. Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/geolocation/location_gps.cpp 1065302 = Diff: http://reviewboard.kde.org/r/2443/diff Testing --- compile tested. Thanks, jmho ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Compile fix for geolocation dataengine with gpsd 2.90
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2443/#review3501 --- Ship it! i just love the api stability with free software projects. :/ looks good, please commit :) - Aaron On 2009-12-23 00:03:18, jmho wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2443/ > --- > > (Updated 2009-12-23 00:03:18) > > > Review request for Plasma. > > > Summary > --- > > This patch makes it possible to compile the plasma geolocation dataengine > with gpsd 2.90 and later versions. > gpsd 2.90 is the version which is used in Debian sid. > > This patch is based on 27_geolocation_gpsd_2.90_compat.diff by Modestas > Vainius which is used in the > kdebase-workspace 4.3.4-1 package. It only adds conditional compilation based > on gpsd API version, so > that users with the old gpsd can continue to compile. > > > Diffs > - > > > /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/geolocation/location_gps.cpp > 1065302 > > Diff: http://reviewboard.kde.org/r/2443/diff > > > Testing > --- > > compile tested. > > > Thanks, > > jmho > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Compile fix for geolocation dataengine with gpsd 2.90
Am Mittwoch, 23. Dezember 2009 06:46:15 schrieb Aaron Seigo: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2443/#review3501 > --- > > Ship it! > > > i just love the api stability with free software projects. :/ looks good, > please commit :) > > - Aaron commited. Thanks for quick review. Jens-Michael ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
