Re: Review Request: Context menu for fast copying date and time strings to clipboard (libplasmaclock)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/521/ --- (Updated 2009-04-20 03:16:22.257265) Review request for Plasma. Summary --- This patch tries to add context menu with formatted date and time strings to clocks (by adding it to plasmaclock library) like in KDE3. Diffs - /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 956306 /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 956306 Diff: http://reviewboard.kde.org/r/521/diff Testing (updated) --- Tested using digital-clock and analog-clock applets from trunk and it works fine. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Context menu for fast copying date and time strings to clipboard (libplasmaclock)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/521/#review972 --- /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp http://reviewboard.kde.org/r/521/#comment666 qobject_castQWidget*(this) will return 0; this is not a QWidget :) you will need to manage the memory of this one manually and delete d-clipboardMenu in the destructor. - Aaron On 2009-04-20 03:16:22, Michal Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/521/ --- (Updated 2009-04-20 03:16:22) Review request for Plasma. Summary --- This patch tries to add context menu with formatted date and time strings to clocks (by adding it to plasmaclock library) like in KDE3. Diffs - /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 956306 /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 956306 Diff: http://reviewboard.kde.org/r/521/diff Testing --- Tested using digital-clock and analog-clock applets from trunk and it works fine. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Context menu for fast copying date and time strings to clipboard (libplasmaclock)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/521/ --- Review request for Plasma. Summary --- This patch tries to add context menu with formatted date and time strings to clocks (by adding it to plasmaclock library) like in KDE3. Diffs - /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 949231 /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 949231 Diff: http://reviewboard.kde.org/r/521/diff Testing --- Unfortunately I don't have possibility to test if this works property after porting from custom clock. I've tested only if it compiles. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
