Re: Review Request: Fix PaintUtils::shadowText() placement

2010-10-01 Thread Aaron Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5504/#review7927
---

Ship it!


- Aaron


On 2010-10-01 02:00:06, Christoph Feck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5504/
> ---
> 
> (Updated 2010-10-01 02:00:06)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> I used Plasma::PaintUtils::shadowText() to draw a text halo (offset 0,0) 
> around a text.
> Unfortunately, that halo got cropped (see the "g").
> 
> This patch should
> * fix placement of shadow and text inside the resulting pixmap
> * fix "addSize" not enlarged for negative offsets
> * simplify computation
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdelibs/plasma/paintutils.cpp 1181424 
> 
> Diff: http://svn.reviewboard.kde.org/r/5504/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> before
>   http://svn.reviewboard.kde.org/r/5504/s/517/
> after
>   http://svn.reviewboard.kde.org/r/5504/s/519/
> 
> 
> Thanks,
> 
> Christoph
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Fix PaintUtils::shadowText() placement

2010-09-30 Thread Christoph Feck

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5504/
---

Review request for Plasma.


Summary
---

I used Plasma::PaintUtils::shadowText() to draw a text halo (offset 0,0) around 
a text.
Unfortunately, that halo got cropped (see the "g").

This patch should
* fix placement of shadow and text inside the resulting pixmap
* fix "addSize" not enlarged for negative offsets
* simplify computation


Diffs
-

  /trunk/KDE/kdelibs/plasma/paintutils.cpp 1181424 

Diff: http://svn.reviewboard.kde.org/r/5504/diff


Testing
---


Screenshots
---

before
  http://svn.reviewboard.kde.org/r/5504/s/517/
after
  http://svn.reviewboard.kde.org/r/5504/s/519/


Thanks,

Christoph

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel