Re: Review Request: Fix ReferenceErrors in ListItem
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/#review20842 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 18, 2012, 2:39 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/ --- (Updated Oct. 18, 2012, 2:39 a.m.) Review request for Plasma. Description --- Check if referenced objects are valid This kills two ReferenceErrors I'm seeing when using ListItems inside VisualItemModels (in this case, there's no view and visual parent attached on creation). Diffs - plasma/declarativeimports/plasmacomponents/qml/ListItem.qml e352eb0 Diff: http://git.reviewboard.kde.org/r/106937/diff/ Testing --- tried the news app and widgetgallery, no regressions seen. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix ReferenceErrors in ListItem
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/#review20871 --- This review has been submitted with commit 602968b41655fdefba053d6aa32b505f98713dea by Sebastian Kügler to branch master. - Commit Hook On Oct. 18, 2012, 2:39 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/ --- (Updated Oct. 18, 2012, 2:39 a.m.) Review request for Plasma. Description --- Check if referenced objects are valid This kills two ReferenceErrors I'm seeing when using ListItems inside VisualItemModels (in this case, there's no view and visual parent attached on creation). Diffs - plasma/declarativeimports/plasmacomponents/qml/ListItem.qml e352eb0 Diff: http://git.reviewboard.kde.org/r/106937/diff/ Testing --- tried the news app and widgetgallery, no regressions seen. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix ReferenceErrors in ListItem
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/#review20874 --- This review has been submitted with commit 6fe8ee6ed91ac087177760990da63b1a8e5f6de4 by Sebastian Kügler to branch KDE/4.9. - Commit Hook On Oct. 18, 2012, 2:39 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/ --- (Updated Oct. 18, 2012, 2:39 a.m.) Review request for Plasma. Description --- Check if referenced objects are valid This kills two ReferenceErrors I'm seeing when using ListItems inside VisualItemModels (in this case, there's no view and visual parent attached on creation). Diffs - plasma/declarativeimports/plasmacomponents/qml/ListItem.qml e352eb0 Diff: http://git.reviewboard.kde.org/r/106937/diff/ Testing --- tried the news app and widgetgallery, no regressions seen. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Fix ReferenceErrors in ListItem
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/ --- Review request for Plasma. Description --- Check if referenced objects are valid This kills two ReferenceErrors I'm seeing when using ListItems inside VisualItemModels (in this case, there's no view and visual parent attached on creation). Diffs - plasma/declarativeimports/plasmacomponents/qml/ListItem.qml e352eb0 Diff: http://git.reviewboard.kde.org/r/106937/diff/ Testing --- tried the news app and widgetgallery, no regressions seen. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
