Re: Review Request: Fix biggestId in systray-to-notifications-widget.js
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104086/#review11402
---
This review has been submitted with commit
297b3e42e796afe1cd37df101d8b2c240b4625b0 by Aaron Seigo to branch master.
- Commit Hook
On Feb. 26, 2012, 10:18 p.m., Luc Menut wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104086/
> ---
>
> (Updated Feb. 26, 2012, 10:18 p.m.)
>
>
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
>
>
> Description
> ---
>
> When I try in the plasma desktop console the algorithm that calculate the
> biggestId in systray-to-notifications-widget.js, it gives me a wrong result
> for biggestId and biggestId+1.
> The real biggestId in my plasma-desktop-appletsrc is 82
> ([Containments][76][Applets][82]).
> The current algorithm gives me:
> print(biggestId) -> 5
> print(biggestId+1)-> 51
> print(typeof(biggestId)) -> string
>
> because in
> for (var j in activity.widgetIds) {
> if (j > biggestId) {
> biggestId = j
> }
> j is the key (string key) of the array activity.widgetIds.
>
> The suggested patch gives the good result.
>
>
> regards,
> Luc Menut - Mageia
>
> PS: I don't have write access to kde git, so could you commit the change for
> me if the patch looks fine. Thanks.
>
>
> Diffs
> -
>
> plasma/desktop/shell/configupdates/systray-to-notifications-widget.js
> 7a31de6
>
> Diff: http://git.reviewboard.kde.org/r/104086/diff/
>
>
> Testing
> ---
>
> tested with KDE 4.8.0 (Mageia Cauldron)
>
>
> Thanks,
>
> Luc Menut
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix biggestId in systray-to-notifications-widget.js
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104086/#review11401
---
This review has been submitted with commit
2ee1b5deb98f1c493cf342fc0f459b4028cedbab by Aaron Seigo to branch KDE/4.8.
- Commit Hook
On Feb. 26, 2012, 10:18 p.m., Luc Menut wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104086/
> ---
>
> (Updated Feb. 26, 2012, 10:18 p.m.)
>
>
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
>
>
> Description
> ---
>
> When I try in the plasma desktop console the algorithm that calculate the
> biggestId in systray-to-notifications-widget.js, it gives me a wrong result
> for biggestId and biggestId+1.
> The real biggestId in my plasma-desktop-appletsrc is 82
> ([Containments][76][Applets][82]).
> The current algorithm gives me:
> print(biggestId) -> 5
> print(biggestId+1)-> 51
> print(typeof(biggestId)) -> string
>
> because in
> for (var j in activity.widgetIds) {
> if (j > biggestId) {
> biggestId = j
> }
> j is the key (string key) of the array activity.widgetIds.
>
> The suggested patch gives the good result.
>
>
> regards,
> Luc Menut - Mageia
>
> PS: I don't have write access to kde git, so could you commit the change for
> me if the patch looks fine. Thanks.
>
>
> Diffs
> -
>
> plasma/desktop/shell/configupdates/systray-to-notifications-widget.js
> 7a31de6
>
> Diff: http://git.reviewboard.kde.org/r/104086/diff/
>
>
> Testing
> ---
>
> tested with KDE 4.8.0 (Mageia Cauldron)
>
>
> Thanks,
>
> Luc Menut
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Fix biggestId in systray-to-notifications-widget.js
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104086/
---
Review request for Plasma, Aaron J. Seigo and Marco Martin.
Description
---
When I try in the plasma desktop console the algorithm that calculate the
biggestId in systray-to-notifications-widget.js, it gives me a wrong result for
biggestId and biggestId+1.
The real biggestId in my plasma-desktop-appletsrc is 82
([Containments][76][Applets][82]).
The current algorithm gives me:
print(biggestId) -> 5
print(biggestId+1)-> 51
print(typeof(biggestId)) -> string
because in
for (var j in activity.widgetIds) {
if (j > biggestId) {
biggestId = j
}
j is the key (string key) of the array activity.widgetIds.
The suggested patch gives the good result.
regards,
Luc Menut - Mageia
PS: I don't have write access to kde git, so could you commit the change for me
if the patch looks fine. Thanks.
Diffs
-
plasma/desktop/shell/configupdates/systray-to-notifications-widget.js 7a31de6
Diff: http://git.reviewboard.kde.org/r/104086/diff/
Testing
---
tested with KDE 4.8.0 (Mageia Cauldron)
Thanks,
Luc Menut
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
