Re: Review Request: Fix for Favorite items in Kickoff
On Tuesday 18 November 2008 13:51:45 Jesse Zamora wrote: This patch fixes a bug with Kickoff that Favorite items have Sort Ascending and Sort Descending even when they are not in the favorites view. It also changes the strings to Sort Alphabetically (A to Z) and Sort Alphabetically (Z to A). I hope I'm not too late to get it in trunk. :-( We're string-frozen since last night. If you want to get this patch in, separate the bugfix from the string changes. The bugfix can be committed now (it looks like a nice improvement). The string changes will have to wait until KDE is unfrozen again (somewhen in January). -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix for Favorite items in Kickoff
On Tuesday 18 November 2008 22:34:05 Sebastian Kügler wrote: On Tuesday 18 November 2008 13:51:45 Jesse Zamora wrote: This patch fixes a bug with Kickoff that Favorite items have Sort Ascending and Sort Descending even when they are not in the favorites view. It also changes the strings to Sort Alphabetically (A to Z) and Sort Alphabetically (Z to A). I hope I'm not too late to get it in trunk. :-( We're string-frozen since last night. If you want to get this patch in, separate the bugfix from the string changes. The bugfix can be committed now (it looks like a nice improvement). The string changes will have to wait until KDE is unfrozen again (somewhen in January). No, we're in message freeze only tonight, see http://techbase.kde.org/Schedules/KDE4/4.2_Release_Schedule#November_18th.2C_2008:_Message_Freeze. Anne-Marie ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix for Favorite items in Kickoff
On Tuesday 18 November 2008 09:40:20 Aaron J. Seigo wrote: On Tuesday 18 November 2008, Anne-Marie Mahfouf wrote: On Tuesday 18 November 2008 22:34:05 Sebastian Kügler wrote: On Tuesday 18 November 2008 13:51:45 Jesse Zamora wrote: This patch fixes a bug with Kickoff that Favorite items have Sort Ascending and Sort Descending even when they are not in the favorites view. It also changes the strings to Sort Alphabetically (A to Z) and Sort Alphabetically (Z to A). I hope I'm not too late to get it in trunk. :-( We're string-frozen since last night. If you want to get this patch in, separate the bugfix from the string changes. The bugfix can be committed now (it looks like a nice improvement). The string changes will have to wait until KDE is unfrozen again (somewhen in January). No, we're in message freeze only tonight, yes, so please commit this asap. (and once again, r-b isn't showing me the patch .. gah... ) Do you mean I can commit the new strings? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix for Favorite items in Kickoff
On Tuesday 18 November 2008, Jesse L. Zamora wrote: On Tuesday 18 November 2008 09:40:20 Aaron J. Seigo wrote: On Tuesday 18 November 2008, Anne-Marie Mahfouf wrote: On Tuesday 18 November 2008 22:34:05 Sebastian Kügler wrote: On Tuesday 18 November 2008 13:51:45 Jesse Zamora wrote: This patch fixes a bug with Kickoff that Favorite items have Sort Ascending and Sort Descending even when they are not in the favorites view. It also changes the strings to Sort Alphabetically (A to Z) and Sort Alphabetically (Z to A). I hope I'm not too late to get it in trunk. :-( We're string-frozen since last night. If you want to get this patch in, separate the bugfix from the string changes. The bugfix can be committed now (it looks like a nice improvement). The string changes will have to wait until KDE is unfrozen again (somewhen in January). No, we're in message freeze only tonight, yes, so please commit this asap. (and once again, r-b isn't showing me the patch .. gah... ) Do you mean I can commit the new strings? only if you do it quickly =) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix for Favorite items in Kickoff
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/273/ --- (Updated 2008-11-18 08:15:13.183337) Review request for Plasma. Summary --- This patch fixes a bug with Kickoff that Favorite items have Sort Ascending and Sort Descending even when they are not in the favorites view. It also changes the strings to Sort Alphabetically (A to Z) and Sort Alphabetically (Z to A). I hope I'm not too late to get it in trunk. :-( Diffs - KDE/kdebase/workspace/plasma/applets/kickoff/ui/contextmenufactory.cpp KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp Diff: http://reviewboard.vidsolbach.de/r/273/diff Testing --- I just put it in trunk. Thanks, Jesse ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
