Re: Review Request: Fix misplaced panel (especially when more than one monitor is involved)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105596/#review17406 --- This review has been submitted with commit 59b1e4e4387a9194125bfac35a23ad885c9c24e6 by Rolf Eike Beer to branch KDE/4.9. - Commit Hook On July 16, 2012, 4:34 p.m., Rolf Eike Beer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105596/ > --- > > (Updated July 16, 2012, 4:34 p.m.) > > > Review request for Plasma. > > > Description > --- > > This fixes the misplaced panel I and several others see since a while. > > This fix was provided by Kai Dombrowe in bugzilla. > > > This addresses bug 283974. > http://bugs.kde.org/show_bug.cgi?id=283974 > > > Diffs > - > > plasma/desktop/shell/panelview.cpp 50826a8 > > Diff: http://git.reviewboard.kde.org/r/105596/diff/ > > > Testing > --- > > Rebuild with that change, panel was placed properly after login. Using plain > package immediately showed the problem again. > > > Thanks, > > Rolf Eike Beer > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix misplaced panel (especially when more than one monitor is involved)
On Friday, July 27, 2012 17:31:08 Rolf Eike Beer wrote: > Am Donnerstag 26 Juli 2012, 10:14:42 schrieb Marco Martin: > > --- > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/105596/#review16464 > > --- > > > > > > > > > > setGeometry(geom) should really, really have no effect. > > > > > > > > it's probably masking some deeper level bug. > > > > > > > > if it's reliable as workaround, so be it. > > So ship it? Yes. :) (Better late than never, this one probably slipped.) -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix misplaced panel (especially when more than one monitor is involved)
Am Donnerstag 26 Juli 2012, 10:14:42 schrieb Marco Martin: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105596/#review16464 > --- > > > setGeometry(geom) should really, really have no effect. > > it's probably masking some deeper level bug. > > if it's reliable as workaround, so be it. So ship it? signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix misplaced panel (especially when more than one monitor is involved)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105596/#review16464 --- setGeometry(geom) should really, really have no effect. it's probably masking some deeper level bug. if it's reliable as workaround, so be it. - Marco Martin On July 16, 2012, 4:34 p.m., Rolf Eike Beer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105596/ > --- > > (Updated July 16, 2012, 4:34 p.m.) > > > Review request for Plasma. > > > Description > --- > > This fixes the misplaced panel I and several others see since a while. > > This fix was provided by Kai Dombrowe in bugzilla. > > > This addresses bug 283974. > http://bugs.kde.org/show_bug.cgi?id=283974 > > > Diffs > - > > plasma/desktop/shell/panelview.cpp 50826a8 > > Diff: http://git.reviewboard.kde.org/r/105596/diff/ > > > Testing > --- > > Rebuild with that change, panel was placed properly after login. Using plain > package immediately showed the problem again. > > > Thanks, > > Rolf Eike Beer > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix misplaced panel (especially when more than one monitor is involved)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105596/#review16326 --- I can confirm that this change fixes the problem. Bug 272663 and bug 281029 are likely duplicates. Cannot comment if the patch is correct, though. - Christoph Feck On July 16, 2012, 4:34 p.m., Rolf Eike Beer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105596/ > --- > > (Updated July 16, 2012, 4:34 p.m.) > > > Review request for Plasma. > > > Description > --- > > This fixes the misplaced panel I and several others see since a while. > > This fix was provided by Kai Dombrowe in bugzilla. > > > This addresses bug 283974. > http://bugs.kde.org/show_bug.cgi?id=283974 > > > Diffs > - > > plasma/desktop/shell/panelview.cpp 50826a8 > > Diff: http://git.reviewboard.kde.org/r/105596/diff/ > > > Testing > --- > > Rebuild with that change, panel was placed properly after login. Using plain > package immediately showed the problem again. > > > Thanks, > > Rolf Eike Beer > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Fix misplaced panel (especially when more than one monitor is involved)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105596/ --- Review request for Plasma. Description --- This fixes the misplaced panel I and several others see since a while. This fix was provided by Kai Dombrowe in bugzilla. This addresses bug 283974. http://bugs.kde.org/show_bug.cgi?id=283974 Diffs - plasma/desktop/shell/panelview.cpp 50826a8 Diff: http://git.reviewboard.kde.org/r/105596/diff/ Testing --- Rebuild with that change, panel was placed properly after login. Using plain package immediately showed the problem again. Thanks, Rolf Eike Beer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
