Re: Review Request: Fix resizing of popup applets on panel resizing
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101148/#review2709 --- This review has been submitted with commit fb0960361ba6cd83bed3a7f1d977e036e37f5ab3 by David Palacio. - Commit On April 17, 2011, 8:49 p.m., David Palacio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101148/ > --- > > (Updated April 17, 2011, 8:49 p.m.) > > > Review request for Plasma, Aaron J. Seigo and Marco Martin. > > > Summary > --- > > Since commit 1ed8e4ca6b53c2338d8da8e616752f0426038961 popup applets as Shelf > and Places (kde-look.org) do not resize when the panel resizes. > This patch ensures the icon is added to the widget layout before the function > returns. > > > This addresses bug 268104. > http://bugs.kde.org/show_bug.cgi?id=268104 > > > Diffs > - > > plasma/popupapplet.cpp 9238bd1 > > Diff: http://git.reviewboard.kde.org/r/101148/diff > > > Testing > --- > > > Thanks, > > David > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix resizing of popup applets on panel resizing
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101148/#review2708 --- Ship it! good catch - Marco On April 17, 2011, 8:49 p.m., David Palacio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101148/ > --- > > (Updated April 17, 2011, 8:49 p.m.) > > > Review request for Plasma, Aaron J. Seigo and Marco Martin. > > > Summary > --- > > Since commit 1ed8e4ca6b53c2338d8da8e616752f0426038961 popup applets as Shelf > and Places (kde-look.org) do not resize when the panel resizes. > This patch ensures the icon is added to the widget layout before the function > returns. > > > This addresses bug 268104. > http://bugs.kde.org/show_bug.cgi?id=268104 > > > Diffs > - > > plasma/popupapplet.cpp 9238bd1 > > Diff: http://git.reviewboard.kde.org/r/101148/diff > > > Testing > --- > > > Thanks, > > David > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Fix resizing of popup applets on panel resizing
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101148/ --- Review request for Plasma, Aaron J. Seigo and Marco Martin. Summary --- Since commit 1ed8e4ca6b53c2338d8da8e616752f0426038961 popup applets as Shelf and Places (kde-look.org) do not resize when the panel resizes. This patch ensures the icon is added to the widget layout before the function returns. This addresses bug 268104. http://bugs.kde.org/show_bug.cgi?id=268104 Diffs - plasma/popupapplet.cpp 9238bd1 Diff: http://git.reviewboard.kde.org/r/101148/diff Testing --- Thanks, David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
