Re: Review Request: Improving KRunner to list applications and bookmarks

[Artur Souza (MoRpHeUz)]

On Wednesday 08 July 2009, 15:01 Aaron Seigo wrote:
> Ship it!

I updated with your comments and committed it :)
Thanks for the review!

Cheers,

--
Artur Duque de Souza
openBossa Research Labs
INdT - Instituto Nokia de Tecnologia
--
Blog: http://blog.morpheuz.cc
PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net
--


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Improving KRunner to list applications and bookmarks

[Aaron Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/952/#review1502
---

Ship it!


good ideas; some minor comments follow. but generally i think this should go in 
:)


trunk/KDE/kdebase/workspace/plasma/runners/bookmarks/bookmarksrunner.cpp


how about just "bookmarks"? unless we make "list" a common part of the 
krunner vernacular and use it in more places, it's just one more thing to learn 
and type. whereas "bookmarks" is easy enough to guess? :)



trunk/KDE/kdebase/workspace/plasma/runners/services/servicerunner.cpp


seeing the names of those three hardcoded there seems a bit odd. does it 
matter if the user types in KDE that we show all KDE related apps? *shrug*



trunk/KDE/kdebase/workspace/plasma/runners/services/servicerunner.cpp


if the OnlyShowIn is KDE, though, then it's just as relevant; it should 
probably only lower the relevance if it's OnlyShowIn something other than KDE?


- Aaron


On 2009-07-08 07:25:35, Artur de Souza (MoRpHeUz) wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/952/
> ---
> 
> (Updated 2009-07-08 07:25:35)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This is good so we are able to ask for "multimedia applications", "network 
> applications", etc. and KRunner returns the results. This would be used on 
> SAL activity to enable us to have predefined queries so users can use the 
> stuff just like a regular menu if they want to.
> 
> It also enables the list of all bookmarks for the same use case.
> 
> Patch by notmart
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/plasma/runners/bookmarks/bookmarksrunner.cpp 
> 979260 
>   trunk/KDE/kdebase/workspace/plasma/runners/services/servicerunner.cpp 
> 979260 
> 
> Diff: http://reviewboard.kde.org/r/952/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artur
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Improving KRunner to list applications and bookmarks

[Artur de Souza (MoRpHeUz)]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/952/
---

Review request for Plasma.


Summary
---

This is good so we are able to ask for "multimedia applications", "network 
applications", etc. and KRunner returns the results. This would be used on SAL 
activity to enable us to have predefined queries so users can use the stuff 
just like a regular menu if they want to.

It also enables the list of all bookmarks for the same use case.

Patch by notmart


Diffs
-

  trunk/KDE/kdebase/workspace/plasma/runners/bookmarks/bookmarksrunner.cpp 
979260 
  trunk/KDE/kdebase/workspace/plasma/runners/services/servicerunner.cpp 979260 

Diff: http://reviewboard.kde.org/r/952/diff


Testing
---


Thanks,

Artur

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel