Re: Review Request: Kickoff application uninstaller

2010-11-25 Thread Aaron Seigo 

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5974/#review8981
---

Ship it!


a comment in the code explaining why an activatable is being checked for would 
be nice.

- Aaron


On 2010-11-25 23:48:05, Daniel Nicoletti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5974/
> ---
> 
> (Updated 2010-11-25 23:48:05)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Patch to use PackageKit session interface to "Uninstall" the applications.
> When kickoff starts it checks if the session interface is available, if it's 
> not available the
> right click option to "Uninstall" applications will not be displayed.
> 
> 
> Diffs
> -
> 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp
>  1200785 
> 
> Diff: http://svn.reviewboard.kde.org/r/5974/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Kickoff Uninstaller
>   http://svn.reviewboard.kde.org/r/5974/s/563/
> 
> 
> Thanks,
> 
> Daniel
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Kickoff application uninstaller

2010-11-25 Thread Aaron Seigo 


> On 2010-11-25 23:51:56, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp,
> >  lines 104-117
> > 
> >
> > this would be better with a QDBusServiceWatcher (faster, also detect 
> > changes at runtime, not have to expose DBus internals directly in the code)

after further discussion on irc with dantti, it turns out that 
org.freedesktop.PackageKit may not be running and only activatable, so it needs 
to be checked for being available for activation. so this approach, while ugly 
(typical for direct dbus calls like this), is probably the best/only approach 
at hand.


- Aaron


---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5974/#review8979
---


On 2010-11-25 23:48:05, Daniel Nicoletti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5974/
> ---
> 
> (Updated 2010-11-25 23:48:05)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Patch to use PackageKit session interface to "Uninstall" the applications.
> When kickoff starts it checks if the session interface is available, if it's 
> not available the
> right click option to "Uninstall" applications will not be displayed.
> 
> 
> Diffs
> -
> 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp
>  1200785 
> 
> Diff: http://svn.reviewboard.kde.org/r/5974/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Kickoff Uninstaller
>   http://svn.reviewboard.kde.org/r/5974/s/563/
> 
> 
> Thanks,
> 
> Daniel
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Kickoff application uninstaller

2010-11-25 Thread Aaron Seigo 

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5974/#review8979
---


looks good (for 4.7), with the exception of using QDBusServiceWatcher.


/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp


this would be better with a QDBusServiceWatcher (faster, also detect 
changes at runtime, not have to expose DBus internals directly in the code)


- Aaron


On 2010-11-25 23:48:05, Daniel Nicoletti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5974/
> ---
> 
> (Updated 2010-11-25 23:48:05)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Patch to use PackageKit session interface to "Uninstall" the applications.
> When kickoff starts it checks if the session interface is available, if it's 
> not available the
> right click option to "Uninstall" applications will not be displayed.
> 
> 
> Diffs
> -
> 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp
>  1200785 
> 
> Diff: http://svn.reviewboard.kde.org/r/5974/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Kickoff Uninstaller
>   http://svn.reviewboard.kde.org/r/5974/s/563/
> 
> 
> Thanks,
> 
> Daniel
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Kickoff application uninstaller

2010-11-25 Thread Aaron Seigo 

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5974/
---

(Updated 2010-11-25 23:48:05.415571)


Review request for Plasma.


Changes
---

am part of the plasma group; don't need two copies :)


Summary
---

Patch to use PackageKit session interface to "Uninstall" the applications.
When kickoff starts it checks if the session interface is available, if it's 
not available the
right click option to "Uninstall" applications will not be displayed.


Diffs
-

  
/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp
 1200785 

Diff: http://svn.reviewboard.kde.org/r/5974/diff


Testing
---


Screenshots
---

Kickoff Uninstaller
  http://svn.reviewboard.kde.org/r/5974/s/563/


Thanks,

Daniel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Kickoff application uninstaller

2010-11-25 Thread Daniel Nicoletti 

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5974/
---

(Updated 2010-11-25 23:44:39.182743)


Review request for Plasma and Aaron Seigo.


Summary
---

Patch to use PackageKit session interface to "Uninstall" the applications.
When kickoff starts it checks if the session interface is available, if it's 
not available the
right click option to "Uninstall" applications will not be displayed.


Diffs
-

  
/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp
 1200785 

Diff: http://svn.reviewboard.kde.org/r/5974/diff


Testing
---


Screenshots (updated)
---

Kickoff Uninstaller
  http://svn.reviewboard.kde.org/r/5974/s/563/


Thanks,

Daniel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel