Re: Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-05-01 Thread Viranch Mehta 
On Wed, May 2, 2012 at 5:47 AM, Sebastian Kügler  wrote:

>
> Congrats, Viranch! You've done some excellent work here and delivered high-
> quality replacements for those important components.
>
> Thanks a lot, and chapeau!
>

I'm glad I could be a part of contributing to kde! Marco has helped me
improve and polish my work to a great extent. Thanks, Marco :)

Looking forward to seeing my work in next release and fixing some kickass
bugs ;)

Cheers,
Viranch
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-05-01 Thread Sebastian Kügler 
On Wednesday, May 02, 2012 00:12:26 Viranch Mehta wrote:
> http://git.reviewboard.kde.org/r/104226/#review13258
> ---
> 
> Merged to master with commit bf1a11f5d9bcf73ba8f071bc4cd532ed8652e1d3
> 
> - Viranch Mehta

Congrats, Viranch! You've done some excellent work here and delivered high-
quality replacements for those important components.

Thanks a lot, and chapeau!
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-05-01 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review13258
---


Merged to master with commit bf1a11f5d9bcf73ba8f071bc4cd532ed8652e1d3

- Viranch Mehta


On April 3, 2012, 5:12 a.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated April 3, 2012, 5:12 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> with top right graphic in the popup
>   http://git.reviewboard.kde.org/r/104226/s/487/
> applet on the workspace
>   http://git.reviewboard.kde.org/r/104226/s/503/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-17 Thread Viranch Mehta 


> On April 17, 2012, 11:18 a.m., Kai Uwe Broulik wrote:
> > I just applied it to latest master and found a few usability issues:
> > * The settings dialog that contains all the configs is way too small
> > * The slider "grab" is 10 pixels to the left, some QML component issue
> > And the showstopper issue is:
> > There is no easy way to see the battery percentage. The overlay number is 
> > no longer available. And also there is no tooltip, i.e. hovering the 
> > plasmoid also does nothing. You _always_ have to click the battery plasmoid 
> > to see the exact percentage.
> > The tooltip thing seems to be a general QML plasmoid issue, the new devicec 
> > notifier also lacks one.

The patch is not up-to-date. Please checkout the branch 
plasma/viranch/powermanagementservices and compile 
plasma/generic/{applets/batterymonitor,dataengines/powermanagement}. That's 
where all my latest commits have gone.


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review12560
---


On April 3, 2012, 5:12 a.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated April 3, 2012, 5:12 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> with top right graphic in the popup
>   http://git.reviewboard.kde.org/r/104226/s/487/
> applet on the workspace
>   http://git.reviewboard.kde.org/r/104226/s/503/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-17 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review12560
---


I just applied it to latest master and found a few usability issues:
* The settings dialog that contains all the configs is way too small
* The slider "grab" is 10 pixels to the left, some QML component issue
And the showstopper issue is:
There is no easy way to see the battery percentage. The overlay number is no 
longer available. And also there is no tooltip, i.e. hovering the plasmoid also 
does nothing. You _always_ have to click the battery plasmoid to see the exact 
percentage.
The tooltip thing seems to be a general QML plasmoid issue, the new devicec 
notifier also lacks one.

- Kai Uwe Broulik


On April 3, 2012, 5:12 a.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated April 3, 2012, 5:12 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> with top right graphic in the popup
>   http://git.reviewboard.kde.org/r/104226/s/487/
> applet on the workspace
>   http://git.reviewboard.kde.org/r/104226/s/503/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-03 Thread Viranch Mehta 
On Tue, Apr 3, 2012 at 7:25 PM, Marco Martin  wrote:

> > * the c++ applet shows a confirmation box for suspend & hibernate,
> > how can this be done in QML? how about showing our regular applet-popup
> > like in the battery monitor? with this option, the user also wouldn't
> have
> > to
> > move the mouse too much around the screen.
>
> hmm, it should call just the ksmserver dialog, should be added to the
> service?
> (power? another one?)
>
>
we have to simply show a KMessageBox as does the c++ applet. the qml applet
uses power management engine for all the actions. putting it in
power management
services would also affect the suspend actions of battery monitor.

Viranch
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-03 Thread Viranch Mehta 
On Tue, Apr 3, 2012 at 7:24 PM, Daniel Nicoletti  wrote:

> doesn't the kworskspace API handle the confirmation already?
> (I know it does for Shutdown, logoff and restart)
>
>
kworkspace API is only used for "leave" (a combined action for
logout, turn off, restart). for suspend actions, dbus calls are made.

Viranch
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-03 Thread Marco Martin 
On Tuesday 03 April 2012, Viranch Mehta wrote:
> On Tue, Apr 3, 2012 at 1:45 PM, Marco Martin  wrote:
> > here the biggest challenge i guess is making all resize correctly in
> > horizontal/vertical panels.
> 
> Yes, just spent 5 hours on this. Finally resizing works almost fine inside
> and outside panels, except:
> 
> * it does not resize/change when the orientation of a panel changes (eg,
> top panel is moved to right). i tried
> addEventListener('FormFactorChanged', formFactorChanged); but the callback
> is never called.

argh, looks like this will have to be fixed directly in the appletscript so

> * if the applet is on the desktop, the last visible icon in the list
> flickers _a lot_
> when the applet is resized. this happens for more than one icons visible,
> and
> happens to only the last icon.
> 
> * the c++ applet shows a confirmation box for suspend & hibernate,
> how can this be done in QML? how about showing our regular applet-popup
> like in the battery monitor? with this option, the user also wouldn't have
> to
> move the mouse too much around the screen.

hmm, it should call just the ksmserver dialog, should be added to the service? 
(power? another one?)


-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-03 Thread Daniel Nicoletti 
2012/4/3 Viranch Mehta :
> On Tue, Apr 3, 2012 at 1:45 PM, Marco Martin  wrote:
>>
>> here the biggest challenge i guess is making all resize correctly in
>> horizontal/vertical panels.
>
>
> Yes, just spent 5 hours on this. Finally resizing works almost fine inside
> and outside panels, except:
>
> * it does not resize/change when the orientation of a panel changes (eg, top
> panel is moved to right). i tried addEventListener('FormFactorChanged',
> formFactorChanged); but the callback is never called.
>
> * if the applet is on the desktop, the last visible icon in the list
> flickers _a lot_
> when the applet is resized. this happens for more than one icons visible,
> and
> happens to only the last icon.
>
> * the c++ applet shows a confirmation box for suspend & hibernate,
> how can this be done in QML? how about showing our regular applet-popup
> like in the battery monitor? with this option, the user also wouldn't have
> to move the mouse too much around the screen.

doesn't the kworskspace API handle the confirmation already?
(I know it does for Shutdown, logoff and restart)

Best
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-03 Thread Viranch Mehta 
On Tue, Apr 3, 2012 at 1:45 PM, Marco Martin  wrote:

> here the biggest challenge i guess is making all resize correctly in
> horizontal/vertical panels.
>

Yes, just spent 5 hours on this. Finally resizing works almost fine inside
and outside panels, except:

* it does not resize/change when the orientation of a panel changes (eg, top
panel is moved to right). i tried addEventListener('FormFactorChanged',
formFactorChanged); but the callback is never called.

* if the applet is on the desktop, the last visible icon in the list
flickers _a lot_
when the applet is resized. this happens for more than one icons visible,
and
happens to only the last icon.

* the c++ applet shows a confirmation box for suspend & hibernate,
how can this be done in QML? how about showing our regular applet-popup
like in the battery monitor? with this option, the user also wouldn't have
to
move the mouse too much around the screen.

Cheers,
Viranch
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-03 Thread Marco Martin 
On Tuesday 03 April 2012, Viranch Mehta wrote:
> On Mon, Apr 2, 2012 at 7:52 PM, Marco Martin  wrote:
> > hmm, not too happy about both, let's make lock/logout work as well then
> > merge
> > everything?
> 
> That sounds fine. I'll soon open a review request.

here the biggest challenge i guess is making all resize correctly in 
horizontal/vertical panels.

i don't know if you already applied some minimum size tricks, otherwise take a 
look at the share-like-connect applet (own repo)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-02 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---

(Updated April 3, 2012, 5:12 a.m.)


Review request for Plasma.


Changes
---

Add a screenshot of the applet when its in a panel.


Description
---

I fixed the QML battery monitor to be fairly usable and this diff merges it to 
master.


Diffs
-

  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
---

Applet and dataengine both tested and work fine.


Screenshots (updated)
---

with top right graphic in the popup
  http://git.reviewboard.kde.org/r/104226/s/487/
applet on the workspace
  http://git.reviewboard.kde.org/r/104226/s/503/


Thanks,

Viranch Mehta

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-02 Thread Viranch Mehta 
On Mon, Apr 2, 2012 at 7:52 PM, Marco Martin  wrote:

> hmm, not too happy about both, let's make lock/logout work as well then
> merge
> everything?
>

That sounds fine. I'll soon open a review request.

Viranch
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-02 Thread Marco Martin 
On Monday 02 April 2012, Viranch Mehta wrote:
> > On April 2, 2012, 12:25 p.m., Sebastian Kügler wrote:
> > > Looking good now, thanks a lot for your patience!
> > > 
> > > I'm getting this TypeError still, haven't looked into the reason behind
> > > it:
> > > file:///home/sebas/kdesvn/install/share/apps/plasma/plasmoids/battery/
> > > contents/ui/batterymonitor.qml:77: TypeError: Result of expression
> > > 'pmSource.data["PowerDevil"]' [undefined] is not an object.
> > > 
> > > I propose to merge it into master now. There's still a bit of polishing
> > > possible (margins, for example), but we can easily do those when it's
> > > in master.
> 
> I'm not getting the TypeError here. About the merge, I have worked on QML
> lock/logout applet in the same branch. So should I just copy-paste QML
> battery monitor into master, or cherry-pick from the branch to preserve
> the history?

hmm, not too happy about both, let's make lock/logout work as well then merge 
everything?
-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-02 Thread Viranch Mehta 


> On April 2, 2012, 12:25 p.m., Sebastian Kügler wrote:
> > Looking good now, thanks a lot for your patience!
> > 
> > I'm getting this TypeError still, haven't looked into the reason behind it:
> > file:///home/sebas/kdesvn/install/share/apps/plasma/plasmoids/battery/contents/ui/batterymonitor.qml:77:
> >  TypeError: Result of expression 'pmSource.data["PowerDevil"]' [undefined] 
> > is not an object.
> > 
> > I propose to merge it into master now. There's still a bit of polishing 
> > possible (margins, for example), but we can easily do those when it's in 
> > master.

I'm not getting the TypeError here. About the merge, I have worked on QML 
lock/logout applet in the same branch. So should I just copy-paste QML battery 
monitor into master, or cherry-pick from the branch to preserve the history?


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review12114
---


On March 23, 2012, 6:20 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 23, 2012, 6:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> with top right graphic in the popup
>   http://git.reviewboard.kde.org/r/104226/s/487/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-02 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review12114
---

Ship it!


Looking good now, thanks a lot for your patience!

I'm getting this TypeError still, haven't looked into the reason behind it:
file:///home/sebas/kdesvn/install/share/apps/plasma/plasmoids/battery/contents/ui/batterymonitor.qml:77:
 TypeError: Result of expression 'pmSource.data["PowerDevil"]' [undefined] is 
not an object.

I propose to merge it into master now. There's still a bit of polishing 
possible (margins, for example), but we can easily do those when it's in master.

- Sebastian Kügler


On March 23, 2012, 6:20 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 23, 2012, 6:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> with top right graphic in the popup
>   http://git.reviewboard.kde.org/r/104226/s/487/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-23 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---

(Updated March 23, 2012, 6:20 p.m.)


Review request for Plasma.


Changes
---

Screenshot update, showing the top right battery icon in the popup


Description
---

I fixed the QML battery monitor to be fairly usable and this diff merges it to 
master.


Diffs
-

  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
---

Applet and dataengine both tested and work fine.


Screenshots (updated)
---

with top right graphic in the popup
  http://git.reviewboard.kde.org/r/104226/s/487/


Thanks,

Viranch Mehta

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-23 Thread Viranch Mehta 


> On March 21, 2012, 9:20 a.m., Marco Martin wrote:
> > let's merge then fix all the things that may remain ok?
> > (if you are rady to quickly fix issues as they come in, because many will 
> > report ;)
> 
> Viranch Mehta wrote:
> Yep, I'm ready.
> 
> Sebastian Kügler wrote:
> I'd prefer if we wait with merging until all issues are fixed, there are 
> still quite a few regressions here, from my testing:
> 
> - discharge percentage isn't shown at all
> - the top right graphic in the popup is missing
> - information on the RHS doesn't match labels on the LHS
> - the Hibernate button is shown here, while the machine only supports 
> sleep (works fine with old applet)
> - s/Powermanagement/Power Management
> - Lots of runtime warnings, especially about dereferencing missing 
> datasources
>
> 
> Sebastian Kügler wrote:
> I'm testing from the plasma/viranch/powermanagementservices branch, does 
> that one contain the latest state of the art?

Yes, the plasma/viranch/powermanagementservices branch contains the latest QML 
applet (including the following fixes):
(I'm not updating the diff here anymore. Will do it when applet is ready.)

- discharge percentage isn't shown at all
- information on the RHS doesn't match labels on the LHS

Fixed both. These were due to some serious mistakes in merge conflicts in last 
commit (my apologies)

- the Hibernate button is shown here, while the machine only supports sleep 
(works fine with old applet)
- Lots of runtime warnings, especially about dereferencing missing datasources

Fixed both. Had forgotten to add "Sleep States" in connectedSources.

- s/Powermanagement/Power Management

Fixed this in the i18nc comment of the label "Power management enabled:". Did I 
miss elsewhere?

- the top right graphic in the popup is missing

Added, and working.


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11683
---


On March 20, 2012, 9:44 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 20, 2012, 9:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/482/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-23 Thread Sebastian Kügler 


> On March 21, 2012, 9:20 a.m., Marco Martin wrote:
> > let's merge then fix all the things that may remain ok?
> > (if you are rady to quickly fix issues as they come in, because many will 
> > report ;)
> 
> Viranch Mehta wrote:
> Yep, I'm ready.
> 
> Sebastian Kügler wrote:
> I'd prefer if we wait with merging until all issues are fixed, there are 
> still quite a few regressions here, from my testing:
> 
> - discharge percentage isn't shown at all
> - the top right graphic in the popup is missing
> - information on the RHS doesn't match labels on the LHS
> - the Hibernate button is shown here, while the machine only supports 
> sleep (works fine with old applet)
> - s/Powermanagement/Power Management
> - Lots of runtime warnings, especially about dereferencing missing 
> datasources
>

I'm testing from the plasma/viranch/powermanagementservices branch, does that 
one contain the latest state of the art?


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11683
---


On March 20, 2012, 9:44 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 20, 2012, 9:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/482/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-23 Thread Sebastian Kügler 


> On March 21, 2012, 9:20 a.m., Marco Martin wrote:
> > let's merge then fix all the things that may remain ok?
> > (if you are rady to quickly fix issues as they come in, because many will 
> > report ;)
> 
> Viranch Mehta wrote:
> Yep, I'm ready.

I'd prefer if we wait with merging until all issues are fixed, there are still 
quite a few regressions here, from my testing:

- discharge percentage isn't shown at all
- the top right graphic in the popup is missing
- information on the RHS doesn't match labels on the LHS
- the Hibernate button is shown here, while the machine only supports sleep 
(works fine with old applet)
- s/Powermanagement/Power Management
- Lots of runtime warnings, especially about dereferencing missing datasources


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11683
---


On March 20, 2012, 9:44 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 20, 2012, 9:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/482/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-21 Thread Viranch Mehta 


> On March 21, 2012, 9:20 a.m., Marco Martin wrote:
> > let's merge then fix all the things that may remain ok?
> > (if you are rady to quickly fix issues as they come in, because many will 
> > report ;)

Yep, I'm ready.


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11683
---


On March 20, 2012, 9:44 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 20, 2012, 9:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/482/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-21 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11683
---


let's merge then fix all the things that may remain ok?
(if you are rady to quickly fix issues as they come in, because many will 
report ;)

- Marco Martin


On March 20, 2012, 9:44 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 20, 2012, 9:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/482/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-21 Thread Vishesh Handa 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11667
---



Screenshot: 

This looks kind bad. There should be a certain amount of padding.

- Vishesh Handa


On March 20, 2012, 9:44 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 20, 2012, 9:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/482/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-20 Thread Viranch Mehta 


> On March 20, 2012, 10:02 p.m., Vishesh Handa wrote:
> > Screenshot: 
> > 
> >
> > This looks kind bad. There should be a certain amount of padding.

There is already some default padding in the popup. It is stripped off while 
viewing in plasmoidviewer for some reason, notice the absence of top left and 
bottom left rounded corners. Should look fine when added to an actual workspace.


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11667
---


On March 20, 2012, 9:44 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 20, 2012, 9:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/482/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-20 Thread Marco Martin 
On Tuesday 20 March 2012, Viranch Mehta wrote:
> > On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote:
> > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line
> > > 97
> > >  > > ine97>
> > > 
> > > horizontalAlignment: Text.AlignRight
> 
> This doesn't work for some reason (the width of the Label item is same as
> that required by the painted text, not the width of the cell it is in).
> 
> Instead of that, anchors.right: parent.right is used.
> 

horizontalAlignment: Text.AlignRight works only when the label widget is 
larger then the text, so would work if the label was as wide as the whole gap

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-20 Thread Viranch Mehta 


> On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 97
> > 
> >
> > horizontalAlignment: Text.AlignRight

This doesn't work for some reason (the width of the Label item is same as that 
required by the painted text, not the width of the cell it is in).

Instead of that, anchors.right: parent.right is used.


> On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 81
> > 
> >
> > showRemainingTime?

There is added condition: text!="" && showRemainingTime elsewhere. Hence here 
is simply connected to it.


> On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 130
> > 
> >
> > sleepButton and hibernateButton should be hidden when the system does 
> > not support it. Looks like this was forgotten here. Did you make sure it 
> > works?
> > 
> > It's exposed in the dataengine, in "Sleep States", keys: "Suspend", 
> > "Hibernate".
> > 
> > Could be as simple as visible: powermanagmentEngine.data["Sleep 
> > States"]["Suspend"] etc...

Yes it was forgotten, thanks for pointing out. Added the visible condition.


On March 20, 2012, 10:27 a.m., Viranch Mehta wrote:
> > When installing from the plasma/viranch/powermanagementservices branch, I'm 
> > getting this error during installation:
> > 
> > CMake Error at applets/batterymonitor/cmake_install.cmake:56 (FILE):
> >   file INSTALL cannot find
> >   
> > "/home/sebas/kdesvn/src/kde-workspace/plasma/generic/applets/batterymonitor/battery-oxygen.svgz".
> > 
> > Can you have a look?

Fixed. I'd recommend not to merge it from that branch though, because it also 
has lock_logout QML applet and few other things that might cause a lot of merge 
conflicts. Use the attached diff for merging.


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11650
---


On March 20, 2012, 9:44 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 20, 2012, 9:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/482/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-20 Thread Viranch Mehta 


> On March 19, 2012, 7:23 p.m., Marco Martin wrote:
> > as for comments on the screenshot, labels on the left should be 
> > right-aligned, the code seems fine now

Labels now right-aligned. Screenshot updated.


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11632
---


On March 20, 2012, 9:44 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 20, 2012, 9:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/482/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-20 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---

(Updated March 20, 2012, 9:44 p.m.)


Review request for Plasma.


Changes
---

Updated screenshot and the patch.


Description
---

I fixed the QML battery monitor to be fairly usable and this diff merges it to 
master.


Diffs (updated)
-

  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
---

Applet and dataengine both tested and work fine.


Screenshots (updated)
---


  http://git.reviewboard.kde.org/r/104226/s/482/


Thanks,

Viranch Mehta

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-20 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11650
---


Looking better, I think the translation issues are resolved now. There's still 
a few things missing here and there, but I think we're pretty close. Good work!


plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


showRemainingTime?



plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


horizontalAlignment: Text.AlignRight



plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


horizontalAlignment: Text.AlignRight



plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


sleepButton and hibernateButton should be hidden when the system does not 
support it. Looks like this was forgotten here. Did you make sure it works?

It's exposed in the dataengine, in "Sleep States", keys: "Suspend", 
"Hibernate".

Could be as simple as visible: powermanagmentEngine.data["Sleep 
States"]["Suspend"] etc...


When installing from the plasma/viranch/powermanagementservices branch, I'm 
getting this error during installation:

CMake Error at applets/batterymonitor/cmake_install.cmake:56 (FILE):
  file INSTALL cannot find
  
"/home/sebas/kdesvn/src/kde-workspace/plasma/generic/applets/batterymonitor/battery-oxygen.svgz".

Can you have a look?

- Sebastian Kügler


On March 14, 2012, 6:46 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 14, 2012, 6:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/464/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-19 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11632
---


as for comments on the screenshot, labels on the left should be right-aligned, 
the code seems fine now

- Marco Martin


On March 14, 2012, 6:46 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 14, 2012, 6:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/464/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-19 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11631
---


are there updates on this? still issues to work out?

- Marco Martin


On March 14, 2012, 6:46 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 14, 2012, 6:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/464/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-15 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11360
---


Read up on i18n, ideally most of 
http://techbase.kde.org/Development/Tutorials/Localization/ and double check 
everything again.

Also personally I like to submit a screenshot with any very visual change.


plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


This is not translated.



plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


This i18n string doesn't really work.

1) This string doesn't really contain any words, so it's not really 
suitable for translation. At least use i18nc() so translators have context of 
what it is.

2) the state (i.e charging, charged, discharging) is never translated.





plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


This isn't translated.

Also this is a word puzzle.


http://techbase.kde.org/Development/Tutorials/Localization/i18n_Mistakes#Pitfall_.232:_Word_Puzzles

You also can't do

if (hrs==1) {
 "hour"
} else {
 "hours"
}
for some languages plurals come after 1st, 11th 111th.. it's not as simple 
as you just wrote.

use i18np.




plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


Don't do this to determine how wide something should be.
What if the japanese for "power management enabled" is only 3 characters 
long and the time remaining is larger?

Even if you could garauntee it's the longest string right now, what if 
someone changes this in the future?

set the Grid to be 
width:childRect.width.

and remove the call to width on all these labels, and that /should/ work. 
(I've not tested that and could be wrong.)


- David Edmundson


On March 13, 2012, 11:59 a.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 13, 2012, 11:59 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-14 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---

(Updated March 14, 2012, 6:46 p.m.)


Review request for Plasma.


Changes
---

Fix the typo i18n("%1...") to i18n("%1%...") to show the '%' sign in "Battery:" 
field of the popup.


Description
---

I fixed the QML battery monitor to be fairly usable and this diff merges it to 
master.


Diffs (updated)
-

  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
---

Applet and dataengine both tested and work fine.


Screenshots
---


  http://git.reviewboard.kde.org/r/104226/s/464/


Thanks,

Viranch Mehta

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-14 Thread Viranch Mehta 


> On March 13, 2012, 5:32 p.m., David Edmundson wrote:
> > Read up on i18n, ideally most of 
> > http://techbase.kde.org/Development/Tutorials/Localization/ and double 
> > check everything again.
> > 
> > Also personally I like to submit a screenshot with any very visual change.

Thanks for the link. Screenshot uploaded.


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11360
---


On March 14, 2012, 6:39 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 14, 2012, 6:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/464/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-14 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---

(Updated March 14, 2012, 6:39 p.m.)


Review request for Plasma.


Changes
---

Add screenshot.


Description
---

I fixed the QML battery monitor to be fairly usable and this diff merges it to 
master.


Diffs
-

  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
---

Applet and dataengine both tested and work fine.


Screenshots (updated)
---


  http://git.reviewboard.kde.org/r/104226/s/464/


Thanks,

Viranch Mehta

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-14 Thread Viranch Mehta 


> On March 13, 2012, 5:32 p.m., David Edmundson wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 66
> > 
> >
> > This i18n string doesn't really work.
> > 
> > 1) This string doesn't really contain any words, so it's not really 
> > suitable for translation. At least use i18nc() so translators have context 
> > of what it is.
> > 
> > 2) the state (i.e charging, charged, discharging) is never translated.
> > 
> >

I have adopted the translation straight from the C++ applet now (except the 
if-else logic):

if (pluggedIn) {
   if (percent<100) return i18n("%1 (charging)", percent);
   else return i18n("%1 (charged)", percent);
} else {
   return i18n("%1 (discharging)", percent);
}


> On March 13, 2012, 5:32 p.m., David Edmundson wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 101
> > 
> >
> > This isn't translated.
> > 
> > Also this is a word puzzle.
> > 
> > 
> > http://techbase.kde.org/Development/Tutorials/Localization/i18n_Mistakes#Pitfall_.232:_Word_Puzzles
> > 
> > You also can't do
> > 
> > if (hrs==1) {
> >  "hour"
> > } else {
> >  "hours"
> > }
> > for some languages plurals come after 1st, 11th 111th.. it's not as 
> > simple as you just wrote.
> > 
> > use i18np.
> >

We can achieve completely formatted and translated string only by 
KLocale::prettyFormatDuration() as far as I know. But since we don't yet have 
KLocale QML bindings, I have a temporary work around:

var time = new Date(remainingMsec);
var hrs = i18np("1 hour", "%1 hours", time.getUTCHours());
var mins = i18np("1 minute", "%1 minutes", time.getUTCMinutes());
return hrs+", "+mins;


> On March 13, 2012, 5:32 p.m., David Edmundson wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 108
> > 
> >
> > Don't do this to determine how wide something should be.
> > What if the japanese for "power management enabled" is only 3 
> > characters long and the time remaining is larger?
> > 
> > Even if you could garauntee it's the longest string right now, what if 
> > someone changes this in the future?
> > 
> > set the Grid to be 
> > width:childRect.width.
> > 
> > and remove the call to width on all these labels, and that /should/ 
> > work. (I've not tested that and could be wrong.)

Discarded.
This was done to achieve right alignment to the labels (on the left side). For 
now, they are all left-aligned due to this change.


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11360
---


On March 14, 2012, 5:48 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 14, 2012, 5:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both test

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-14 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---

(Updated March 14, 2012, 5:48 p.m.)


Review request for Plasma.


Changes
---

Properly translates all displayed text with comments to translators wherever 
necessary (all of the i18n/i18nc/i18np are taken from C++ version).


Description
---

I fixed the QML battery monitor to be fairly usable and this diff merges it to 
master.


Diffs (updated)
-

  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
---

Applet and dataengine both tested and work fine.


Thanks,

Viranch Mehta

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-13 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---

(Updated March 13, 2012, 11:59 a.m.)


Review request for Plasma.


Changes
---

Take results from service operation calls (beginSuppressing...() and 
stopSuppressing...()) and store them in cookies.


Description
---

I fixed the QML battery monitor to be fairly usable and this diff merges it to 
master.


Diffs (updated)
-

  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
---

Applet and dataengine both tested and work fine.


Thanks,

Viranch Mehta

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-13 Thread Viranch Mehta 


> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 66
> > 
> >
> > The word puzzle here is not translatable. You'll need to enclose a full 
> > string into i18n(), with the current code, translators can't figure out 
> > what the message is.
> > 
> > Also, appending strings to each other doesn't work, as the word order 
> > might be different. So you have to identify the cases, and then return a 
> > completely translated string.
> 
> Viranch Mehta wrote:
> For now, I'm dropping i18n() completely on such computed strings.

Fixed it to work in a manner similar to the C++ one.


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11311
---


On March 13, 2012, 11:14 a.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 13, 2012, 11:14 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-13 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---

(Updated March 13, 2012, 11:14 a.m.)


Review request for Plasma.


Changes
---

Make the battery charge info string translatable as done in C++ version.


Description
---

I fixed the QML battery monitor to be fairly usable and this diff merges it to 
master.


Diffs (updated)
-

  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
---

Applet and dataengine both tested and work fine.


Thanks,

Viranch Mehta

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-13 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---

(Updated March 13, 2012, 10:26 a.m.)


Review request for Plasma.


Changes
---

Add a config option to show/hide remaining battery time.


Description
---

I fixed the QML battery monitor to be fairly usable and this diff merges it to 
master.


Diffs (updated)
-

  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
---

Applet and dataengine both tested and work fine.


Thanks,

Viranch Mehta

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-13 Thread Viranch Mehta 


> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 81
> > 
> >
> > This should not be in there, basically only if it has been enabled by 
> > config showRemainingTime (look at the C++ version when it's shown). We 
> > explicitely excluded this feature by default since the remaining time 
> > cannot be accurately computed.
> 
> Viranch Mehta wrote:
> I don't see a showRemainingTime config in C++ version (I'm looking at 
> master). Should I add this in the QML version?

Done.


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11311
---


On March 13, 2012, 9:51 a.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 13, 2012, 9:51 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 
> 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
> ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> ---
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-13 Thread Sebastian Kügler 
Hi Viranch,

On Tuesday, March 13, 2012 09:52:27 Viranch Mehta wrote:
> > On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line
> > > 81
> > >  > > e81>> >
> > > This should not be in there, basically only if it has been enabled
> > >by config showRemainingTime (look at the C++ version when it's shown).
> > >We explicitely excluded this feature by default since the remaining time
> > >cannot be accurately computed.
> I don't see a showRemainingTime config in C++ version (I'm looking at
> master). Should I add this in the QML version?

kde-workspace/plasma/generic/applets/battery and grep for showRemainingTime, 
it's in there (master).

> > On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > > plasma/generic/dataengines/powermanagement/powermanagementjob.cpp, line
> > > 87
> > >  > > e87>> >
> > > This line always sets result to false, no matter what happened
> > >earlier. 
> > > I think the code you added here is correct, could you check why it
> > >worked earlier?
> The control reaches here only if there were no 'return's earlier. It works
> because there is a return inside each if case. So if the operation name was
> invalid, it would setResult(false), otherwise setResult(whatever the
> operation returns).

Hm, the context even included in the diff does not have returns for every 
case, so it does skip to the last one.

> > On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line
> > > 66
> > >  > > e66>> >
> > > The word puzzle here is not translatable. You'll need to enclose a
> > >full string into i18n(), with the current code, translators can't figure
> > >out what the message is. 
> > > Also, appending strings to each other doesn't work, as the word
> > >order might be different. So you have to identify the cases, and then
> > >return a completely translated string.
> For now, I'm dropping i18n() completely on such computed strings.

Then we can't merge it. Proper translation is really a hard requirement.

> > On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml,
> > > line 65
> > >  > > ne65>> >
> > > instead of plasmoid.rootItem.pmSource, try using just pmSource. If
> > >necessary, that means moving pmSource somewhere visible. 
> > > Should make porting to QML2 easier.
> 
> Just pmSource doesn't work because compactRepresentation is a Component, and
> hence pmSource cannot be moved to any visible location. This is the only
> way to do it AFAICT. Use of plasmoid.rootItem.pmSource can be reduced by
> assigning it to another variable inside the component. (Look at updated
> diff).

OK, cool. Thanks for investigating.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-13 Thread Viranch Mehta 


> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 81
> > 
> >
> > This should not be in there, basically only if it has been enabled by 
> > config showRemainingTime (look at the C++ version when it's shown). We 
> > explicitely excluded this feature by default since the remaining time 
> > cannot be accurately computed.

I don't see a showRemainingTime config in C++ version (I'm looking at master). 
Should I add this in the QML version?


> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > plasma/generic/dataengines/powermanagement/powermanagementjob.cpp, line 87
> > 
> >
> > This line always sets result to false, no matter what happened earlier.
> > 
> > I think the code you added here is correct, could you check why it 
> > worked earlier?

The control reaches here only if there were no 'return's earlier. It works 
because there is a return inside each if case. So if the operation name was 
invalid, it would setResult(false), otherwise setResult(whatever the operation 
returns).


> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 66
> > 
> >
> > The word puzzle here is not translatable. You'll need to enclose a full 
> > string into i18n(), with the current code, translators can't figure out 
> > what the message is.
> > 
> > Also, appending strings to each other doesn't work, as the word order 
> > might be different. So you have to identify the cases, and then return a 
> > completely translated string.

For now, I'm dropping i18n() completely on such computed strings.


> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 
> > 65
> > 
> >
> > instead of plasmoid.rootItem.pmSource, try using just pmSource. If 
> > necessary, that means moving pmSource somewhere visible.
> > 
> > Should make porting to QML2 easier.

Just pmSource doesn't work because compactRepresentation is a Component, and 
hence pmSource cannot be moved to any visible location. This is the only way to 
do it AFAICT. Use of plasmoid.rootItem.pmSource can be reduced by assigning it 
to another variable inside the component. (Look at updated diff).


> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 
> > 89
> > 
> >
> > This guy is unnecessary, as the exact same info is already shown in the 
> > dialog. I'd prefer getting rid of this overlay altogether (including the 
> > config option).

Getting this info from dialog requires two clicks (opening and closing the 
dialog). While this overlay simply displays it. We can still drop it if desired.


> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 
> > 144
> > 
> >
> > What's missing here? 
> > 
> > Either ditch // TODO, or add a note what's missing

I figured out what should be done here, and implemented (see updated diff).


- Viranch


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11311
---


On March 13, 2012, 9:51 a.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 13, 2012, 9:51 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-13 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---

(Updated March 13, 2012, 9:51 a.m.)


Review request for Plasma.


Changes
---

Temporarily remove i18n() for complex strings
Alias plasmoid.rootItem.pmSource to pmSource
Implement powermanagement enabled/disabled
Make setScreenBrightness service job return void


Description
---

I fixed the QML battery monitor to be fairly usable and this diff merges it to 
master.


Diffs (updated)
-

  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
---

Applet and dataengine both tested and work fine.


Thanks,

Viranch Mehta

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-12 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11311
---


The changes as they are add a few translation problems. There's also a bit of 
nitpicking here and there.

I haven't tested it yet, but the problems I'm pointing out will definitely need 
fixing before we can merge this into master.

Pretty good progress, however! :)


plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


The word puzzle here is not translatable. You'll need to enclose a full 
string into i18n(), with the current code, translators can't figure out what 
the message is.

Also, appending strings to each other doesn't work, as the word order might 
be different. So you have to identify the cases, and then return a completely 
translated string.



plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


This should not be in there, basically only if it has been enabled by 
config showRemainingTime (look at the C++ version when it's shown). We 
explicitely excluded this feature by default since the remaining time cannot be 
accurately computed.



plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml


Word puzzles do not work for translators.

This has to be done through KLocale, I don't see an option how to do it 
nicely and translatable.



plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml


instead of plasmoid.rootItem.pmSource, try using just pmSource. If 
necessary, that means moving pmSource somewhere visible.

Should make porting to QML2 easier.



plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml


Same for plasmoid.pmSource location



plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml


This guy is unnecessary, as the exact same info is already shown in the 
dialog. I'd prefer getting rid of this overlay altogether (including the config 
option).



plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml


What's missing here? 

Either ditch // TODO, or add a note what's missing



plasma/generic/dataengines/powermanagement/powermanagementjob.cpp


This line always sets result to false, no matter what happened earlier.

I think the code you added here is correct, could you check why it worked 
earlier?



plasma/generic/dataengines/powermanagement/powermanagementjob.cpp


if it always returns true, it's useless to return anything. Make it void.


- Sebastian Kügler


On March 11, 2012, 1:59 p.m., Viranch Mehta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> ---
> 
> (Updated March 11, 2012, 1:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it 
> to master.
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/battery/CMakeLists.txt 7794f88 
>   plasma/generic/applets/battery/Messages.sh 8b06e2d 
>   plasma/generic/applets/battery/README.txt 5b352e8 
>   plasma/generic/applets/battery/battery-oxygen-inkscape.svgz b68ba66 
>   plasma/generic/applets/battery/battery-oxygen.svgz a037e60 
>   plasma/generic/applets/battery/battery.h ebc1a3d 
>   plasma/generic/applets/battery/battery.cpp 3a5cda3 
>   plasma/generic/applets/battery/batteryConfig.ui 5595ca2 
>   plasma/generic/applets/battery/plasma-battery-default.desktop e254028 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> PRE-CREATION 
>   plasma/generic/applets/batterymoni

Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-11 Thread Viranch Mehta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---

Review request for Plasma.


Description
---

I fixed the QML battery monitor to be fairly usable and this diff merges it to 
master.


Diffs
-

  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/battery/CMakeLists.txt 7794f88 
  plasma/generic/applets/battery/Messages.sh 8b06e2d 
  plasma/generic/applets/battery/README.txt 5b352e8 
  plasma/generic/applets/battery/battery-oxygen-inkscape.svgz b68ba66 
  plasma/generic/applets/battery/battery-oxygen.svgz a037e60 
  plasma/generic/applets/battery/battery.h ebc1a3d 
  plasma/generic/applets/battery/battery.cpp 3a5cda3 
  plasma/generic/applets/battery/batteryConfig.ui 5595ca2 
  plasma/generic/applets/battery/plasma-battery-default.desktop e254028 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations 
ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
---

Applet and dataengine both tested and work fine.


Thanks,

Viranch Mehta

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel