Re: Review Request: Plasma Notes bug and wish
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/417/ --- (Updated 2009-04-01 06:08:43.243577) Review request for Plasma. Changes --- Here it is the last changes I had to make. Now everything seems good. Summary --- I made changes that were whished by the refered bug I just need to send the patch to someone how can commit because I change a .svgz file to add the transparency. Thanks This addresses bug 179170. https://bugs.kde.org/show_bug.cgi?id=179170 Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/notes/notes.h 947761 trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 947761 Diff: http://reviewboard.kde.org/r/417/diff Testing --- Screenshots --- Visuals of corrections http://reviewboard.kde.org/r/417/s/74/ Thanks, Maxime ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Notes bug and wish
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/417/ --- (Updated 2009-03-27 09:29:49.619133) Review request for Plasma. Changes --- So, I changed for translucent and after a little verification I saw that the one how created the plasma did not restore configurations. Now it's done. Summary --- I made changes that were whished by the refered bug I just need to send the patch to someone how can commit because I change a .svgz file to add the transparency. Thanks This addresses bug 179170. https://bugs.kde.org/show_bug.cgi?id=179170 Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 945528 Diff: http://reviewboard.kde.org/r/417/diff Testing --- Screenshots --- Visuals of corrections http://reviewboard.kde.org/r/417/s/74/ Thanks, Maxime ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Notes bug and wish
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/417/#review653 --- Small comment, otherwise looks OK. You can send the notes.svgz file to me to commit it. trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp http://reviewboard.kde.org/r/417/#comment414 You can just write m_useNoColor = cg.readEntry(useNoColor, true); instead of the tmp var and then casting it. It's a lot cleaner and KConfig actually understands most of the datatypes you ever want to save. - Sebastian On 2009-03-27 09:29:49, Maxime Hermouet wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/417/ --- (Updated 2009-03-27 09:29:49) Review request for Plasma. Summary --- I made changes that were whished by the refered bug I just need to send the patch to someone how can commit because I change a .svgz file to add the transparency. Thanks This addresses bug 179170. https://bugs.kde.org/show_bug.cgi?id=179170 Diffs - trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 945528 Diff: http://reviewboard.kde.org/r/417/diff Testing --- Screenshots --- Visuals of corrections http://reviewboard.kde.org/r/417/s/74/ Thanks, Maxime ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Plasma Notes bug and wish
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/417/ --- Review request for Plasma. Summary --- I made changes that were whished by the refered bug I just need to send the patch to someone how can commit because I change a .svgz file to add the transparency. Thanks This addresses bug 179170. https://bugs.kde.org/show_bug.cgi?id=179170 Diffs - trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 944474 Diff: http://reviewboard.kde.org/r/417/diff Testing --- Screenshots --- Visuals of corrections http://reviewboard.kde.org/r/417/s/74/ Thanks, Maxime ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Notes bug and wish
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/417/#review618 --- Ship it! a little niggle on the wording, but otherwise look ok. :) trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp http://reviewboard.kde.org/r/417/#comment400 Translucent is probably the right description; Transparent essentially means invisible while Translucent means can be seen through. - Aaron On 2009-03-25 08:57:14, Maxime Hermouet wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/417/ --- (Updated 2009-03-25 08:57:14) Review request for Plasma. Summary --- I made changes that were whished by the refered bug I just need to send the patch to someone how can commit because I change a .svgz file to add the transparency. Thanks This addresses bug 179170. https://bugs.kde.org/show_bug.cgi?id=179170 Diffs - trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 944474 Diff: http://reviewboard.kde.org/r/417/diff Testing --- Screenshots --- Visuals of corrections http://reviewboard.kde.org/r/417/s/74/ Thanks, Maxime ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
