Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-06-08 Thread Giorgos Tsiapaliwkas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/
---

Review request for Plasma.


Summary
---

Hello,

the method removeDirectory wasn't removing the parent folder. 
For example,if we named out plasmoid my_plasmoid it would have a directory like 
this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" 
and the after calling the removeDirectory(before the patch) method we would 
have a directory like this:
""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
With the patch the entire folder my_plasmoid is being deleted.


Diffs
-

  projectmanager/projectmanager.cpp c00fd27 

Diff: http://git.reviewboard.kde.org/r/101550/diff


Testing
---

compiles without issues and without regressions.


Thanks,

Giorgos

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-06-20 Thread Aaron J. Seigo 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/#review4040
---



projectmanager/projectmanager.cpp


please use KIO::del here (defined in KIO/DeleteJob)

it simplifies everything and uses KIO as it should be...


- Aaron J.


On June 8, 2011, 9:51 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101550/
> ---
> 
> (Updated June 8, 2011, 9:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Hello,
> 
> the method removeDirectory wasn't removing the parent folder. 
> For example,if we named out plasmoid my_plasmoid it would have a directory 
> like this "$(kde4-config 
> --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" and the after 
> calling the removeDirectory(before the patch) method we would have a 
> directory like this:
> ""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
> With the patch the entire folder my_plasmoid is being deleted.
> 
> 
> Diffs
> -
> 
>   projectmanager/projectmanager.cpp c00fd27 
> 
> Diff: http://git.reviewboard.kde.org/r/101550/diff
> 
> 
> Testing
> ---
> 
> compiles without issues and without regressions.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-13 Thread Giorgos Tsiapaliwkas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/
---

(Updated July 13, 2011, 3 p.m.)


Review request for Plasma.


Changes
---

here is the KIO implementation.
Please let me know for any changes in my patch.

Moreover i changed a little bit the names.
I used project instead of folder.Is that ok?


Summary
---

Hello,

the method removeDirectory wasn't removing the parent folder. 
For example,if we named out plasmoid my_plasmoid it would have a directory like 
this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" 
and the after calling the removeDirectory(before the patch) method we would 
have a directory like this:
""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
With the patch the entire folder my_plasmoid is being deleted.


Diffs (updated)
-

  projectmanager/projectmanager.h 53ef226 
  projectmanager/projectmanager.cpp 122e48d 

Diff: http://git.reviewboard.kde.org/r/101550/diff


Testing
---

compiles without issues and without regressions.


Thanks,

Giorgos

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-13 Thread Aaron J. Seigo 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/#review4691
---


there is a problem with the cd(".."),otherwise it looks good. just need to fix 
that up and it can go in.


projectmanager/projectmanager.cpp


this cd("..") does not look safe. it assumes that it is a project created 
by plasmate, and so has the code one level beneath the actual project dir.

however, one can easily import an existing project from disk. say .. 
~/myPreexistingProject. which means this could would delete everything in my 
home dir!

i actually have some projects imported from kdeexamples as well as one from 
a local git repo, and this would wreck havoc on my data :/

as nasty as this is going to look, i think what will be required is to 
check if projectLocation is in appdata or not.


- Aaron J.


On July 13, 2011, 3 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101550/
> ---
> 
> (Updated July 13, 2011, 3 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Hello,
> 
> the method removeDirectory wasn't removing the parent folder. 
> For example,if we named out plasmoid my_plasmoid it would have a directory 
> like this "$(kde4-config 
> --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" and the after 
> calling the removeDirectory(before the patch) method we would have a 
> directory like this:
> ""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
> With the patch the entire folder my_plasmoid is being deleted.
> 
> 
> Diffs
> -
> 
>   projectmanager/projectmanager.h 53ef226 
>   projectmanager/projectmanager.cpp 122e48d 
> 
> Diff: http://git.reviewboard.kde.org/r/101550/diff
> 
> 
> Testing
> ---
> 
> compiles without issues and without regressions.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-19 Thread Giorgos Tsiapaliwkas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/
---

(Updated July 19, 2011, 11 a.m.)


Review request for Plasma.


Changes
---

changes:
-migration from QDIR to KIO
-remove duplicate code.
Mainwindow has the same code with Projectmanager::recentProjects().
Projectmanager::recentProjects removed and also a small change in the return of 
MainWindow::recentProjects().

sorry for the delay but i had to attend to a foss event.


Summary
---

Hello,

the method removeDirectory wasn't removing the parent folder. 
For example,if we named out plasmoid my_plasmoid it would have a directory like 
this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" 
and the after calling the removeDirectory(before the patch) method we would 
have a directory like this:
""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
With the patch the entire folder my_plasmoid is being deleted.


Diffs (updated)
-

  mainwindow.cpp e08581f 
  projectmanager/projectmanager.h 53ef226 
  projectmanager/projectmanager.cpp 122e48d 

Diff: http://git.reviewboard.kde.org/r/101550/diff


Testing
---

compiles without issues and without regressions.


Thanks,

Giorgos

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-19 Thread Aaron J. Seigo 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/#review4878
---



projectmanager/projectmanager.cpp


so now it will _only_ delete local projects?

or even worse: if you have a project with the same name as a local project, 
it will delete the local one.

what should be done is to see if the project _is_ a local project (e.g. the 
project starts with KStandardDirs::locateLocal("appdata", "/")) and if so do 
not do the cd("..") in deleteProject.


- Aaron J.


On July 19, 2011, 11 a.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101550/
> ---
> 
> (Updated July 19, 2011, 11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Hello,
> 
> the method removeDirectory wasn't removing the parent folder. 
> For example,if we named out plasmoid my_plasmoid it would have a directory 
> like this "$(kde4-config 
> --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" and the after 
> calling the removeDirectory(before the patch) method we would have a 
> directory like this:
> ""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
> With the patch the entire folder my_plasmoid is being deleted.
> 
> 
> Diffs
> -
> 
>   mainwindow.cpp e08581f 
>   projectmanager/projectmanager.h 53ef226 
>   projectmanager/projectmanager.cpp 122e48d 
> 
> Diff: http://git.reviewboard.kde.org/r/101550/diff
> 
> 
> Testing
> ---
> 
> compiles without issues and without regressions.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-20 Thread Giorgos Tsiapaliwkas 


> On July 19, 2011, 10:50 p.m., Aaron J. Seigo wrote:
> > projectmanager/projectmanager.cpp, lines 107-109
> > 
> >
> > so now it will _only_ delete local projects?
> > 
> > or even worse: if you have a project with the same name as a local 
> > project, it will delete the local one.
> > 
> > what should be done is to see if the project _is_ a local project (e.g. 
> > the project starts with KStandardDirs::locateLocal("appdata", "/")) and if 
> > so do not do the cd("..") in deleteProject.

So,you want plasmate to delete also projects that are not local(~/.kde4)?
Yes if the project is not a local one,the cd("..") is useless.Also plasmate has 
to check if a project is local or not,before it does "const QString project = 
KStandardDirs::locateLocal("appdata",recentProject + "/");".correct?


- Giorgos


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/#review4878
---


On July 19, 2011, 11 a.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101550/
> ---
> 
> (Updated July 19, 2011, 11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Hello,
> 
> the method removeDirectory wasn't removing the parent folder. 
> For example,if we named out plasmoid my_plasmoid it would have a directory 
> like this "$(kde4-config 
> --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" and the after 
> calling the removeDirectory(before the patch) method we would have a 
> directory like this:
> ""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
> With the patch the entire folder my_plasmoid is being deleted.
> 
> 
> Diffs
> -
> 
>   mainwindow.cpp e08581f 
>   projectmanager/projectmanager.h 53ef226 
>   projectmanager/projectmanager.cpp 122e48d 
> 
> Diff: http://git.reviewboard.kde.org/r/101550/diff
> 
> 
> Testing
> ---
> 
> compiles without issues and without regressions.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-22 Thread Aaron J. Seigo 


> On July 19, 2011, 10:50 p.m., Aaron J. Seigo wrote:
> > projectmanager/projectmanager.cpp, lines 107-109
> > 
> >
> > so now it will _only_ delete local projects?
> > 
> > or even worse: if you have a project with the same name as a local 
> > project, it will delete the local one.
> > 
> > what should be done is to see if the project _is_ a local project (e.g. 
> > the project starts with KStandardDirs::locateLocal("appdata", "/")) and if 
> > so do not do the cd("..") in deleteProject.
> 
> Giorgos Tsiapaliwkas wrote:
> So,you want plasmate to delete also projects that are not local(~/.kde4)?
> Yes if the project is not a local one,the cd("..") is useless.Also 
> plasmate has to check if a project is local or not,before it does "const 
> QString project = KStandardDirs::locateLocal("appdata",recentProject + 
> "/");".correct?

yes, i think it should be up to the user to delete whatever they wish :)


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/#review4878
---


On July 19, 2011, 11 a.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101550/
> ---
> 
> (Updated July 19, 2011, 11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Hello,
> 
> the method removeDirectory wasn't removing the parent folder. 
> For example,if we named out plasmoid my_plasmoid it would have a directory 
> like this "$(kde4-config 
> --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" and the after 
> calling the removeDirectory(before the patch) method we would have a 
> directory like this:
> ""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
> With the patch the entire folder my_plasmoid is being deleted.
> 
> 
> Diffs
> -
> 
>   mainwindow.cpp e08581f 
>   projectmanager/projectmanager.h 53ef226 
>   projectmanager/projectmanager.cpp 122e48d 
> 
> Diff: http://git.reviewboard.kde.org/r/101550/diff
> 
> 
> Testing
> ---
> 
> compiles without issues and without regressions.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-24 Thread Giorgos Tsiapaliwkas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/
---

(Updated July 24, 2011, 8:45 p.m.)


Review request for Plasma.


Changes
---

changes:now the user is able to remove also projects that are not being 
generated by the plasmate


Summary
---

Hello,

the method removeDirectory wasn't removing the parent folder. 
For example,if we named out plasmoid my_plasmoid it would have a directory like 
this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" 
and the after calling the removeDirectory(before the patch) method we would 
have a directory like this:
""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
With the patch the entire folder my_plasmoid is being deleted.


Diffs (updated)
-

  mainwindow.cpp 3dbdefc 
  projectmanager/projectmanager.h 53ef226 
  projectmanager/projectmanager.cpp 122e48d 

Diff: http://git.reviewboard.kde.org/r/101550/diff


Testing
---

compiles without issues and without regressions.


Thanks,

Giorgos

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-08-23 Thread Sebastian Kügler 
On Wednesday, June 08, 2011 23:51:03 Giorgos Tsiapaliwkas wrote:
> http://git.reviewboard.kde.org/r/101550/

> the method removeDirectory wasn't removing the parent folder.
> For example,if we named out plasmoid my_plasmoid it would have a directory
> like this "$(kde4-config
> --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" and the after
> calling the removeDirectory(before the patch) method we would have a
> directory like this: ""$(kde4-config
> --localprefix)/share/apps/plasmate/my_plasmoid/NOTES". With the patch the
> entire folder my_plasmoid is being deleted.

Has this patch been submitted?
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-08-25 Thread Giorgos Tsiapaliwkas 
Due to a misclick I replied only to sebas.

The patches have been commited except from one.


-- 
Tsiapaliwkas Giorgos (terietor)
KDE Developer

terietor.gr
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel