Review Request: Revert "fix compilation with debian qjson"

2012-12-11 Thread Ralf Jung

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107669/
---

Review request for Plasma.


Description
---

This reverts commit "fix compilation with debian qjson" 
(b32fefab8d258011a72a12761b3ade0b719636b1) by myself.
The issue was actually a bug in Debian, which installed incorrect qjson 
configuration files, see: 
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687537
The bug has been fixed in Debian testing and unstable, and it never reached 
stable. The lower-case variable names have never been used upstream.


Diffs
-

  plasma/generic/runners/bookmarks/CMakeLists.txt ad560f3 

Diff: http://git.reviewboard.kde.org/r/107669/diff/


Testing
---

Everything still compiles with current Debian testing, qjson is found and used.


Thanks,

Ralf Jung

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Revert "fix compilation with debian qjson"

2012-12-13 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107669/#review23421
---

Ship it!


Ship It!

- Aaron J. Seigo


On Dec. 11, 2012, 9:05 p.m., Ralf Jung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107669/
> ---
> 
> (Updated Dec. 11, 2012, 9:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> This reverts commit "fix compilation with debian qjson" 
> (b32fefab8d258011a72a12761b3ade0b719636b1) by myself.
> The issue was actually a bug in Debian, which installed incorrect qjson 
> configuration files, see: 
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687537
> The bug has been fixed in Debian testing and unstable, and it never reached 
> stable. The lower-case variable names have never been used upstream.
> 
> 
> Diffs
> -
> 
>   plasma/generic/runners/bookmarks/CMakeLists.txt ad560f3 
> 
> Diff: http://git.reviewboard.kde.org/r/107669/diff/
> 
> 
> Testing
> ---
> 
> Everything still compiles with current Debian testing, qjson is found and 
> used.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel