Re: Review Request: Use underscore instead of hyphen in .so name

2011-06-29 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101801/#review4254
---


yes, it's unfortunately inconsistent. however, is there any particular reason 
to change it at this point, other than to improve said consistency? if not, i'm 
not sure it's worth doing.

- Aaron J.


On June 29, 2011, 12:39 a.m., Christoph Feck wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/101801/
 ---
 
 (Updated June 29, 2011, 12:39 a.m.)
 
 
 Review request for Plasma.
 
 
 Summary
 ---
 
 Every other applet uses plasma_applet_name.so, but systemloadviewer uses 
 plasma-applet_name.so. This should fix it, but I don't know if I can safely 
 change the .so name.
 
 
 Diffs
 -
 
   applets/systemloadviewer/CMakeLists.txt 6de867a 
   applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 5311d2c 
 
 Diff: http://git.reviewboard.kde.org/r/101801/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Christoph
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Use underscore instead of hyphen in .so name

2011-06-28 Thread Christoph Feck

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101801/
---

Review request for Plasma.


Summary
---

Every other applet uses plasma_applet_name.so, but systemloadviewer uses 
plasma-applet_name.so. This should fix it, but I don't know if I can safely 
change the .so name.


Diffs
-

  applets/systemloadviewer/CMakeLists.txt 6de867a 
  applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 5311d2c 

Diff: http://git.reviewboard.kde.org/r/101801/diff


Testing
---


Thanks,

Christoph

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel