Review Request: declarative plasmoid object, containment access
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- Review request for Plasma. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/#review18645 --- exposing the containment to all plasmoids is not a good idea. one of the main benefits of these QML/JS plasmoids is that they are far more sandboxed from the rest of the system. this also invites plasmoids to think they know how the shell works, which they can't - it could just as easily be plasma-netbook ad plasma-desktop. let's back up and look at the problem from the starting point: the goal is to put an entry in a context menu that people can select which adds an icon for that application to the panel or the desktop (whatever that means given multiple screens, per virtual desktop views, etc.) first question: do we really need this exact feature? is drag and drop good enough? are there other ways we could offer? (e.g. in the Add widgets UI could there be a way to add applications as well?) second question: if this is really, really required can it be done without opening access to Containment? e.g. could it be done using a Plasma::Service which does the right thing for the given shell? also, i don't think missing this feature should stand in the way of the QML version replacing the C++ version in master. we need to get this merged as soon as possible so people can start using it and we can start improving problems that crop up. - Aaron J. Seigo On Sept. 7, 2012, 9:20 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 9:20 a.m.) Review request for Plasma. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
On Sept. 7, 2012, 9:43 a.m., Aaron J. Seigo wrote: exposing the containment to all plasmoids is not a good idea. one of the main benefits of these QML/JS plasmoids is that they are far more sandboxed from the rest of the system. this also invites plasmoids to think they know how the shell works, which they can't - it could just as easily be plasma-netbook ad plasma-desktop. let's back up and look at the problem from the starting point: the goal is to put an entry in a context menu that people can select which adds an icon for that application to the panel or the desktop (whatever that means given multiple screens, per virtual desktop views, etc.) first question: do we really need this exact feature? is drag and drop good enough? are there other ways we could offer? (e.g. in the Add widgets UI could there be a way to add applications as well?) second question: if this is really, really required can it be done without opening access to Containment? e.g. could it be done using a Plasma::Service which does the right thing for the given shell? also, i don't think missing this feature should stand in the way of the QML version replacing the C++ version in master. we need to get this merged as soon as possible so people can start using it and we can start improving problems that crop up. Hi Aaron, 1. I really think as long as we support a context menu, we must also provide those 2 'add to xxx' entrys. Probably our users would be rather pissed off and call it a regression, if we drop them in kickoff-qml/KDE 4.10. 2. agreed, some kind of abstraction would be a great, no idea how to implement that though. You can really do a lot of creepy things with a containment... 3. I'm ok with that, but I never merged a feature branch into master before. Can you give me some hints how to do that? It's quite a bunch of code. Actually mgraesslin created this widget, so maybe we should ask him for his opinion... - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/#review18645 --- On Sept. 7, 2012, 9:20 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 9:20 a.m.) Review request for Plasma. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 10:58 a.m.) Review request for Plasma and Martin Gräßlin. Changes --- add mgrasselin Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
On Sept. 7, 2012, 9:43 a.m., Aaron J. Seigo wrote: exposing the containment to all plasmoids is not a good idea. one of the main benefits of these QML/JS plasmoids is that they are far more sandboxed from the rest of the system. this also invites plasmoids to think they know how the shell works, which they can't - it could just as easily be plasma-netbook ad plasma-desktop. let's back up and look at the problem from the starting point: the goal is to put an entry in a context menu that people can select which adds an icon for that application to the panel or the desktop (whatever that means given multiple screens, per virtual desktop views, etc.) first question: do we really need this exact feature? is drag and drop good enough? are there other ways we could offer? (e.g. in the Add widgets UI could there be a way to add applications as well?) second question: if this is really, really required can it be done without opening access to Containment? e.g. could it be done using a Plasma::Service which does the right thing for the given shell? also, i don't think missing this feature should stand in the way of the QML version replacing the C++ version in master. we need to get this merged as soon as possible so people can start using it and we can start improving problems that crop up. Greg T wrote: Hi Aaron, 1. I really think as long as we support a context menu, we must also provide those 2 'add to xxx' entrys. Probably our users would be rather pissed off and call it a regression, if we drop them in kickoff-qml/KDE 4.10. 2. agreed, some kind of abstraction would be a great, no idea how to implement that though. You can really do a lot of creepy things with a containment... 3. I'm ok with that, but I never merged a feature branch into master before. Can you give me some hints how to do that? It's quite a bunch of code. Actually mgraesslin created this widget, so maybe we should ask him for his opinion... idea: 1) create a dataengine called org.kde.appshortcuts or something like that every source would represent a shortcut (even if just the desktop file name) 2) it has a service to add or remove shortcuts 3) the taskbar is connected to that engine and uses it for its own shortcuts would mean that: * would add shortcuts in the taskbar (and any other plasmoid connected to that) rather than directly the panel, so would need at least one connected to work * add to desktop is not supported anymore and i think is good, too many assumption on what desktop it is and where it is ;) - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/#review18645 --- On Sept. 7, 2012, 10:58 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 10:58 a.m.) Review request for Plasma and Martin Gräßlin. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
On Sept. 7, 2012, 9:43 a.m., Aaron J. Seigo wrote: exposing the containment to all plasmoids is not a good idea. one of the main benefits of these QML/JS plasmoids is that they are far more sandboxed from the rest of the system. this also invites plasmoids to think they know how the shell works, which they can't - it could just as easily be plasma-netbook ad plasma-desktop. let's back up and look at the problem from the starting point: the goal is to put an entry in a context menu that people can select which adds an icon for that application to the panel or the desktop (whatever that means given multiple screens, per virtual desktop views, etc.) first question: do we really need this exact feature? is drag and drop good enough? are there other ways we could offer? (e.g. in the Add widgets UI could there be a way to add applications as well?) second question: if this is really, really required can it be done without opening access to Containment? e.g. could it be done using a Plasma::Service which does the right thing for the given shell? also, i don't think missing this feature should stand in the way of the QML version replacing the C++ version in master. we need to get this merged as soon as possible so people can start using it and we can start improving problems that crop up. Greg T wrote: Hi Aaron, 1. I really think as long as we support a context menu, we must also provide those 2 'add to xxx' entrys. Probably our users would be rather pissed off and call it a regression, if we drop them in kickoff-qml/KDE 4.10. 2. agreed, some kind of abstraction would be a great, no idea how to implement that though. You can really do a lot of creepy things with a containment... 3. I'm ok with that, but I never merged a feature branch into master before. Can you give me some hints how to do that? It's quite a bunch of code. Actually mgraesslin created this widget, so maybe we should ask him for his opinion... Marco Martin wrote: idea: 1) create a dataengine called org.kde.appshortcuts or something like that every source would represent a shortcut (even if just the desktop file name) 2) it has a service to add or remove shortcuts 3) the taskbar is connected to that engine and uses it for its own shortcuts would mean that: * would add shortcuts in the taskbar (and any other plasmoid connected to that) rather than directly the panel, so would need at least one connected to work * add to desktop is not supported anymore and i think is good, too many assumption on what desktop it is and where it is ;) interesting, but for clarification: the idea is to add those app shortcuts as launchers to the task manager? But lets get kickoff into master before working on this topic :) - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/#review18645 --- On Sept. 7, 2012, 10:58 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 10:58 a.m.) Review request for Plasma and Martin Gräßlin. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
