Review Request: kickoff: Always select Favorites tab when opened
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1164/ --- Review request for Plasma. Summary --- Fix bug 201998 by calling reset() after the launcher origin has been set (so the tabs are in the right order). This bugfix should also apply to trunk as there aren't any additional relevant changes. This addresses bug 201998. https://bugs.kde.org/show_bug.cgi?id=201998 Diffs - branches/KDE/4.3/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 1004485 Diff: http://reviewboard.kde.org/r/1164/diff Testing --- Tested all possible placements of the launcher button. Thanks, Felix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: kickoff: Always select Favorites tab when opened
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1164/#review1859 --- Ship it! good catch! i don't see your name in the svn commiter's list. do you need someone to commit this for you? - Aaron On 2009-07-30 12:49:11, Felix Geyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1164/ --- (Updated 2009-07-30 12:49:11) Review request for Plasma. Summary --- Fix bug 201998 by calling reset() after the launcher origin has been set (so the tabs are in the right order). This bugfix should also apply to trunk as there aren't any additional relevant changes. This addresses bug 201998. https://bugs.kde.org/show_bug.cgi?id=201998 Diffs - branches/KDE/4.3/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 1004485 Diff: http://reviewboard.kde.org/r/1164/diff Testing --- Tested all possible placements of the launcher button. Thanks, Felix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: kickoff: Always select Favorites tab when opened
On 2009-07-30 18:57:09, Aaron Seigo wrote: good catch! i don't see your name in the svn commiter's list. do you need someone to commit this for you? Yes, I can't commit it myself. - Felix --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1164/#review1859 --- On 2009-07-30 12:49:11, Felix Geyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1164/ --- (Updated 2009-07-30 12:49:11) Review request for Plasma. Summary --- Fix bug 201998 by calling reset() after the launcher origin has been set (so the tabs are in the right order). This bugfix should also apply to trunk as there aren't any additional relevant changes. This addresses bug 201998. https://bugs.kde.org/show_bug.cgi?id=201998 Diffs - branches/KDE/4.3/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 1004485 Diff: http://reviewboard.kde.org/r/1164/diff Testing --- Tested all possible placements of the launcher button. Thanks, Felix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
