Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
> On Nov. 21, 2012, 7:07 p.m., Kai Uwe Broulik wrote: > > But why does the battery plasmoid always set the old brightness? Now it > > knows the current brightness and sets it itself to the right value but > > still aren't these calls not needed and thus a bug also in the plasmoid? the brightness property in the plasmoid is fed by 2 sources: the slider value in the popup and the dataengine. the qml code is a bit special because it watches both sources for changes and sets the new brightness accordingly. I've never figured out when and why the widget took the wrong/not updated value from the dataengine. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22339 --- On Nov. 21, 2012, 5:43 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107398/ > --- > > (Updated Nov. 21, 2012, 5:43 p.m.) > > > Review request for Plasma, Dario Freddi and Lukáš Tinkl. > > > Description > --- > > the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal > when you change the brightness without the brightnessKeys. I've just moved > the signal to the setBrightness function. Now the powermanagement/PowerDevil > dataengine gets also updated properly with the current brightness (this fixes > the bugs). > > > This addresses bugs 302111 and 302160. > http://bugs.kde.org/show_bug.cgi?id=302111 > http://bugs.kde.org/show_bug.cgi?id=302160 > > > Diffs > - > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp > 3d0926fab8dac334d56d5cce430691e501b6f8c7 > > Diff: http://git.reviewboard.kde.org/r/107398/diff/ > > > Testing > --- > > works on my laptop when I set the screen brightness with the batterymonitor > plasmoid > > > Thanks, > > Greg T > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22343 --- This review has been submitted with commit 1d08f4779a26ebba757111fd99182034e5282624 by Gregor Tätzner to branch master. - Commit Hook On Nov. 21, 2012, 5:43 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107398/ > --- > > (Updated Nov. 21, 2012, 5:43 p.m.) > > > Review request for Plasma, Dario Freddi and Lukáš Tinkl. > > > Description > --- > > the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal > when you change the brightness without the brightnessKeys. I've just moved > the signal to the setBrightness function. Now the powermanagement/PowerDevil > dataengine gets also updated properly with the current brightness (this fixes > the bugs). > > > This addresses bugs 302111 and 302160. > http://bugs.kde.org/show_bug.cgi?id=302111 > http://bugs.kde.org/show_bug.cgi?id=302160 > > > Diffs > - > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp > 3d0926fab8dac334d56d5cce430691e501b6f8c7 > > Diff: http://git.reviewboard.kde.org/r/107398/diff/ > > > Testing > --- > > works on my laptop when I set the screen brightness with the batterymonitor > plasmoid > > > Thanks, > > Greg T > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22342 --- This review has been submitted with commit 285553edce61f65a88d9067136bf138e44efb149 by Gregor Tätzner to branch KDE/4.9. - Commit Hook On Nov. 21, 2012, 5:43 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107398/ > --- > > (Updated Nov. 21, 2012, 5:43 p.m.) > > > Review request for Plasma, Dario Freddi and Lukáš Tinkl. > > > Description > --- > > the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal > when you change the brightness without the brightnessKeys. I've just moved > the signal to the setBrightness function. Now the powermanagement/PowerDevil > dataengine gets also updated properly with the current brightness (this fixes > the bugs). > > > This addresses bugs 302111 and 302160. > http://bugs.kde.org/show_bug.cgi?id=302111 > http://bugs.kde.org/show_bug.cgi?id=302160 > > > Diffs > - > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp > 3d0926fab8dac334d56d5cce430691e501b6f8c7 > > Diff: http://git.reviewboard.kde.org/r/107398/diff/ > > > Testing > --- > > works on my laptop when I set the screen brightness with the batterymonitor > plasmoid > > > Thanks, > > Greg T > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22339 --- But why does the battery plasmoid always set the old brightness? Now it knows the current brightness and sets it itself to the right value but still aren't these calls not needed and thus a bug also in the plasmoid? - Kai Uwe Broulik On Nov. 21, 2012, 5:43 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107398/ > --- > > (Updated Nov. 21, 2012, 5:43 p.m.) > > > Review request for Plasma, Dario Freddi and Lukáš Tinkl. > > > Description > --- > > the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal > when you change the brightness without the brightnessKeys. I've just moved > the signal to the setBrightness function. Now the powermanagement/PowerDevil > dataengine gets also updated properly with the current brightness (this fixes > the bugs). > > > This addresses bugs 302111 and 302160. > http://bugs.kde.org/show_bug.cgi?id=302111 > http://bugs.kde.org/show_bug.cgi?id=302160 > > > Diffs > - > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp > 3d0926fab8dac334d56d5cce430691e501b6f8c7 > > Diff: http://git.reviewboard.kde.org/r/107398/diff/ > > > Testing > --- > > works on my laptop when I set the screen brightness with the batterymonitor > plasmoid > > > Thanks, > > Greg T > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22338 --- Ship it! Ship It! - Dario Freddi On Nov. 21, 2012, 5:43 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107398/ > --- > > (Updated Nov. 21, 2012, 5:43 p.m.) > > > Review request for Plasma, Dario Freddi and Lukáš Tinkl. > > > Description > --- > > the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal > when you change the brightness without the brightnessKeys. I've just moved > the signal to the setBrightness function. Now the powermanagement/PowerDevil > dataengine gets also updated properly with the current brightness (this fixes > the bugs). > > > This addresses bugs 302111 and 302160. > http://bugs.kde.org/show_bug.cgi?id=302111 > http://bugs.kde.org/show_bug.cgi?id=302160 > > > Diffs > - > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp > 3d0926fab8dac334d56d5cce430691e501b6f8c7 > > Diff: http://git.reviewboard.kde.org/r/107398/diff/ > > > Testing > --- > > works on my laptop when I set the screen brightness with the batterymonitor > plasmoid > > > Thanks, > > Greg T > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- (Updated Nov. 21, 2012, 5:43 p.m.) Review request for Plasma, Dario Freddi and Lukáš Tinkl. Description --- the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal when you change the brightness without the brightnessKeys. I've just moved the signal to the setBrightness function. Now the powermanagement/PowerDevil dataengine gets also updated properly with the current brightness (this fixes the bugs). This addresses bugs 302111 and 302160. http://bugs.kde.org/show_bug.cgi?id=302111 http://bugs.kde.org/show_bug.cgi?id=302160 Diffs - powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 3d0926fab8dac334d56d5cce430691e501b6f8c7 Diff: http://git.reviewboard.kde.org/r/107398/diff/ Testing --- works on my laptop when I set the screen brightness with the batterymonitor plasmoid Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22330 --- Now that I think about it, ltinkl can review this as well ! - Àlex Fiestas On Nov. 21, 2012, 5:21 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107398/ > --- > > (Updated Nov. 21, 2012, 5:21 p.m.) > > > Review request for Plasma and Dario Freddi. > > > Description > --- > > the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal > when you change the brightness without the brightnessKeys. I've just moved > the signal to the setBrightness function. Now the powermanagement/PowerDevil > dataengine gets also updated properly with the current brightness (this fixes > the bugs). > > > This addresses bugs 302111 and 302160. > http://bugs.kde.org/show_bug.cgi?id=302111 > http://bugs.kde.org/show_bug.cgi?id=302160 > > > Diffs > - > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp > 3d0926fab8dac334d56d5cce430691e501b6f8c7 > > Diff: http://git.reviewboard.kde.org/r/107398/diff/ > > > Testing > --- > > works on my laptop when I set the screen brightness with the batterymonitor > plasmoid > > > Thanks, > > Greg T > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- (Updated Nov. 21, 2012, 5:21 p.m.) Review request for Plasma and Dario Freddi. Description --- the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal when you change the brightness without the brightnessKeys. I've just moved the signal to the setBrightness function. Now the powermanagement/PowerDevil dataengine gets also updated properly with the current brightness (this fixes the bugs). This addresses bugs 302111 and 302160. http://bugs.kde.org/show_bug.cgi?id=302111 http://bugs.kde.org/show_bug.cgi?id=302160 Diffs - powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 3d0926fab8dac334d56d5cce430691e501b6f8c7 Diff: http://git.reviewboard.kde.org/r/107398/diff/ Testing --- works on my laptop when I set the screen brightness with the batterymonitor plasmoid Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22317 --- Add Dario Freddi as reviewer and wait until he gives the ship it pls. - Àlex Fiestas On Nov. 21, 2012, 9:18 a.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107398/ > --- > > (Updated Nov. 21, 2012, 9:18 a.m.) > > > Review request for Plasma. > > > Description > --- > > the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal > when you change the brightness without the brightnessKeys. I've just moved > the signal to the setBrightness function. Now the powermanagement/PowerDevil > dataengine gets also updated properly with the current brightness (this fixes > the bugs). > > > This addresses bugs 302111 and 302160. > http://bugs.kde.org/show_bug.cgi?id=302111 > http://bugs.kde.org/show_bug.cgi?id=302160 > > > Diffs > - > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp > 3d0926fab8dac334d56d5cce430691e501b6f8c7 > > Diff: http://git.reviewboard.kde.org/r/107398/diff/ > > > Testing > --- > > works on my laptop when I set the screen brightness with the batterymonitor > plasmoid > > > Thanks, > > Greg T > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22303 --- Ship it! Ship It! - Sebastian Kügler On Nov. 21, 2012, 9:18 a.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107398/ > --- > > (Updated Nov. 21, 2012, 9:18 a.m.) > > > Review request for Plasma. > > > Description > --- > > the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal > when you change the brightness without the brightnessKeys. I've just moved > the signal to the setBrightness function. Now the powermanagement/PowerDevil > dataengine gets also updated properly with the current brightness (this fixes > the bugs). > > > This addresses bugs 302111 and 302160. > http://bugs.kde.org/show_bug.cgi?id=302111 > http://bugs.kde.org/show_bug.cgi?id=302160 > > > Diffs > - > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp > 3d0926fab8dac334d56d5cce430691e501b6f8c7 > > Diff: http://git.reviewboard.kde.org/r/107398/diff/ > > > Testing > --- > > works on my laptop when I set the screen brightness with the batterymonitor > plasmoid > > > Thanks, > > Greg T > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- Review request for Plasma. Description --- the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal when you change the brightness without the brightnessKeys. I've just moved the signal to the setBrightness function. Now the powermanagement/PowerDevil dataengine gets also updated properly with the current brightness (this fixes the bugs). This addresses bugs 302111 and 302160. http://bugs.kde.org/show_bug.cgi?id=302111 http://bugs.kde.org/show_bug.cgi?id=302160 Diffs - powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 3d0926fab8dac334d56d5cce430691e501b6f8c7 Diff: http://git.reviewboard.kde.org/r/107398/diff/ Testing --- works on my laptop when I set the screen brightness with the batterymonitor plasmoid Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
