Re: Review Request 105319: DBus-interface for changing wallpapers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105319/ --- (Updated Sept. 15, 2016, 11:33 a.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kde-workspace Description --- This patch is for hosting a dbus-interface that can be used to load any installed wallpaper plugin onto current desktop containment. In case of default "image" plugin, the path to the image can also be sent which will change the wallpaper. Diffs - plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 plasma/desktop/shell/plasmaapp.h 6ae0c89 plasma/desktop/shell/plasmaapp.cpp 7abd8fc Diff: https://git.reviewboard.kde.org/r/105319/diff/ Testing --- Tested on different activities and made sure it works for per-virtual desktop containment. Haven't tested on a system with multiple screens though, as I don't have access to one. Could someone please test for that ? Thanks, Varun Herale
Re: Review Request 105319: DBus-interface for changing wallpapers
On Фев. 8, 2013, 9:48 п.п., Albert Astals Cid wrote: Varun, it seems Aaron had some comments, can you have a look at them? Varun Herale wrote: Yes, I am looking at it right now. Andrey Bondrov wrote: My patch, based on yours and code from kdeplasma-addons/applets/frame/frame.cpp: https://bugs.kde.org/show_bug.cgi?id=217950#c18 Also it adds ResizeMethodHint and screenId as options. I'd like to port it to Plasma 5 but is it possible at all? kdeplasma-addons/applets/frame wasn't ported yet and I don't see any Plasma 5 examples how to work with wallpapers. Almost every line of the patch has to be adjusted to the new API. - Andrey --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105319/#review27009 --- On Июль 1, 2012, 5:56 д.п., Varun Herale wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105319/ --- (Updated Июль 1, 2012, 5:56 д.п.) Review request for Plasma. Repository: kde-workspace Description --- This patch is for hosting a dbus-interface that can be used to load any installed wallpaper plugin onto current desktop containment. In case of default image plugin, the path to the image can also be sent which will change the wallpaper. Diffs - plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 plasma/desktop/shell/plasmaapp.h 6ae0c89 plasma/desktop/shell/plasmaapp.cpp 7abd8fc Diff: https://git.reviewboard.kde.org/r/105319/diff/ Testing --- Tested on different activities and made sure it works for per-virtual desktop containment. Haven't tested on a system with multiple screens though, as I don't have access to one. Could someone please test for that ? Thanks, Varun Herale ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 105319: DBus-interface for changing wallpapers
On Feb. 8, 2013, 9:48 p.m., Albert Astals Cid wrote: Varun, it seems Aaron had some comments, can you have a look at them? Varun Herale wrote: Yes, I am looking at it right now. My patch, based on yours and code from kdeplasma-addons/applets/frame/frame.cpp: https://bugs.kde.org/show_bug.cgi?id=217950#c18 Also it adds ResizeMethodHint and screenId as options. - Andrey --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105319/#review27009 --- On July 1, 2012, 5:56 a.m., Varun Herale wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105319/ --- (Updated July 1, 2012, 5:56 a.m.) Review request for Plasma. Repository: kde-workspace Description --- This patch is for hosting a dbus-interface that can be used to load any installed wallpaper plugin onto current desktop containment. In case of default image plugin, the path to the image can also be sent which will change the wallpaper. Diffs - plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 plasma/desktop/shell/plasmaapp.h 6ae0c89 plasma/desktop/shell/plasmaapp.cpp 7abd8fc Diff: https://git.reviewboard.kde.org/r/105319/diff/ Testing --- Tested on different activities and made sure it works for per-virtual desktop containment. Haven't tested on a system with multiple screens though, as I don't have access to one. Could someone please test for that ? Thanks, Varun Herale ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 105319: DBus-interface for changing wallpapers
On Feb. 8, 2013, 9:48 p.m., Albert Astals Cid wrote: Varun, it seems Aaron had some comments, can you have a look at them? Yes, I am looking at it right now. - Varun --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105319/#review27009 --- On July 1, 2012, 5:56 a.m., Varun Herale wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105319/ --- (Updated July 1, 2012, 5:56 a.m.) Review request for Plasma. Description --- This patch is for hosting a dbus-interface that can be used to load any installed wallpaper plugin onto current desktop containment. In case of default image plugin, the path to the image can also be sent which will change the wallpaper. Diffs - plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 plasma/desktop/shell/plasmaapp.h 6ae0c89 plasma/desktop/shell/plasmaapp.cpp 7abd8fc Diff: http://git.reviewboard.kde.org/r/105319/diff/ Testing --- Tested on different activities and made sure it works for per-virtual desktop containment. Haven't tested on a system with multiple screens though, as I don't have access to one. Could someone please test for that ? Thanks, Varun Herale ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 105319: DBus-interface for changing wallpapers
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105319/#review27009 --- Varun, it seems Aaron had some comments, can you have a look at them? - Albert Astals Cid On July 1, 2012, 5:56 a.m., Varun Herale wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105319/ --- (Updated July 1, 2012, 5:56 a.m.) Review request for Plasma. Description --- This patch is for hosting a dbus-interface that can be used to load any installed wallpaper plugin onto current desktop containment. In case of default image plugin, the path to the image can also be sent which will change the wallpaper. Diffs - plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 plasma/desktop/shell/plasmaapp.h 6ae0c89 plasma/desktop/shell/plasmaapp.cpp 7abd8fc Diff: http://git.reviewboard.kde.org/r/105319/diff/ Testing --- Tested on different activities and made sure it works for per-virtual desktop containment. Haven't tested on a system with multiple screens though, as I don't have access to one. Could someone please test for that ? Thanks, Varun Herale ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
