Re: Review Request 110436: Add an option to disable the dimming of minimized windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110436/ --- (Updated May 15, 2013, 2:16 p.m.) Status -- This change has been discarded. Review request for Plasma. Description --- The grayscale & dimming effect applied to minimized windows in the task bar can be detrimental to usability to some people, as the lack of color makes it harder to distinguish a specific application. This commit introduces an option to disable this behavior. This addresses bug 311991. http://bugs.kde.org/show_bug.cgi?id=311991 Diffs - plasma/desktop/applets/tasks/abstracttaskitem.cpp 988b6a8da8c7b71b0e2efde4255bba3b4334e860 plasma/desktop/applets/tasks/tasks.h fe79a12088a8375113c3ee8f9191c6669138256d plasma/desktop/applets/tasks/tasks.cpp 0a86dcf57868a230cdda1a43aa35c3e95260c042 plasma/desktop/applets/tasks/tasksConfig.ui 6f3ff1825ddafc0e0dffc71eb7157978589cc663 Diff: http://git.reviewboard.kde.org/r/110436/diff/ Testing --- Thanks, Veeti Paananen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110436: Add an option to disable the dimming of minimized windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110436/#review32575 --- Sorry, we have a general policy of not supporting such "pixel pushing" configuration settings. 99.9% of the time they just work around a real problem, not by fixing the real problem but by making those affected go through the annoyance of configuration. This also means more code paths and more complexity in the configuration UI which the future maintainer needs to be maintain. My suggestion is to supply some screenshots along with relevant information (e.g. the desktop SVG theme being used if not the default, screen resolution if out of the ordinary, icon set if not oxygen, etc) and post to plasma-devel@kde.org about the issue. If we can determine the root issue, then we can address it. Not work around it. That said, thank you very much for spending the time to fix something you found didn't work for you. I appreciate that effort a lot :) - Aaron J. Seigo On May 15, 2013, 9:18 a.m., Veeti Paananen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110436/ > --- > > (Updated May 15, 2013, 9:18 a.m.) > > > Review request for Plasma. > > > Description > --- > > The grayscale & dimming effect applied to minimized windows in the task > bar can be detrimental to usability to some people, as the lack of color > makes it harder to distinguish a specific application. This commit > introduces an option to disable this behavior. > > > This addresses bug 311991. > http://bugs.kde.org/show_bug.cgi?id=311991 > > > Diffs > - > > plasma/desktop/applets/tasks/abstracttaskitem.cpp > 988b6a8da8c7b71b0e2efde4255bba3b4334e860 > plasma/desktop/applets/tasks/tasks.h > fe79a12088a8375113c3ee8f9191c6669138256d > plasma/desktop/applets/tasks/tasks.cpp > 0a86dcf57868a230cdda1a43aa35c3e95260c042 > plasma/desktop/applets/tasks/tasksConfig.ui > 6f3ff1825ddafc0e0dffc71eb7157978589cc663 > > Diff: http://git.reviewboard.kde.org/r/110436/diff/ > > > Testing > --- > > > Thanks, > > Veeti Paananen > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110436: Add an option to disable the dimming of minimized windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110436/ --- (Updated May 15, 2013, 9:18 a.m.) Review request for Plasma. Description --- The grayscale & dimming effect applied to minimized windows in the task bar can be detrimental to usability to some people, as the lack of color makes it harder to distinguish a specific application. This commit introduces an option to disable this behavior. This addresses bug 311991. http://bugs.kde.org/show_bug.cgi?id=311991 Diffs - plasma/desktop/applets/tasks/abstracttaskitem.cpp 988b6a8da8c7b71b0e2efde4255bba3b4334e860 plasma/desktop/applets/tasks/tasks.h fe79a12088a8375113c3ee8f9191c6669138256d plasma/desktop/applets/tasks/tasks.cpp 0a86dcf57868a230cdda1a43aa35c3e95260c042 plasma/desktop/applets/tasks/tasksConfig.ui 6f3ff1825ddafc0e0dffc71eb7157978589cc663 Diff: http://git.reviewboard.kde.org/r/110436/diff/ Testing --- Thanks, Veeti Paananen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 110436: Add an option to disable the dimming of minimized windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110436/ --- Review request for Plasma. Description --- The grayscale & dimming effect applied to minimized windows in the task bar can be detrimental to usability to some people, as the lack of color makes it harder to distinguish a specific application. This commit introduces an option to disable this behavior. This addresses bug 311991. http://bugs.kde.org/show_bug.cgi?id=311991 Diffs - plasma/desktop/applets/tasks/abstracttaskitem.cpp 988b6a8da8c7b71b0e2efde4255bba3b4334e860 plasma/desktop/applets/tasks/tasks.h fe79a12088a8375113c3ee8f9191c6669138256d plasma/desktop/applets/tasks/tasks.cpp 0a86dcf57868a230cdda1a43aa35c3e95260c042 plasma/desktop/applets/tasks/tasksConfig.ui 6f3ff1825ddafc0e0dffc71eb7157978589cc663 Diff: http://git.reviewboard.kde.org/r/110436/diff/ Testing --- Thanks, Veeti Paananen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
