Review Request 114362: Properly place the panels in a multiscreen environment

2013-12-09 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114362/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Ues QScreen::geometry instead of QScreen::virtualGeometry. The virtual geometry 
is, according to the documentation and empirical experience, the geometry of 
all the virtualDesktop


Diffs
-

  src/shell/panelview.cpp 2c80783 

Diff: http://git.reviewboard.kde.org/r/114362/diff/


Testing
---

Works on my system with 2 screens.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 114362: Properly place the panels in a multiscreen environment

2013-12-09 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114362/
---

(Updated Dec. 9, 2013, 2:06 p.m.)


Review request for Plasma.


Changes
---

React to the correct signal.


Repository: plasma-framework


Description
---

Ues QScreen::geometry instead of QScreen::virtualGeometry. The virtual geometry 
is, according to the documentation and empirical experience, the geometry of 
all the virtualDesktop


Diffs (updated)
-

  src/shell/panelview.cpp 2c80783 

Diff: http://git.reviewboard.kde.org/r/114362/diff/


Testing
---

Works on my system with 2 screens.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 114362: Properly place the panels in a multiscreen environment

2013-12-09 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114362/#review45389
---

Ship it!


Looks good to me.

- David Edmundson


On Dec. 9, 2013, 2:06 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114362/
> ---
> 
> (Updated Dec. 9, 2013, 2:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Ues QScreen::geometry instead of QScreen::virtualGeometry. The virtual 
> geometry is, according to the documentation and empirical experience, the 
> geometry of all the virtualDesktop
> 
> 
> Diffs
> -
> 
>   src/shell/panelview.cpp 2c80783 
> 
> Diff: http://git.reviewboard.kde.org/r/114362/diff/
> 
> 
> Testing
> ---
> 
> Works on my system with 2 screens.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 114362: Properly place the panels in a multiscreen environment

2013-12-09 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114362/#review45392
---


This review has been submitted with commit 
51fa49f002380ce90caf3423f5413743040dc182 by Aleix Pol to branch master.

- Commit Hook


On Dec. 9, 2013, 2:06 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114362/
> ---
> 
> (Updated Dec. 9, 2013, 2:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Ues QScreen::geometry instead of QScreen::virtualGeometry. The virtual 
> geometry is, according to the documentation and empirical experience, the 
> geometry of all the virtualDesktop
> 
> 
> Diffs
> -
> 
>   src/shell/panelview.cpp 2c80783 
> 
> Diff: http://git.reviewboard.kde.org/r/114362/diff/
> 
> 
> Testing
> ---
> 
> Works on my system with 2 screens.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 114362: Properly place the panels in a multiscreen environment

2013-12-09 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114362/
---

(Updated Dec. 9, 2013, 2:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
---

Ues QScreen::geometry instead of QScreen::virtualGeometry. The virtual geometry 
is, according to the documentation and empirical experience, the geometry of 
all the virtualDesktop


Diffs
-

  src/shell/panelview.cpp 2c80783 

Diff: http://git.reviewboard.kde.org/r/114362/diff/


Testing
---

Works on my system with 2 screens.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel