Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-03-05 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/
---

(Updated March 5, 2014, 11:49 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and Marco Martin.


Repository: frameworkintegration


Description
---

Add menu support to KDEPlatformSystemTrayIcon

Uses new QPA API which got introduced in Qt 5.3.

Provide an implementation for QPlatformSystemTrayIcon

The idea is to force all QSystemTrayIcon to use our status notifiers
as we don't want to provide an xembed based system tray in the next
iteration of the Plasma desktop shell anymore.

The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
the system tray icon. Unfortunately a complete wrapping is not yet
possible as we cannot create a menu. We do not want to provide a
QPlatformMenu in our PlatformTheme and thus the menu used by
QSystemTrayIcon does not have a QPlatformMenu.

This is adressed in Qt 5.3 which extends the QPA API.


Diffs
-

  autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
  src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
  src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
  src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
  src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
  src/platformtheme/kdeplatformtheme.cpp 
a5d86c27385447b7744cb8bca0cf65889872fb0b 

Diff: https://git.reviewboard.kde.org/r/116075/diff/


Testing
---

Using systray from qtbase/examples/widgets/desktop/systray


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-03-05 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review52056
---


This review has been submitted with commit 
a6c75f16514a2f8bb537f557bf8a07e957199171 by Martin Gräßlin to branch master.

- Commit Hook


On March 5, 2014, 11:14 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated March 5, 2014, 11:14 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-03-05 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review52055
---

Ship it!


Ship It!

- Kevin Ottens


On March 5, 2014, 11:14 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated March 5, 2014, 11:14 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-03-05 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/
---

(Updated March 5, 2014, 12:14 p.m.)


Review request for KDE Frameworks, Plasma and Marco Martin.


Changes
---

use std::find_if - thanks guys, learned something new today and that's a common 
usecase in KWin


Repository: frameworkintegration


Description
---

Add menu support to KDEPlatformSystemTrayIcon

Uses new QPA API which got introduced in Qt 5.3.

Provide an implementation for QPlatformSystemTrayIcon

The idea is to force all QSystemTrayIcon to use our status notifiers
as we don't want to provide an xembed based system tray in the next
iteration of the Plasma desktop shell anymore.

The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
the system tray icon. Unfortunately a complete wrapping is not yet
possible as we cannot create a menu. We do not want to provide a
QPlatformMenu in our PlatformTheme and thus the menu used by
QSystemTrayIcon does not have a QPlatformMenu.

This is adressed in Qt 5.3 which extends the QPA API.


Diffs (updated)
-

  autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
  src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
  src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
  src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
  src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
  src/platformtheme/kdeplatformtheme.cpp 
a5d86c27385447b7744cb8bca0cf65889872fb0b 

Diff: https://git.reviewboard.kde.org/r/116075/diff/


Testing
---

Using systray from qtbase/examples/widgets/desktop/systray


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-03-04 Thread Kevin Ottens 


> On Feb. 26, 2014, 9:41 a.m., Kevin Krammer wrote:
> > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 78
> > 
> >
> > I see lambdas being using later on, in which case this looks like a 
> > candidate for std::find_if() with a lambda predicate

Good catch. Indeed, what about switching to find_if here?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review50909
---


On March 3, 2014, 8:36 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated March 3, 2014, 8:36 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-03-03 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/
---

(Updated March 3, 2014, 9:36 a.m.)


Review request for KDE Frameworks, Plasma and Marco Martin.


Changes
---

Improved as suggested


Repository: frameworkintegration


Description
---

Add menu support to KDEPlatformSystemTrayIcon

Uses new QPA API which got introduced in Qt 5.3.

Provide an implementation for QPlatformSystemTrayIcon

The idea is to force all QSystemTrayIcon to use our status notifiers
as we don't want to provide an xembed based system tray in the next
iteration of the Plasma desktop shell anymore.

The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
the system tray icon. Unfortunately a complete wrapping is not yet
possible as we cannot create a menu. We do not want to provide a
QPlatformMenu in our PlatformTheme and thus the menu used by
QSystemTrayIcon does not have a QPlatformMenu.

This is adressed in Qt 5.3 which extends the QPA API.


Diffs (updated)
-

  src/platformtheme/kdeplatformtheme.cpp 
a5d86c27385447b7744cb8bca0cf65889872fb0b 
  autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
  src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
  src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
  src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
  src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116075/diff/


Testing
---

Using systray from qtbase/examples/widgets/desktop/systray


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review50911
---


+1 from me

- Marco Martin


On Feb. 26, 2014, 8:09 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated Feb. 26, 2014, 8:09 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review50910
---


+1 from me

- Marco Martin


On Feb. 26, 2014, 8:09 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated Feb. 26, 2014, 8:09 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Kevin Krammer 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review50909
---



src/platformtheme/kdeplatformsystemtrayicon.h


remove virtual and add Q_DECL_OVERRIDE?
or change the signature at SystemTrayMenu?
currently that is a bit inconsistent :)



src/platformtheme/kdeplatformsystemtrayicon.h


see above



src/platformtheme/kdeplatformsystemtrayicon.cpp


I see lambdas being using later on, in which case this looks like a 
candidate for std::find_if() with a lambda predicate


- Kevin Krammer


On Feb. 26, 2014, 8:09 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated Feb. 26, 2014, 8:09 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Thomas Braxton 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review50904
---



src/platformtheme/kdeplatformsystemtrayicon.cpp


couldn't this be replaced with m_items.removeOne(ours) ?


- Thomas Braxton


On Feb. 26, 2014, 8:09 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated Feb. 26, 2014, 8:09 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/
---

Review request for KDE Frameworks, Plasma and Marco Martin.


Repository: frameworkintegration


Description
---

Add menu support to KDEPlatformSystemTrayIcon

Uses new QPA API which got introduced in Qt 5.3.

Provide an implementation for QPlatformSystemTrayIcon

The idea is to force all QSystemTrayIcon to use our status notifiers
as we don't want to provide an xembed based system tray in the next
iteration of the Plasma desktop shell anymore.

The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
the system tray icon. Unfortunately a complete wrapping is not yet
possible as we cannot create a menu. We do not want to provide a
QPlatformMenu in our PlatformTheme and thus the menu used by
QSystemTrayIcon does not have a QPlatformMenu.

This is adressed in Qt 5.3 which extends the QPA API.


Diffs
-

  autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
  src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
  src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
  src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
  src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
  src/platformtheme/kdeplatformtheme.cpp 
a5d86c27385447b7744cb8bca0cf65889872fb0b 

Diff: https://git.reviewboard.kde.org/r/116075/diff/


Testing
---

Using systray from qtbase/examples/widgets/desktop/systray


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel