Re: Review Request 116599: Set minimum version of Wayland to 1.2

2014-03-05 Thread Aurélien Gâteau

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116599/
---

(Updated March 5, 2014, 9:02 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Repository: kde-workspace


Description
---

Latest code in infocenter requires Wayland 1.2 because it uses new fields from 
the wl_output_listener which were introduced in 1.2.

This only works when https://git.reviewboard.kde.org/r/116598/ is applied.


Diffs
-

  CMakeLists.txt 41923b6 

Diff: https://git.reviewboard.kde.org/r/116599/diff/


Testing
---

Fixes the build for me (Kubuntu Saucy, libwayland-client 1.1, no libwayland-egl)


Thanks,

Aurélien Gâteau

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 116599: Set minimum version of Wayland to 1.2

2014-03-05 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116599/#review52030
---


This review has been submitted with commit 
d61b0e229fb429d5153c09a2e41f19b7e5c06817 by Aurélien Gâteau to branch master.

- Commit Hook


On March 4, 2014, 3:56 p.m., Aurélien Gâteau wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/116599/
 ---
 
 (Updated March 4, 2014, 3:56 p.m.)
 
 
 Review request for Plasma and Martin Gräßlin.
 
 
 Repository: kde-workspace
 
 
 Description
 ---
 
 Latest code in infocenter requires Wayland 1.2 because it uses new fields 
 from the wl_output_listener which were introduced in 1.2.
 
 This only works when https://git.reviewboard.kde.org/r/116598/ is applied.
 
 
 Diffs
 -
 
   CMakeLists.txt 41923b6 
 
 Diff: https://git.reviewboard.kde.org/r/116599/diff/
 
 
 Testing
 ---
 
 Fixes the build for me (Kubuntu Saucy, libwayland-client 1.1, no 
 libwayland-egl)
 
 
 Thanks,
 
 Aurélien Gâteau
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 116599: Set minimum version of Wayland to 1.2

2014-03-04 Thread Aurélien Gâteau

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116599/
---

Review request for Plasma and Martin Gräßlin.


Repository: kde-workspace


Description
---

Latest code in infocenter requires Wayland 1.2 because it uses new fields from 
the wl_output_listener which were introduced in 1.2.

This only works when https://git.reviewboard.kde.org/r/116598/ is applied.


Diffs
-

  CMakeLists.txt 41923b6 

Diff: https://git.reviewboard.kde.org/r/116599/diff/


Testing
---

Fixes the build for me (Kubuntu Saucy, libwayland-client 1.1, no libwayland-egl)


Thanks,

Aurélien Gâteau

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 116599: Set minimum version of Wayland to 1.2

2014-03-04 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116599/#review51905
---

Ship it!


I guess it's part of what's not even needed in kinfocenter, but yeah makes 
sense to raise the version. Maybe one could go directly to 1.4

- Martin Gräßlin


On March 4, 2014, 4:56 p.m., Aurélien Gâteau wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/116599/
 ---
 
 (Updated March 4, 2014, 4:56 p.m.)
 
 
 Review request for Plasma and Martin Gräßlin.
 
 
 Repository: kde-workspace
 
 
 Description
 ---
 
 Latest code in infocenter requires Wayland 1.2 because it uses new fields 
 from the wl_output_listener which were introduced in 1.2.
 
 This only works when https://git.reviewboard.kde.org/r/116598/ is applied.
 
 
 Diffs
 -
 
   CMakeLists.txt 41923b6 
 
 Diff: https://git.reviewboard.kde.org/r/116599/diff/
 
 
 Testing
 ---
 
 Fixes the build for me (Kubuntu Saucy, libwayland-client 1.1, no 
 libwayland-egl)
 
 
 Thanks,
 
 Aurélien Gâteau
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel