Review Request 116618: Port FrameSVGItem to paint directly

2014-03-05 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116618/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Port FrameSVGItem to paint directly


Simple port, not the full thing I want to do, but should at least save quite a 
few copies.


Diffs
-

  src/declarativeimports/core/framesvgitem.h 552be6e 
  src/declarativeimports/core/framesvgitem.cpp e567e18 

Diff: https://git.reviewboard.kde.org/r/116618/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 116618: Port FrameSVGItem to paint directly

2014-03-05 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116618/
---

(Updated March 5, 2014, 3:20 p.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

Port FrameSVGItem to paint directly


Simple port, not the full thing I want to do, but should at least save quite a 
few copies.


Diffs (updated)
-

  src/declarativeimports/core/framesvgitem.h 552be6e 
  src/declarativeimports/core/framesvgitem.cpp e567e18 
  src/declarativeimports/core/svgitem.cpp 6b11046 
  src/declarativeimports/core/svgtexturenode.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116618/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 116618: Port FrameSVGItem to paint directly

2014-03-05 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116618/#review52096
---

Ship it!


Ship It!

- Marco Martin


On March 5, 2014, 3:20 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116618/
> ---
> 
> (Updated March 5, 2014, 3:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Port FrameSVGItem to paint directly
> 
> 
> Simple port, not the full thing I want to do, but should at least save quite 
> a few copies.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/framesvgitem.h 552be6e 
>   src/declarativeimports/core/framesvgitem.cpp e567e18 
>   src/declarativeimports/core/svgitem.cpp 6b11046 
>   src/declarativeimports/core/svgtexturenode.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116618/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 116618: Port FrameSVGItem to paint directly

2014-03-05 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116618/
---

(Updated March 5, 2014, 4:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
---

Port FrameSVGItem to paint directly


Simple port, not the full thing I want to do, but should at least save quite a 
few copies.


Diffs
-

  src/declarativeimports/core/framesvgitem.h 552be6e 
  src/declarativeimports/core/framesvgitem.cpp e567e18 
  src/declarativeimports/core/svgitem.cpp 6b11046 
  src/declarativeimports/core/svgtexturenode.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116618/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 116618: Port FrameSVGItem to paint directly

2014-03-05 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116618/#review52097
---


This review has been submitted with commit 
6599c2508738d829893ffc7ba4c3f0114caeb8ee by David Edmundson to branch master.

- Commit Hook


On March 5, 2014, 3:20 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116618/
> ---
> 
> (Updated March 5, 2014, 3:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Port FrameSVGItem to paint directly
> 
> 
> Simple port, not the full thing I want to do, but should at least save quite 
> a few copies.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/framesvgitem.h 552be6e 
>   src/declarativeimports/core/framesvgitem.cpp e567e18 
>   src/declarativeimports/core/svgitem.cpp 6b11046 
>   src/declarativeimports/core/svgtexturenode.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116618/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel