Re: Review Request 116907: Implemented Player MPRIS spec adaptor
On March 26, 2014, 6:09 p.m., Alex Merry wrote: All looks sane. Is this Qt4 or Qt5? Because you've got a KUrl in the added code... Bhushan Shah wrote: Qt4 OK, that's fine then. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review54220 --- On March 26, 2014, 5:23 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 5:23 p.m.) Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review54371 --- This review has been submitted with commit 2b9d28e02660906a41b4809635f2de1ee5007cdf by Ashish Madeti to branch sujith-dbus-mpris. - Commit Hook On March 26, 2014, 5:23 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 5:23 p.m.) Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 27, 2014, 8:33 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review54375 --- This review has been submitted with commit 9d7fb9c1efa1228c3a8ddcd6ed2a28424f6dbe8a by Ashish Madeti to branch sujith-dbus-mpris. - Commit Hook On March 27, 2014, 8:33 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 27, 2014, 8:33 p.m.) Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 12:16 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Implemented Rate property and polished a bit. Tested with mpristester : https://github.com/randomguy3/mpristester Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs (updated) - libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 mediaelements/playlist/Playlist.qml 5dde297 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review54208 --- I have general feedback around the code below. It will be nice if you can poke someone who has written MPRIS-related code before to review this before finalizing. libs/mpris2/mediaplayer2.cpp https://git.reviewboard.kde.org/r/116907/#comment37904 This would look better- QDBusConnection::sessionBus().registerObject(/org/mpris/MediaPlayer2, this, QDBusConnection::ExportAllSlots | QDBusConnection::ExportAllProperties | QDBusConnection::ExportAllSignals); libs/mpris2/mediaplayer2player.h https://git.reviewboard.kde.org/r/116907/#comment37906 Are these supposed to be called on this object from outside? If yes, why are these protected? If no, why Q_INVOKABLE? libs/mpris2/mediaplayer2player.cpp https://git.reviewboard.kde.org/r/116907/#comment37907 How is 64 decided? libs/mpris2/mediaplayer2player.cpp https://git.reviewboard.kde.org/r/116907/#comment37909 if and else need braces, even when single-line, see http://techbase.kde.org/Policies/Kdelibs_Coding_Style libs/mpris2/mediaplayer2player.cpp https://git.reviewboard.kde.org/r/116907/#comment37910 const int shells/newshell/mainwindow.cpp https://git.reviewboard.kde.org/r/116907/#comment37911 whitespace shells/newshell/package/contents/ui/mediacenter.qml https://git.reviewboard.kde.org/r/116907/#comment37912 instead of this, can't you use onPlayRequested instead? Its better to avoid dependencies for components (In this case Playlist requires a mprisPlayer to work). - Shantanu Tushar On March 26, 2014, 6:46 a.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 6:46 a.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 mediaelements/playlist/Playlist.qml 5dde297 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 10:53 p.m.) Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Made necessary changes. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs (updated) - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review54220 --- All looks sane. Is this Qt4 or Qt5? Because you've got a KUrl in the added code... - Alex Merry On March 26, 2014, 5:23 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 5:23 p.m.) Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
On March 26, 2014, 11:39 p.m., Alex Merry wrote: All looks sane. Is this Qt4 or Qt5? Because you've got a KUrl in the added code... Qt4 - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review54220 --- On March 26, 2014, 10:53 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 10:53 p.m.) Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 12:32 a.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Completely implemented the Player adaptor. Tested with qdbusviewer and Now Playing plasmoid. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs (updated) - shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/playlist/Playlist.qml 5dde297 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review54139 --- Could you test it with https://github.com/randomguy3/mpristester please? It's much more comprehensive than the now playing applet. - Alex Merry On March 25, 2014, 7:02 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 25, 2014, 7:02 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/playlist/Playlist.qml 5dde297 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review53510 --- libs/mpris2/mediaplayer2player.cpp https://git.reviewboard.kde.org/r/116907/#comment37608 m_volume = qBound(0.0, volume, 1.0); Maybe? - Emmanuel Pescosta On March 19, 2014, 6:22 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 19, 2014, 6:22 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 20, 2014, 7:53 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Adopted a better way of ensuring volume remains in bounds, as suggested by Emmanuel Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs (updated) - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 20, 2014, 8:04 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- A typo in the previous patch. Sorry Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs (updated) - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review53474 --- Ashish can you explain why do we need session bus for every single adaptor? Just wanted to know what advantage would that make? - Sujith Haridasan On March 19, 2014, 5:22 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 19, 2014, 5:22 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
On March 20, 2014, 11 a.m., Sujith Haridasan wrote: Ashish can you explain why do we need session bus for every single adaptor? Just wanted to know what advantage would that make? We need to register each adaptor on session bus separately (i.e in their respective constructors) because if we register all the adaptors at one go, say in the constructor of MPRIS class, we will not be able to handle the events in a particular adaptor from QML (as QML will create a separate instance which has not been registered on sessionBus). Therefore, we use MPRIS adaptor only to register PMC as a service on session bus. Each adaptor registers itself as an object from its own constructor. PS: If we find that some adaptor has no relation whatsoever with QML, then we can register it right from MPRIS class (as a future change). - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review53474 --- On March 19, 2014, 10:52 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 19, 2014, 10:52 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
