Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2015-04-04 Thread Gregor Mi 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/
---

(Updated April 4, 2015, 4:11 p.m.)


Status
--

This change has been discarded.


Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Sebastian 
Kügler.


Repository: kdeplasma-addons


Description
---

Summary
---
Add two options:
  1. Show confirmation before sending (to prevent accidental sending of maybe 
sensible data)
  2. Appearance: Restrict width on large host panel (to prevent huge icon on 
large panels)

How does this change manifest on screen?

Settings dialog:
  - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
  - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png

Behaviour:
  1. "Show confirmation before sending" turned on and after dropping an image: 
http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
  2. "Appearance: Restrict width on large host panel"
 - turned off (default): 
http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to 
other icons in system tray)
 - turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png 
(the width is restricted so it does not eat up horizontal space)

Open issues
---
- Is there a default "review board TARGET_GROUP" for kdeplasma-addons 
review-request?

@apol: I saw that in the frameworks branch you replaced pastebin with 
quickshare. I haven't had the chance to test it out. Does it already have the 
same features as pastebin?


Diffs
-

  applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
  applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 
  applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e 
  .gitignore PRE-CREATION 
  .reviewboardrc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117041/diff/


Testing
---

See screenshots in description. Test if settings are getting stored. Test with 
different form factors (horizontal, vertical).


Thanks,

Gregor Mi

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2014-04-01 Thread Gregor Mi 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/
---

(Updated April 1, 2014, 8:05 p.m.)


Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Sebastian 
Kügler.


Changes
---

Hi Sebastian,

Dominik suggested that you might give input to this review request.

The code is now at a "shipitable" state. Maybe one of you core plasma guys 
could confirm that. There is one minor issue, though:

When unchecking (and only then) the new "Restrict width on large host panel" 
checkbox the applet size is not updated until a resize event occurs. The other 
way round (checking the checkbox) it works well (applet width -- or height -- 
is immediately restricted). So if you see how to fix this at once that would be 
appreciated. If it would consume too much time to find the cause, it won't hurt 
to leave it like it is since in the end all applets should be ported to QML 
anyway.

Thanks & Best regards


Repository: kdeplasma-addons


Description
---

Summary
---
Add two options:
  1. Show confirmation before sending (to prevent accidental sending of maybe 
sensible data)
  2. Appearance: Restrict width on large host panel (to prevent huge icon on 
large panels)

How does this change manifest on screen?

Settings dialog:
  - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
  - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png

Behaviour:
  1. "Show confirmation before sending" turned on and after dropping an image: 
http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
  2. "Appearance: Restrict width on large host panel"
 - turned off (default): 
http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to 
other icons in system tray)
 - turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png 
(the width is restricted so it does not eat up horizontal space)

Open issues
---
- Is there a default "review board TARGET_GROUP" for kdeplasma-addons 
review-request?

@apol: I saw that in the frameworks branch you replaced pastebin with 
quickshare. I haven't had the chance to test it out. Does it already have the 
same features as pastebin?


Diffs
-

  applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
  applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 
  applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e 
  .gitignore PRE-CREATION 
  .reviewboardrc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117041/diff/


Testing
---

See screenshots in description. Test if settings are getting stored. Test with 
different form factors (horizontal, vertical).


Thanks,

Gregor Mi

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2014-03-30 Thread Gregor Mi 


> On March 25, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote:
> > The frameworks version is ready, but the GUI is a complete rewrite as in 
> > Plasma 2, C++ plasmoids are not supported.
> > 
> > Personally, I don't think these options are needed:
> > 1. I've never had a problem with accidentally sharing anything.
> > 2. the plasmoid should have enough resources to know what size it should 
> > be. I would prefer a saner default.
> > 
> > Regarding the group, you should use plasma.
> 
> Gregor Mi wrote:
> 1. This is why I made it an option. :)
> In my opinion, potentially private data should not be send to the 
> internet without given the user the chance to know what is happening. When I 
> was using pastebin the first time I was a bit surprised how quick the data 
> went away.
> Advanced users can easily disable this option. With the "do not ask 
> again" method suggested by Dominik it should not hurt at all.
> 
> 2. Are you referring to the default width (or height) of 22.0 pixels? Or 
> the widget geometry in general? Do you already have a "saner default" in mind?
> 
> > complete rewrite as in Plasma 2, C++ plasmoids are not supported
> Is plasma2 going to be released with KDE frameworks 5? Because there are 
> still many c++ applets in the frameworks branch. So all of them have to be 
> rewritten?
>
> 
> Aleix Pol Gonzalez wrote:
> 1. So you mean that only advanced users care about sharing too much data?
> 2. Well, I guess you added this option because the applet became huge, 
> right?
> 
> Yes, either the applets get rewritten or they die. And actually it's not 
> a trivial task.
> 
> Dominik Haumann wrote:
> Hi Aleix,
> 
> to 1) I'm pretty sure this is not at all what Gregor wants to say. It's 
> more like the behavior should be:
> - On a fresh install, the message box asks you whether you really want to 
> send the data.
> - This message box always pops up, except if you
>   - either activated "[x] Don't show again",
>   - or you deactivated in the settings "[ ] Ask for confirmation"
> 
> Granted, the code in the review request does not yet fully do that (as 
> far as I can see), but this is totally NOT about "advanced users not careing 
> about sharing too much data" ;)
> 
> Gregor Mi wrote:
> to 1) Dominik is right.
> to 2) Correct, I find the icon gets massively huge. :) I would very much 
> welcome a saner default. But as with all defaults I guess this will be a big 
> discussion. Maybe others like the huge icon? I would like to have the icons 
> start stacking vertically if the certain panel width is reached as it is 
> already done with the system tray icons (see 
> http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png). Or do it like in 
> Windows 7 (just have a thin button with no text or icon at all for the show 
> desktop feature)?
> 
> Aleix Pol Gonzalez wrote:
> 1) What about leaving some time before it starts sending so you can stop 
> the sending instead? A bit like the undo send e-mail in GMail.

1) time delay: nice idea. There is one drawback I see: in contrast to email the 
user expects a direct answer (the URL of the pasted stuff). So the time delay 
could hinder the workflow. Some additional thought must be put how to design 
the UI where and how the cancel message should be displayed (on the icon which 
might be small? as Popup? I currently don't have an overview of all the 
possiblities). So, for the first iteration I would stick to the message box 
only.

Who would be responsible to give a ShipIt for this request?


- Gregor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/#review54054
---


On March 27, 2014, 11:54 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117041/
> ---
> 
> (Updated March 27, 2014, 11:54 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan 
> Čukić.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Summary
> ---
> Add two options:
>   1. Show confirmation before sending (to prevent accidental sending of maybe 
> sensible data)
>   2. Appearance: Restrict width on large host panel (to prevent huge icon on 
> large panels)
> 
> How does this change manifest on screen?
> 
> Settings dialog:
>   - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
>   - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
> 
> Behaviour:
>   1. "Show confirmation before sending" turned on and after dropping an 
> image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
>   2. "Appearanc

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2014-03-27 Thread Aleix Pol Gonzalez 


> On March 25, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote:
> > The frameworks version is ready, but the GUI is a complete rewrite as in 
> > Plasma 2, C++ plasmoids are not supported.
> > 
> > Personally, I don't think these options are needed:
> > 1. I've never had a problem with accidentally sharing anything.
> > 2. the plasmoid should have enough resources to know what size it should 
> > be. I would prefer a saner default.
> > 
> > Regarding the group, you should use plasma.
> 
> Gregor Mi wrote:
> 1. This is why I made it an option. :)
> In my opinion, potentially private data should not be send to the 
> internet without given the user the chance to know what is happening. When I 
> was using pastebin the first time I was a bit surprised how quick the data 
> went away.
> Advanced users can easily disable this option. With the "do not ask 
> again" method suggested by Dominik it should not hurt at all.
> 
> 2. Are you referring to the default width (or height) of 22.0 pixels? Or 
> the widget geometry in general? Do you already have a "saner default" in mind?
> 
> > complete rewrite as in Plasma 2, C++ plasmoids are not supported
> Is plasma2 going to be released with KDE frameworks 5? Because there are 
> still many c++ applets in the frameworks branch. So all of them have to be 
> rewritten?
>
> 
> Aleix Pol Gonzalez wrote:
> 1. So you mean that only advanced users care about sharing too much data?
> 2. Well, I guess you added this option because the applet became huge, 
> right?
> 
> Yes, either the applets get rewritten or they die. And actually it's not 
> a trivial task.
> 
> Dominik Haumann wrote:
> Hi Aleix,
> 
> to 1) I'm pretty sure this is not at all what Gregor wants to say. It's 
> more like the behavior should be:
> - On a fresh install, the message box asks you whether you really want to 
> send the data.
> - This message box always pops up, except if you
>   - either activated "[x] Don't show again",
>   - or you deactivated in the settings "[ ] Ask for confirmation"
> 
> Granted, the code in the review request does not yet fully do that (as 
> far as I can see), but this is totally NOT about "advanced users not careing 
> about sharing too much data" ;)
> 
> Gregor Mi wrote:
> to 1) Dominik is right.
> to 2) Correct, I find the icon gets massively huge. :) I would very much 
> welcome a saner default. But as with all defaults I guess this will be a big 
> discussion. Maybe others like the huge icon? I would like to have the icons 
> start stacking vertically if the certain panel width is reached as it is 
> already done with the system tray icons (see 
> http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png). Or do it like in 
> Windows 7 (just have a thin button with no text or icon at all for the show 
> desktop feature)?

1) What about leaving some time before it starts sending so you can stop the 
sending instead? A bit like the undo send e-mail in GMail.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/#review54054
---


On March 27, 2014, 11:54 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117041/
> ---
> 
> (Updated March 27, 2014, 11:54 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan 
> Čukić.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Summary
> ---
> Add two options:
>   1. Show confirmation before sending (to prevent accidental sending of maybe 
> sensible data)
>   2. Appearance: Restrict width on large host panel (to prevent huge icon on 
> large panels)
> 
> How does this change manifest on screen?
> 
> Settings dialog:
>   - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
>   - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
> 
> Behaviour:
>   1. "Show confirmation before sending" turned on and after dropping an 
> image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
>   2. "Appearance: Restrict width on large host panel"
>  - turned off (default): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared 
> to other icons in system tray)
>  - turned on (new): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is 
> restricted so it does not eat up horizontal space)
> 
> Open issues
> ---
> - Is there a default "review board TARGET_GROUP" for kdeplasma-addons 
> review-request?
> 
> @apol: I saw that in the frameworks branch you replaced pastebin with 
> quickshare. I haven't had the chance to

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2014-03-27 Thread Gregor Mi 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/
---

(Updated March 27, 2014, 11:54 p.m.)


Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan Čukić.


Changes
---

- rename "Show confirmation" to "Ask for confirmation"
- fix messagebox
- .reviewboardrc: target group: plasma


Repository: kdeplasma-addons


Description
---

Summary
---
Add two options:
  1. Show confirmation before sending (to prevent accidental sending of maybe 
sensible data)
  2. Appearance: Restrict width on large host panel (to prevent huge icon on 
large panels)

How does this change manifest on screen?

Settings dialog:
  - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
  - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png

Behaviour:
  1. "Show confirmation before sending" turned on and after dropping an image: 
http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
  2. "Appearance: Restrict width on large host panel"
 - turned off (default): 
http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to 
other icons in system tray)
 - turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png 
(the width is restricted so it does not eat up horizontal space)

Open issues
---
- Is there a default "review board TARGET_GROUP" for kdeplasma-addons 
review-request?

@apol: I saw that in the frameworks branch you replaced pastebin with 
quickshare. I haven't had the chance to test it out. Does it already have the 
same features as pastebin?


Diffs (updated)
-

  applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
  applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 
  applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e 
  .gitignore PRE-CREATION 
  .reviewboardrc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117041/diff/


Testing
---

See screenshots in description. Test if settings are getting stored. Test with 
different form factors (horizontal, vertical).


Thanks,

Gregor Mi

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2014-03-27 Thread Gregor Mi 


> On March 25, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote:
> > The frameworks version is ready, but the GUI is a complete rewrite as in 
> > Plasma 2, C++ plasmoids are not supported.
> > 
> > Personally, I don't think these options are needed:
> > 1. I've never had a problem with accidentally sharing anything.
> > 2. the plasmoid should have enough resources to know what size it should 
> > be. I would prefer a saner default.
> > 
> > Regarding the group, you should use plasma.
> 
> Gregor Mi wrote:
> 1. This is why I made it an option. :)
> In my opinion, potentially private data should not be send to the 
> internet without given the user the chance to know what is happening. When I 
> was using pastebin the first time I was a bit surprised how quick the data 
> went away.
> Advanced users can easily disable this option. With the "do not ask 
> again" method suggested by Dominik it should not hurt at all.
> 
> 2. Are you referring to the default width (or height) of 22.0 pixels? Or 
> the widget geometry in general? Do you already have a "saner default" in mind?
> 
> > complete rewrite as in Plasma 2, C++ plasmoids are not supported
> Is plasma2 going to be released with KDE frameworks 5? Because there are 
> still many c++ applets in the frameworks branch. So all of them have to be 
> rewritten?
>
> 
> Aleix Pol Gonzalez wrote:
> 1. So you mean that only advanced users care about sharing too much data?
> 2. Well, I guess you added this option because the applet became huge, 
> right?
> 
> Yes, either the applets get rewritten or they die. And actually it's not 
> a trivial task.
> 
> Dominik Haumann wrote:
> Hi Aleix,
> 
> to 1) I'm pretty sure this is not at all what Gregor wants to say. It's 
> more like the behavior should be:
> - On a fresh install, the message box asks you whether you really want to 
> send the data.
> - This message box always pops up, except if you
>   - either activated "[x] Don't show again",
>   - or you deactivated in the settings "[ ] Ask for confirmation"
> 
> Granted, the code in the review request does not yet fully do that (as 
> far as I can see), but this is totally NOT about "advanced users not careing 
> about sharing too much data" ;)

to 1) Dominik is right.
to 2) Correct, I find the icon gets massively huge. :) I would very much 
welcome a saner default. But as with all defaults I guess this will be a big 
discussion. Maybe others like the huge icon? I would like to have the icons 
start stacking vertically if the certain panel width is reached as it is 
already done with the system tray icons (see 
http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png). Or do it like in 
Windows 7 (just have a thin button with no text or icon at all for the show 
desktop feature)?


- Gregor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/#review54054
---


On March 25, 2014, 10:24 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117041/
> ---
> 
> (Updated March 25, 2014, 10:24 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan 
> Čukić.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Summary
> ---
> Add two options:
>   1. Show confirmation before sending (to prevent accidental sending of maybe 
> sensible data)
>   2. Appearance: Restrict width on large host panel (to prevent huge icon on 
> large panels)
> 
> How does this change manifest on screen?
> 
> Settings dialog:
>   - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
>   - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
> 
> Behaviour:
>   1. "Show confirmation before sending" turned on and after dropping an 
> image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
>   2. "Appearance: Restrict width on large host panel"
>  - turned off (default): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared 
> to other icons in system tray)
>  - turned on (new): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is 
> restricted so it does not eat up horizontal space)
> 
> Open issues
> ---
> - Is there a default "review board TARGET_GROUP" for kdeplasma-addons 
> review-request?
> 
> @apol: I saw that in the frameworks branch you replaced pastebin with 
> quickshare. I haven't had the chance to test it out. Does it already have the 
> same features as pastebin?
> 
> 
> Diffs
> -
> 
>   applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
>   .gitig

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2014-03-27 Thread Gregor Mi 


> On March 25, 2014, 12:34 p.m., Dominik Haumann wrote:
> > applets/pastebin/pastebin.cpp, line 763
> > 
> >
> > You could use the dontAskAgainName here to add a checkbox to the dialog:
> > KMessageBox::questionYesNo(
> >   QWidget *parent,
> >   const QString &text,
> >   const QString &caption=QString(),
> >   const KGuiItem &buttonYes
> > = KStandardGuiItem::yes(),
> >   const KGuiItem &buttonNo
> > = KStandardGuiItem::no(),
> >   const QString &dontAskAgainName
> > = QString(),
> >   Options options=Notify)
> > 
> > After this message box, you can check with shouldBeShownYesNo(...) 
> > whether for the checkbox result and adapt the variable 
> > m_configShowConfirmationBeforeSending, see
> > 
> > http://api.kde.org/4.12-api/kdelibs-apidocs/kdeui/html/kmessagebox_8h_source.html
> > for existing methods.
> 
> Gregor Mi wrote:
> Thanks for the hint. I'll try to implement it.
> 
> Gregor Mi wrote:
> By trying I found out that the dontAskAgain thing makes no sense here 
> because the user is asked TWO questions:
> 1. "Should the data be sent?"
> 2. "Would you like to see the message next time?"
> This cannot be done with a single message box, right?
> So I'll change the messagebox text to "Data is about to be sent to the 
> internet. Continue?\r\r(You can disable this message in the applet settings)"

Clarification of the previous post: What should be done if the user chooses 
"No" and checks the "dont ask again" box? Should be data then NOT be sent next 
time (which would render the applet useless)? Or should the "dont ask again" 
choice be ignored in this case (which seems not the right way how to use this 
functionality)?


- Gregor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/#review54097
---


On March 25, 2014, 10:24 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117041/
> ---
> 
> (Updated March 25, 2014, 10:24 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan 
> Čukić.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Summary
> ---
> Add two options:
>   1. Show confirmation before sending (to prevent accidental sending of maybe 
> sensible data)
>   2. Appearance: Restrict width on large host panel (to prevent huge icon on 
> large panels)
> 
> How does this change manifest on screen?
> 
> Settings dialog:
>   - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
>   - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
> 
> Behaviour:
>   1. "Show confirmation before sending" turned on and after dropping an 
> image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
>   2. "Appearance: Restrict width on large host panel"
>  - turned off (default): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared 
> to other icons in system tray)
>  - turned on (new): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is 
> restricted so it does not eat up horizontal space)
> 
> Open issues
> ---
> - Is there a default "review board TARGET_GROUP" for kdeplasma-addons 
> review-request?
> 
> @apol: I saw that in the frameworks branch you replaced pastebin with 
> quickshare. I haven't had the chance to test it out. Does it already have the 
> same features as pastebin?
> 
> 
> Diffs
> -
> 
>   applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
>   .gitignore PRE-CREATION 
>   .reviewboardrc PRE-CREATION 
>   applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e 
>   applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 
> 
> Diff: https://git.reviewboard.kde.org/r/117041/diff/
> 
> 
> Testing
> ---
> 
> See screenshots in description. Test if settings are getting stored. Test 
> with different form factors (horizontal, vertical).
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2014-03-27 Thread Gregor Mi 


> On March 25, 2014, 12:34 p.m., Dominik Haumann wrote:
> > applets/pastebin/pastebin.cpp, line 763
> > 
> >
> > You could use the dontAskAgainName here to add a checkbox to the dialog:
> > KMessageBox::questionYesNo(
> >   QWidget *parent,
> >   const QString &text,
> >   const QString &caption=QString(),
> >   const KGuiItem &buttonYes
> > = KStandardGuiItem::yes(),
> >   const KGuiItem &buttonNo
> > = KStandardGuiItem::no(),
> >   const QString &dontAskAgainName
> > = QString(),
> >   Options options=Notify)
> > 
> > After this message box, you can check with shouldBeShownYesNo(...) 
> > whether for the checkbox result and adapt the variable 
> > m_configShowConfirmationBeforeSending, see
> > 
> > http://api.kde.org/4.12-api/kdelibs-apidocs/kdeui/html/kmessagebox_8h_source.html
> > for existing methods.
> 
> Gregor Mi wrote:
> Thanks for the hint. I'll try to implement it.

By trying I found out that the dontAskAgain thing makes no sense here because 
the user is asked TWO questions:
1. "Should the data be sent?"
2. "Would you like to see the message next time?"
This cannot be done with a single message box, right?
So I'll change the messagebox text to "Data is about to be sent to the 
internet. Continue?\r\r(You can disable this message in the applet settings)"


- Gregor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/#review54097
---


On March 25, 2014, 10:24 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117041/
> ---
> 
> (Updated March 25, 2014, 10:24 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan 
> Čukić.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Summary
> ---
> Add two options:
>   1. Show confirmation before sending (to prevent accidental sending of maybe 
> sensible data)
>   2. Appearance: Restrict width on large host panel (to prevent huge icon on 
> large panels)
> 
> How does this change manifest on screen?
> 
> Settings dialog:
>   - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
>   - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
> 
> Behaviour:
>   1. "Show confirmation before sending" turned on and after dropping an 
> image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
>   2. "Appearance: Restrict width on large host panel"
>  - turned off (default): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared 
> to other icons in system tray)
>  - turned on (new): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is 
> restricted so it does not eat up horizontal space)
> 
> Open issues
> ---
> - Is there a default "review board TARGET_GROUP" for kdeplasma-addons 
> review-request?
> 
> @apol: I saw that in the frameworks branch you replaced pastebin with 
> quickshare. I haven't had the chance to test it out. Does it already have the 
> same features as pastebin?
> 
> 
> Diffs
> -
> 
>   applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
>   .gitignore PRE-CREATION 
>   .reviewboardrc PRE-CREATION 
>   applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e 
>   applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 
> 
> Diff: https://git.reviewboard.kde.org/r/117041/diff/
> 
> 
> Testing
> ---
> 
> See screenshots in description. Test if settings are getting stored. Test 
> with different form factors (horizontal, vertical).
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2014-03-26 Thread Dominik Haumann 


> On March 25, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote:
> > The frameworks version is ready, but the GUI is a complete rewrite as in 
> > Plasma 2, C++ plasmoids are not supported.
> > 
> > Personally, I don't think these options are needed:
> > 1. I've never had a problem with accidentally sharing anything.
> > 2. the plasmoid should have enough resources to know what size it should 
> > be. I would prefer a saner default.
> > 
> > Regarding the group, you should use plasma.
> 
> Gregor Mi wrote:
> 1. This is why I made it an option. :)
> In my opinion, potentially private data should not be send to the 
> internet without given the user the chance to know what is happening. When I 
> was using pastebin the first time I was a bit surprised how quick the data 
> went away.
> Advanced users can easily disable this option. With the "do not ask 
> again" method suggested by Dominik it should not hurt at all.
> 
> 2. Are you referring to the default width (or height) of 22.0 pixels? Or 
> the widget geometry in general? Do you already have a "saner default" in mind?
> 
> > complete rewrite as in Plasma 2, C++ plasmoids are not supported
> Is plasma2 going to be released with KDE frameworks 5? Because there are 
> still many c++ applets in the frameworks branch. So all of them have to be 
> rewritten?
>
> 
> Aleix Pol Gonzalez wrote:
> 1. So you mean that only advanced users care about sharing too much data?
> 2. Well, I guess you added this option because the applet became huge, 
> right?
> 
> Yes, either the applets get rewritten or they die. And actually it's not 
> a trivial task.

Hi Aleix,

to 1) I'm pretty sure this is not at all what Gregor wants to say. It's more 
like the behavior should be:
- On a fresh install, the message box asks you whether you really want to send 
the data.
- This message box always pops up, except if you
  - either activated "[x] Don't show again",
  - or you deactivated in the settings "[ ] Ask for confirmation"

Granted, the code in the review request does not yet fully do that (as far as I 
can see), but this is totally NOT about "advanced users not careing about 
sharing too much data" ;)


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/#review54054
---


On March 25, 2014, 10:24 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117041/
> ---
> 
> (Updated March 25, 2014, 10:24 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan 
> Čukić.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Summary
> ---
> Add two options:
>   1. Show confirmation before sending (to prevent accidental sending of maybe 
> sensible data)
>   2. Appearance: Restrict width on large host panel (to prevent huge icon on 
> large panels)
> 
> How does this change manifest on screen?
> 
> Settings dialog:
>   - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
>   - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
> 
> Behaviour:
>   1. "Show confirmation before sending" turned on and after dropping an 
> image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
>   2. "Appearance: Restrict width on large host panel"
>  - turned off (default): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared 
> to other icons in system tray)
>  - turned on (new): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is 
> restricted so it does not eat up horizontal space)
> 
> Open issues
> ---
> - Is there a default "review board TARGET_GROUP" for kdeplasma-addons 
> review-request?
> 
> @apol: I saw that in the frameworks branch you replaced pastebin with 
> quickshare. I haven't had the chance to test it out. Does it already have the 
> same features as pastebin?
> 
> 
> Diffs
> -
> 
>   applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
>   .gitignore PRE-CREATION 
>   .reviewboardrc PRE-CREATION 
>   applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e 
>   applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 
> 
> Diff: https://git.reviewboard.kde.org/r/117041/diff/
> 
> 
> Testing
> ---
> 
> See screenshots in description. Test if settings are getting stored. Test 
> with different form factors (horizontal, vertical).
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2014-03-25 Thread Aleix Pol Gonzalez 


> On March 25, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote:
> > The frameworks version is ready, but the GUI is a complete rewrite as in 
> > Plasma 2, C++ plasmoids are not supported.
> > 
> > Personally, I don't think these options are needed:
> > 1. I've never had a problem with accidentally sharing anything.
> > 2. the plasmoid should have enough resources to know what size it should 
> > be. I would prefer a saner default.
> > 
> > Regarding the group, you should use plasma.
> 
> Gregor Mi wrote:
> 1. This is why I made it an option. :)
> In my opinion, potentially private data should not be send to the 
> internet without given the user the chance to know what is happening. When I 
> was using pastebin the first time I was a bit surprised how quick the data 
> went away.
> Advanced users can easily disable this option. With the "do not ask 
> again" method suggested by Dominik it should not hurt at all.
> 
> 2. Are you referring to the default width (or height) of 22.0 pixels? Or 
> the widget geometry in general? Do you already have a "saner default" in mind?
> 
> > complete rewrite as in Plasma 2, C++ plasmoids are not supported
> Is plasma2 going to be released with KDE frameworks 5? Because there are 
> still many c++ applets in the frameworks branch. So all of them have to be 
> rewritten?
>

1. So you mean that only advanced users care about sharing too much data?
2. Well, I guess you added this option because the applet became huge, right?

Yes, either the applets get rewritten or they die. And actually it's not a 
trivial task.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/#review54054
---


On March 25, 2014, 10:24 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117041/
> ---
> 
> (Updated March 25, 2014, 10:24 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan 
> Čukić.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Summary
> ---
> Add two options:
>   1. Show confirmation before sending (to prevent accidental sending of maybe 
> sensible data)
>   2. Appearance: Restrict width on large host panel (to prevent huge icon on 
> large panels)
> 
> How does this change manifest on screen?
> 
> Settings dialog:
>   - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
>   - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
> 
> Behaviour:
>   1. "Show confirmation before sending" turned on and after dropping an 
> image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
>   2. "Appearance: Restrict width on large host panel"
>  - turned off (default): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared 
> to other icons in system tray)
>  - turned on (new): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is 
> restricted so it does not eat up horizontal space)
> 
> Open issues
> ---
> - Is there a default "review board TARGET_GROUP" for kdeplasma-addons 
> review-request?
> 
> @apol: I saw that in the frameworks branch you replaced pastebin with 
> quickshare. I haven't had the chance to test it out. Does it already have the 
> same features as pastebin?
> 
> 
> Diffs
> -
> 
>   applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
>   .gitignore PRE-CREATION 
>   .reviewboardrc PRE-CREATION 
>   applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e 
>   applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 
> 
> Diff: https://git.reviewboard.kde.org/r/117041/diff/
> 
> 
> Testing
> ---
> 
> See screenshots in description. Test if settings are getting stored. Test 
> with different form factors (horizontal, vertical).
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2014-03-25 Thread Gregor Mi 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/
---

(Updated March 25, 2014, 10:24 p.m.)


Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan Čukić.


Changes
---

updated comments


Repository: kdeplasma-addons


Description
---

Summary
---
Add two options:
  1. Show confirmation before sending (to prevent accidental sending of maybe 
sensible data)
  2. Appearance: Restrict width on large host panel (to prevent huge icon on 
large panels)

How does this change manifest on screen?

Settings dialog:
  - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
  - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png

Behaviour:
  1. "Show confirmation before sending" turned on and after dropping an image: 
http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
  2. "Appearance: Restrict width on large host panel"
 - turned off (default): 
http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to 
other icons in system tray)
 - turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png 
(the width is restricted so it does not eat up horizontal space)

Open issues
---
- Is there a default "review board TARGET_GROUP" for kdeplasma-addons 
review-request?

@apol: I saw that in the frameworks branch you replaced pastebin with 
quickshare. I haven't had the chance to test it out. Does it already have the 
same features as pastebin?


Diffs
-

  applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
  .gitignore PRE-CREATION 
  .reviewboardrc PRE-CREATION 
  applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e 
  applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 

Diff: https://git.reviewboard.kde.org/r/117041/diff/


Testing
---

See screenshots in description. Test if settings are getting stored. Test with 
different form factors (horizontal, vertical).


Thanks,

Gregor Mi

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel