Re: Review Request 117615: Implementation of Search in Local Browsing in Plasma Media Center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117615/ --- (Updated Sept. 22, 2016, 8:39 p.m.) Status -- This change has been discarded. Review request for Plasma, Akshay Ratan, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- I have implemented the local browsing search only to the Videos section as of now, but the application crashes, and it searches on the drive selection window, but doesn't search on the folder and file selection window after that. Please look into it and suggest where I am going wrong. Once this is done, it's the same implementation for images and songs. I would do that similarly. Diffs - browsingbackends/localfiles/localfilesabstractbackend.h 2d47eba browsingbackends/localfiles/localfilesabstractbackend.cpp b86a28a browsingbackends/localfiles/localvideos/localvideosbackend.h ce92a9e browsingbackends/localfiles/localvideos/localvideosbackend.cpp 8c20f27 Diff: https://git.reviewboard.kde.org/r/117615/diff/ Testing --- Errors yet there so testing on hold. Thanks, Harshit Agarwal
Re: Review Request 117615: Implementation of Search in Local Browsing in Plasma Media Center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117615/#review99465 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On April 17, 2014, 5:52 p.m., Harshit Agarwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117615/ > --- > > (Updated April 17, 2014, 5:52 p.m.) > > > Review request for Plasma, Akshay Ratan, Shantanu Tushar, and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > I have implemented the local browsing search only to the Videos section as of > now, but the application crashes, and it searches on the drive selection > window, but doesn't search on the folder and file selection window after > that. Please look into it and suggest where I am going wrong. > > Once this is done, it's the same implementation for images and songs. I would > do that similarly. > > > Diffs > - > > browsingbackends/localfiles/localfilesabstractbackend.h 2d47eba > browsingbackends/localfiles/localfilesabstractbackend.cpp b86a28a > browsingbackends/localfiles/localvideos/localvideosbackend.h ce92a9e > browsingbackends/localfiles/localvideos/localvideosbackend.cpp 8c20f27 > > Diff: https://git.reviewboard.kde.org/r/117615/diff/ > > > Testing > --- > > Errors yet there so testing on hold. > > > Thanks, > > Harshit Agarwal > >
Review Request 117615: Implementation of Search in Local Browsing in Plasma Media Center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117615/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- I have implemented the local browsing search only to the Videos section as of now, but the application crashes, and it searches on the drive selection window, but doesn't search on the folder and file selection window after that. Please look into it and suggest where I am going wrong. Once this is done, it's the same implementation for images and songs. I would do that similarly. Diffs - browsingbackends/localfiles/localfilesabstractbackend.h 2d47eba browsingbackends/localfiles/localfilesabstractbackend.cpp b86a28a browsingbackends/localfiles/localvideos/localvideosbackend.h ce92a9e browsingbackends/localfiles/localvideos/localvideosbackend.cpp 8c20f27 Diff: https://git.reviewboard.kde.org/r/117615/diff/ Testing --- Errors yet there so testing on hold. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
