Re: Review Request 117839: [kglobalaccel] Update X11 appTime from key press events
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117839/#review57298 --- maybe add kdeframeworks group? - Marco Martin On April 28, 2014, 1:47 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117839/ --- (Updated April 28, 2014, 1:47 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [kglobalaccel] Update X11 appTime from key press events KGlobalAccelD sends the current appTime through DBus to the application and KF5::GlobalAccel updates the appTime from the timestamp. This is needed for following actions to succeed. E.g. KWin needs the updated appTime for grabbing the keyboard following the kill window shortcut. To get the current timestamp we just use the timestamp of the key press event delivered to kglobalacceld. Diffs - kglobalaccel/kglobalaccel_x11.cpp 454c62e17ac0fb188bbbf2bcefcf42241d7f4ec1 Diff: https://git.reviewboard.kde.org/r/117839/diff/ Testing --- Tested with ctrl+alt+esc Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117839: [kglobalaccel] Update X11 appTime from key press events
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117839/#review57299 --- Ship it! Code looks good. - Àlex Fiestas On April 28, 2014, 1:47 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117839/ --- (Updated April 28, 2014, 1:47 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [kglobalaccel] Update X11 appTime from key press events KGlobalAccelD sends the current appTime through DBus to the application and KF5::GlobalAccel updates the appTime from the timestamp. This is needed for following actions to succeed. E.g. KWin needs the updated appTime for grabbing the keyboard following the kill window shortcut. To get the current timestamp we just use the timestamp of the key press event delivered to kglobalacceld. Diffs - kglobalaccel/kglobalaccel_x11.cpp 454c62e17ac0fb188bbbf2bcefcf42241d7f4ec1 Diff: https://git.reviewboard.kde.org/r/117839/diff/ Testing --- Tested with ctrl+alt+esc Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117839: [kglobalaccel] Update X11 appTime from key press events
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117839/#review57310 --- This review has been submitted with commit 54287c8e37679d21a4b1ac34f51e0f9627f9834f by Martin Gräßlin to branch master. - Commit Hook On April 28, 2014, 1:47 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117839/ --- (Updated April 28, 2014, 1:47 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [kglobalaccel] Update X11 appTime from key press events KGlobalAccelD sends the current appTime through DBus to the application and KF5::GlobalAccel updates the appTime from the timestamp. This is needed for following actions to succeed. E.g. KWin needs the updated appTime for grabbing the keyboard following the kill window shortcut. To get the current timestamp we just use the timestamp of the key press event delivered to kglobalacceld. Diffs - kglobalaccel/kglobalaccel_x11.cpp 454c62e17ac0fb188bbbf2bcefcf42241d7f4ec1 Diff: https://git.reviewboard.kde.org/r/117839/diff/ Testing --- Tested with ctrl+alt+esc Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117839: [kglobalaccel] Update X11 appTime from key press events
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117839/ --- Review request for Plasma. Repository: plasma-workspace Description --- [kglobalaccel] Update X11 appTime from key press events KGlobalAccelD sends the current appTime through DBus to the application and KF5::GlobalAccel updates the appTime from the timestamp. This is needed for following actions to succeed. E.g. KWin needs the updated appTime for grabbing the keyboard following the kill window shortcut. To get the current timestamp we just use the timestamp of the key press event delivered to kglobalacceld. Diffs - kglobalaccel/kglobalaccel_x11.cpp 454c62e17ac0fb188bbbf2bcefcf42241d7f4ec1 Diff: https://git.reviewboard.kde.org/r/117839/diff/ Testing --- Tested with ctrl+alt+esc Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
