Re: Review Request 117894: Add a kscreenlocker_test test application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117894/ --- (Updated May 5, 2014, 1:19 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, David Edmundson and Wolfgang Bauer. Repository: plasma-workspace Description --- Add a kscreenlocker_test test application The idea is to have a small test application for the screenlocker part to test without having to restart ksmserver. Diffs - ksmserver/screenlocker/CMakeLists.txt 700cdff95f46125952ab2503bb125c5b6cd3ce67 ksmserver/screenlocker/tests/CMakeLists.txt PRE-CREATION ksmserver/screenlocker/tests/kscreenlocker_main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117894/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117894: Add a kscreenlocker_test test application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117894/#review57312 --- This review has been submitted with commit b762c3732bccc265fe24c57f6bda41b237324635 by Martin Gräßlin to branch master. - Commit Hook On April 30, 2014, 9:44 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117894/ > --- > > (Updated April 30, 2014, 9:44 a.m.) > > > Review request for Plasma, David Edmundson and Wolfgang Bauer. > > > Repository: plasma-workspace > > > Description > --- > > Add a kscreenlocker_test test application > > The idea is to have a small test application for the screenlocker part > to test without having to restart ksmserver. > > > Diffs > - > > ksmserver/screenlocker/CMakeLists.txt > 700cdff95f46125952ab2503bb125c5b6cd3ce67 > ksmserver/screenlocker/tests/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/tests/kscreenlocker_main.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117894/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117894: Add a kscreenlocker_test test application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117894/#review57311 --- Ship it! Ship It! - David Edmundson On April 30, 2014, 9:44 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117894/ > --- > > (Updated April 30, 2014, 9:44 a.m.) > > > Review request for Plasma, David Edmundson and Wolfgang Bauer. > > > Repository: plasma-workspace > > > Description > --- > > Add a kscreenlocker_test test application > > The idea is to have a small test application for the screenlocker part > to test without having to restart ksmserver. > > > Diffs > - > > ksmserver/screenlocker/CMakeLists.txt > 700cdff95f46125952ab2503bb125c5b6cd3ce67 > ksmserver/screenlocker/tests/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/tests/kscreenlocker_main.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117894/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117894: Add a kscreenlocker_test test application
> On May 1, 2014, 7 p.m., David Edmundson wrote: > > The greeter is invokable on it's own anyway, what benefit does this have? I think you misunderstood: it's not to run the greeter but the server part in ksmserver which holds the X11 lock. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117894/#review57069 --- On April 30, 2014, 11:44 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117894/ > --- > > (Updated April 30, 2014, 11:44 a.m.) > > > Review request for Plasma, David Edmundson and Wolfgang Bauer. > > > Repository: plasma-workspace > > > Description > --- > > Add a kscreenlocker_test test application > > The idea is to have a small test application for the screenlocker part > to test without having to restart ksmserver. > > > Diffs > - > > ksmserver/screenlocker/CMakeLists.txt > 700cdff95f46125952ab2503bb125c5b6cd3ce67 > ksmserver/screenlocker/tests/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/tests/kscreenlocker_main.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117894/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117894: Add a kscreenlocker_test test application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117894/#review57069 --- The greeter is invokable on it's own anyway, what benefit does this have? - David Edmundson On April 30, 2014, 9:44 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117894/ > --- > > (Updated April 30, 2014, 9:44 a.m.) > > > Review request for Plasma, David Edmundson and Wolfgang Bauer. > > > Repository: plasma-workspace > > > Description > --- > > Add a kscreenlocker_test test application > > The idea is to have a small test application for the screenlocker part > to test without having to restart ksmserver. > > > Diffs > - > > ksmserver/screenlocker/CMakeLists.txt > 700cdff95f46125952ab2503bb125c5b6cd3ce67 > ksmserver/screenlocker/tests/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/tests/kscreenlocker_main.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117894/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117894: Add a kscreenlocker_test test application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117894/ --- Review request for Plasma, David Edmundson and Wolfgang Bauer. Repository: plasma-workspace Description --- Add a kscreenlocker_test test application The idea is to have a small test application for the screenlocker part to test without having to restart ksmserver. Diffs - ksmserver/screenlocker/CMakeLists.txt 700cdff95f46125952ab2503bb125c5b6cd3ce67 ksmserver/screenlocker/tests/CMakeLists.txt PRE-CREATION ksmserver/screenlocker/tests/kscreenlocker_main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117894/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
