Re: Review Request 117946: Track screen changes in the containment when the containment is inside an applet

2014-05-05 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117946/
---

(Updated May 5, 2014, 9:39 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Track screen changes in the containment when the containment is inside an applet

Make the system tray containment update which screen it is on when the
system tray applet is moved.

This fixes notifications if the panel is moved between screens.


Diffs
-

  src/plasma/private/containment_p.h 24049c7 
  src/plasma/private/containment_p.cpp 9e67382 

Diff: https://git.reviewboard.kde.org/r/117946/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 117946: Track screen changes in the containment when the containment is inside an applet

2014-05-05 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117946/#review57294
---


This review has been submitted with commit 
873106a7ca4ff8f15e823b1019b4f5b66332867a by David Edmundson to branch master.

- Commit Hook


On May 2, 2014, 2:42 p.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117946/
 ---
 
 (Updated May 2, 2014, 2:42 p.m.)
 
 
 Review request for KDE Frameworks and Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 Track screen changes in the containment when the containment is inside an 
 applet
 
 Make the system tray containment update which screen it is on when the
 system tray applet is moved.
 
 This fixes notifications if the panel is moved between screens.
 
 
 Diffs
 -
 
   src/plasma/private/containment_p.h 24049c7 
   src/plasma/private/containment_p.cpp 9e67382 
 
 Diff: https://git.reviewboard.kde.org/r/117946/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 David Edmundson
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 117946: Track screen changes in the containment when the containment is inside an applet

2014-05-02 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117946/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Track screen changes in the containment when the containment is inside an applet

Make the system tray containment update which screen it is on when the
system tray applet is moved.

This fixes notifications if the panel is moved between screens.


Diffs
-

  src/plasma/private/containment_p.h 24049c7 
  src/plasma/private/containment_p.cpp 9e67382 

Diff: https://git.reviewboard.kde.org/r/117946/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 117946: Track screen changes in the containment when the containment is inside an applet

2014-05-02 Thread Martin Klapetek

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117946/#review57143
---

Ship it!


Looks good to me

- Martin Klapetek


On May 2, 2014, 4:42 p.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117946/
 ---
 
 (Updated May 2, 2014, 4:42 p.m.)
 
 
 Review request for KDE Frameworks and Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 Track screen changes in the containment when the containment is inside an 
 applet
 
 Make the system tray containment update which screen it is on when the
 system tray applet is moved.
 
 This fixes notifications if the panel is moved between screens.
 
 
 Diffs
 -
 
   src/plasma/private/containment_p.h 24049c7 
   src/plasma/private/containment_p.cpp 9e67382 
 
 Diff: https://git.reviewboard.kde.org/r/117946/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 David Edmundson
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel