Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58542 --- Could you attach a screenshot of the Compositing KCM with the patch applied so we could see whether all layout glitches have been fixed and add Andrew Lake to the review request? That would be great, thanks! - Thomas Pfeiffer On May 26, 2014, 11:19 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 26, 2014, 11:19 p.m.) Review request for Plasma, Hugo Pereira Da Costa and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:25 a.m.) Review request for Plasma, Hugo Pereira Da Costa and Thomas Pfeiffer. Changes --- Added screenshot (after) For before see https://git.reviewboard.kde.org/r/118273/ Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments (updated) compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58545 --- File Attachment: compositing_kcm - bustle1.png https://git.reviewboard.kde.org//r/118337/#fcomment221 This is still an issue, but one thing at a time. - David Edmundson On May 27, 2014, 9:25 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:25 a.m.) Review request for Plasma, Hugo Pereira Da Costa and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:42 a.m.) Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58565 --- Makes sense, do we know why they used to be -1? - Aleix Pol Gonzalez On May 27, 2014, 9:42 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:42 a.m.) Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
On May 27, 2014, 1:11 p.m., Aleix Pol Gonzalez wrote: Makes sense, do we know why they used to be -1? If negative it would go into combinedLayoutSpacing which we don't implement. Which would in turn use the (now deprecated) defaultLayoutSpacing - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58565 --- On May 27, 2014, 9:42 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:42 a.m.) Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58575 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 27, 2014, 9:42 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:42 a.m.) Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58586 --- Ship it! Ship It! - Andrew Lake On May 27, 2014, 9:42 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:42 a.m.) Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
On May 27, 2014, 4:12 p.m., Andrew Lake wrote: Ship It! In case anyone is wondering why this arbitrary fellow said Ship It!, I just wanted to provide an explicit thumbs up that this matches the 4px spacing basis grid recommended in the HIG (http://techbase.kde.org/Projects/Usability/HIG/Placement#Space), so yay! We can tackle individual layout designs separately to get the spacing even better. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58586 --- On May 27, 2014, 9:42 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:42 a.m.) Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
On May 27, 2014, 4:12 p.m., Andrew Lake wrote: Ship It! Andrew Lake wrote: In case anyone is wondering why this arbitrary fellow said Ship It!, I just wanted to provide an explicit thumbs up that this matches the 4px spacing basis grid recommended in the HIG (http://techbase.kde.org/Projects/Usability/HIG/Placement#Space), so yay! We can tackle individual layout designs separately to get the spacing even better. I hope no HIG ever suggest a fixed amount of pixels, but an amount relative to the font size. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58586 --- On May 27, 2014, 9:42 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:42 a.m.) Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
On May 27, 2014, 4:12 p.m., Andrew Lake wrote: Ship It! Andrew Lake wrote: In case anyone is wondering why this arbitrary fellow said Ship It!, I just wanted to provide an explicit thumbs up that this matches the 4px spacing basis grid recommended in the HIG (http://techbase.kde.org/Projects/Usability/HIG/Placement#Space), so yay! We can tackle individual layout designs separately to get the spacing even better. Christoph Feck wrote: I hope no HIG ever suggest a fixed amount of pixels, but an amount relative to the font size. Till we get a credible resolution-independent approach to laying out all visual elements, including typeface, pixels is probably the best guidance guidance we can come up with. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58586 --- On May 27, 2014, 9:42 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:42 a.m.) Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 10:38 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58614 --- This review has been submitted with commit bec64684e8d3fb621c3c3bcee3dde512fc828f0f by David Edmundson to branch master. - Commit Hook On May 27, 2014, 9:42 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:42 a.m.) Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:
On May 27, 2014, 4:12 p.m., Andrew Lake wrote: Ship It! Andrew Lake wrote: In case anyone is wondering why this arbitrary fellow said Ship It!, I just wanted to provide an explicit thumbs up that this matches the 4px spacing basis grid recommended in the HIG (http://techbase.kde.org/Projects/Usability/HIG/Placement#Space), so yay! We can tackle individual layout designs separately to get the spacing even better. Christoph Feck wrote: I hope no HIG ever suggest a fixed amount of pixels, but an amount relative to the font size. Andrew Lake wrote: Till we get a credible resolution-independent approach to laying out all visual elements, including typeface, pixels is probably the best guidance guidance we can come up with. With Qt 5.4's new high DPI pixels no longer refers to actual pixels. One writes code as though the screen will be 96dpi, and Qt scales 4px to 4 or 8 or 16 real pixels depending. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58586 --- On May 27, 2014, 10:38 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 10:38 p.m.) Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer. Repository: oxygen Description --- PM_DefaultLayoutSpacing is deprecated and replaced by both PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5. Qt Layouts now query for these, not the default spacing. See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum There are some other deprecated enums, which are mostly not a problem. Diffs - kstyle/oxygenstyle.cpp 8bcb79a Diff: https://git.reviewboard.kde.org/r/118337/diff/ Testing --- Spacing between labels and controls is now restored o/ File Attachments compositing_kcm https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
