Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review59054 --- Ship it! Unless I've missed something, it's all fine from my side now! - Thomas Pfeiffer On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 4:04 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 daemon/actions/powerdevilaction.desktop 5b74fea daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 daemon/backends/upower/backlight_helper_actions.actions 6ffa496 daemon/backends/upower/powerdevilupowerbackend.desktop a963844 daemon/powerdevil.desktop 20d31c9 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 21d0212 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f kcmodule/profiles/profileEditPage.ui dc26579 powerdevil.notifyrc 36acdb6 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review59097 --- This review has been submitted with commit b0d8acab64a8264a36e509212f458e5ba3f3d057 by Sebastian Kügler to branch master. - Commit Hook On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 4:04 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 daemon/actions/powerdevilaction.desktop 5b74fea daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 daemon/backends/upower/backlight_helper_actions.actions 6ffa496 daemon/backends/upower/powerdevilupowerbackend.desktop a963844 daemon/powerdevil.desktop 20d31c9 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 21d0212 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f kcmodule/profiles/profileEditPage.ui dc26579 powerdevil.notifyrc 36acdb6 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 3, 2014, 3:32 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 daemon/actions/powerdevilaction.desktop 5b74fea daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 daemon/backends/upower/backlight_helper_actions.actions 6ffa496 daemon/backends/upower/powerdevilupowerbackend.desktop a963844 daemon/powerdevil.desktop 20d31c9 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 21d0212 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f kcmodule/profiles/profileEditPage.ui dc26579 powerdevil.notifyrc 36acdb6 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
On June 2, 2014, 4:26 p.m., Andrew Lake wrote: The group box HIG has been updated after discussion on the HIG mailing list. Using a group box with the 'flat' property set true is now recommended; it provides a consistent way to use spacing to group visual elements without the line-y, boxy noise of a visible frame. If you used group boxes here and followed this new guidance you should get the visual design you're aiming for with more consistent spacing. Hope this helps! Sebastian Kügler wrote: It helps partly, but it still makes aligning the widgets in different groupboxes really hard. I'd really prefer just simple spacing. If we make it hard to align things properly, people just won't. In this specific case in powerdevil, using groupboxes really seems overkill as well, we can do just fine with section titles and a bit of spacing (as can be seen here). Andrew Lake wrote: Honestly, if in any one instance we can achieve the same consistency in spacing without using the groupbox I'm fine with deviating from the guidelines. They are, after all, guidelines. I understand the impact in terms alignment and there are times when we have to trade strict compliance with one guideline to reap the benefits of complying with the another. Sebastian Kügler wrote: Amen to that. :) We don't want to be telling devs to set the groupbox to flat, we want to adjust the style such that groupboxes look flat. Otherwise we'll still get a horribly inconsistent mess. (there's a warning in QGroupBox that setFlat might have no effect depending on the style because even windows does that) Worst case, we put it in the QStyle::polish() method to change flat. It's still better than every dev doing it. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58996 --- On June 3, 2014, 3:32 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 3, 2014, 3:32 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 daemon/actions/powerdevilaction.desktop 5b74fea daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 daemon/backends/upower/backlight_helper_actions.actions 6ffa496 daemon/backends/upower/powerdevilupowerbackend.desktop a963844 daemon/powerdevil.desktop 20d31c9 kcmodule/activities/activitypage.cpp 48e9c6c
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 1:35 p.m.) Review request for Plasma, Solid and KDE Usability. Changes --- Well spot, Thomas. I had forgotten to update the entries in the .desktop files (which end up being used as checkbox labels, so they need to not use title case). Fixed now. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs (updated) - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 daemon/actions/powerdevilaction.desktop 5b74fea daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 daemon/backends/upower/backlight_helper_actions.actions 6ffa496 daemon/backends/upower/powerdevilupowerbackend.desktop a963844 daemon/powerdevil.desktop 20d31c9 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 21d0212 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f kcmodule/profiles/profileEditPage.ui dc26579 powerdevil.notifyrc 36acdb6 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58985 --- Almost there ;) The only title case labels I didn't see fixed in the diffs are those in the Battery Levels group of the Advanced Settings: Low Level, Critical Level, At Critical Level. All others seem fixed now from what I can tell from the diffs. - Thomas Pfeiffer On June 2, 2014, 1:35 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 1:35 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 daemon/actions/powerdevilaction.desktop 5b74fea daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 daemon/backends/upower/backlight_helper_actions.actions 6ffa496 daemon/backends/upower/powerdevilupowerbackend.desktop a963844 daemon/powerdevil.desktop 20d31c9 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 21d0212 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f kcmodule/profiles/profileEditPage.ui dc26579 powerdevil.notifyrc 36acdb6 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 4:04 p.m.) Review request for Plasma, Solid and KDE Usability. Changes --- Fix labels in Advanced tab. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs (updated) - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 daemon/actions/powerdevilaction.desktop 5b74fea daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 daemon/backends/upower/backlight_helper_actions.actions 6ffa496 daemon/backends/upower/powerdevilupowerbackend.desktop a963844 daemon/powerdevil.desktop 20d31c9 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 21d0212 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f kcmodule/profiles/profileEditPage.ui dc26579 powerdevil.notifyrc 36acdb6 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58996 --- The group box HIG has been updated after discussion on the HIG mailing list. Using a group box with the 'flat' property set true is now recommended; it provides a consistent way to use spacing to group visual elements without the line-y, boxy noise of a visible frame. If you used group boxes here and followed this new guidance you should get the visual design you're aiming for with more consistent spacing. Hope this helps! - Andrew Lake On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 4:04 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 daemon/actions/powerdevilaction.desktop 5b74fea daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 daemon/backends/upower/backlight_helper_actions.actions 6ffa496 daemon/backends/upower/powerdevilupowerbackend.desktop a963844 daemon/powerdevil.desktop 20d31c9 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 21d0212 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f kcmodule/profiles/profileEditPage.ui dc26579 powerdevil.notifyrc 36acdb6 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler
Re: Review Request 118390: Powerdevil KCM Updates
On June 2, 2014, 4:26 p.m., Andrew Lake wrote: The group box HIG has been updated after discussion on the HIG mailing list. Using a group box with the 'flat' property set true is now recommended; it provides a consistent way to use spacing to group visual elements without the line-y, boxy noise of a visible frame. If you used group boxes here and followed this new guidance you should get the visual design you're aiming for with more consistent spacing. Hope this helps! It helps partly, but it still makes aligning the widgets in different groupboxes really hard. I'd really prefer just simple spacing. If we make it hard to align things properly, people just won't. In this specific case in powerdevil, using groupboxes really seems overkill as well, we can do just fine with section titles and a bit of spacing (as can be seen here). - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58996 --- On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 4:04 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 daemon/actions/powerdevilaction.desktop 5b74fea daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 daemon/backends/upower/backlight_helper_actions.actions 6ffa496 daemon/backends/upower/powerdevilupowerbackend.desktop a963844 daemon/powerdevil.desktop 20d31c9 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 21d0212 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f kcmodule/profiles/profileEditPage.ui dc26579 powerdevil.notifyrc 36acdb6 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after
Re: Review Request 118390: Powerdevil KCM Updates
On June 2, 2014, 4:26 p.m., Andrew Lake wrote: The group box HIG has been updated after discussion on the HIG mailing list. Using a group box with the 'flat' property set true is now recommended; it provides a consistent way to use spacing to group visual elements without the line-y, boxy noise of a visible frame. If you used group boxes here and followed this new guidance you should get the visual design you're aiming for with more consistent spacing. Hope this helps! Sebastian Kügler wrote: It helps partly, but it still makes aligning the widgets in different groupboxes really hard. I'd really prefer just simple spacing. If we make it hard to align things properly, people just won't. In this specific case in powerdevil, using groupboxes really seems overkill as well, we can do just fine with section titles and a bit of spacing (as can be seen here). Honestly, if in any one instance we can achieve the same consistency in spacing without using the groupbox I'm fine with deviating from the guidelines. They are, after all, guidelines. I understand the impact in terms alignment and there are times when we have to trade strict compliance with one guideline to reap the benefits of complying with the another. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58996 --- On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 4:04 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 daemon/actions/powerdevilaction.desktop 5b74fea daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 daemon/backends/upower/backlight_helper_actions.actions 6ffa496 daemon/backends/upower/powerdevilupowerbackend.desktop a963844 daemon/powerdevil.desktop 20d31c9 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 21d0212 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f kcmodule/profiles/profileEditPage.ui dc26579 powerdevil.notifyrc 36acdb6 Diff:
Re: Review Request 118390: Powerdevil KCM Updates
On June 2, 2014, 4:26 p.m., Andrew Lake wrote: The group box HIG has been updated after discussion on the HIG mailing list. Using a group box with the 'flat' property set true is now recommended; it provides a consistent way to use spacing to group visual elements without the line-y, boxy noise of a visible frame. If you used group boxes here and followed this new guidance you should get the visual design you're aiming for with more consistent spacing. Hope this helps! Sebastian Kügler wrote: It helps partly, but it still makes aligning the widgets in different groupboxes really hard. I'd really prefer just simple spacing. If we make it hard to align things properly, people just won't. In this specific case in powerdevil, using groupboxes really seems overkill as well, we can do just fine with section titles and a bit of spacing (as can be seen here). Andrew Lake wrote: Honestly, if in any one instance we can achieve the same consistency in spacing without using the groupbox I'm fine with deviating from the guidelines. They are, after all, guidelines. I understand the impact in terms alignment and there are times when we have to trade strict compliance with one guideline to reap the benefits of complying with the another. Amen to that. :) - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58996 --- On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 4:04 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 daemon/actions/powerdevilaction.desktop 5b74fea daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 daemon/backends/upower/backlight_helper_actions.actions 6ffa496 daemon/backends/upower/powerdevilupowerbackend.desktop a963844 daemon/powerdevil.desktop 20d31c9 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 21d0212 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f kcmodule/profiles/profileEditPage.ui dc26579 powerdevil.notifyrc 36acdb6
Re: Review Request 118390: Powerdevil KCM Updates
Hey, First, thanks all for the reviews. On Thursday, May 29, 2014 16:10:19 Andrew Lake wrote: On May 29, 2014, 8:13 a.m., Thomas Pfeiffer wrote: Good improvements in general! There are two changes which are not HIG-compliant: - Control labels which are written next to the controls (checkboxes, spin boxes etc.) do not use Title Capitalization. See http://techbase.kde.org/Projects/Usability/HIG/Capitalization for details. Therefore most of the capitalization changes have to be reverted, I'm afraid. - For grouping controls (as in the case of Battery Levels and Events) the HIG recommends using group boxes (see http://techbase.kde.org/Projects/Usability/HIG/GroupBox ) instead of simply spacing Apart from those two things, the changes look fine to me! w - For grouping controls (as in the case of Battery Levels and Events) the HIG recommends using group boxes (see http://techbase.kde.org/Projects/Usability/HIG/GroupBox ) instead of simply spacing Hmm, may be time to update that portion of the HIG since, from a visual design standpoint, spacing can be quite effective at grouping visual elements while avoiding more visual chrome. In this case, for the Advanced page, a bit more spacing between the Battery Levels group and the Events group should provide enough visual distinction between the groups. Also, the checkboxes in the Events group can probably be left-aligned under Events since they're unrelated to the widgets from the Battery Levels group and likely better match the alignment guidelines for making the checkboxes span two columns (http://techbase.kde.org/Projects/Usability/HIG/Alignment). Would be nice to have that changed. I'm not a big fan of these groupboxes, for two reasons: - They add visual clutter, and they're often over-used - They break layouts (kind of the purpose), but aligning the widgets in two groupboxes requires internal layout poking, which sucks on the one hand and usually means that the widgets stay unaligned (Aurelien's hack mentioned in the HIG is really that -- a hack and not available for Qt5 yet). In some cases, groupboxes might be warranted, inside FormLayout, they usually do more harm than good, and there's a semantic grouping mechanism already: The titles. I'll not change to groupboxes in this review, but anticipate the HIG catching up. :) Other changes are coming up, of course. Otherwise, the changes look quite nice to me! Thanks! -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
On Friday 30 May 2014 15:34:27 Sebastian Kügler wrote: I'll not change to groupboxes in this review, but anticipate the HIG catching up. :) Yes, that's okay. We'll discuss the grouping HIG on our list. If we come out with a different solution to what you implemented in the end, we'll notify you :) Other changes are coming up, of course. Thanks! The capitalization was more important to me anyway, as we'd really like to get that consistent. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
On May 29, 2014, 9:22 a.m., Kai Uwe Broulik wrote: File Attachment: Energy Saving page after - powerdevil-kcm-profiles-after.png https://git.reviewboard.kde.org/r/118390/#fcomment226 Why remove the icons? They make the individual settings recognizable more quickly. I don't think they do, the icons are so small it's hard to decipher. Also, icons in Checkboxes are very unusual. Removing them improves consistency: Let's face it, the bold text and checkboxes were just a bad idea by some developer thinking these checkboxes are somehow special. (That person was me. ;)) On May 29, 2014, 9:22 a.m., Kai Uwe Broulik wrote: File Attachment: Advanced page after - powerdevil-kcm-advanced-after.png https://git.reviewboard.kde.org/r/118390/#fcomment227 Indeed, GroupBoxes should be used here We'll add spacing as an option in the HIG. Groupbox here means alignment headaches over the whole page. On May 29, 2014, 9:22 a.m., Kai Uwe Broulik wrote: File Attachment: Advanced page after - powerdevil-kcm-advanced-after.png https://git.reviewboard.kde.org/r/118390/#fcomment228 That empty space looks weird Not a big issue, correct alignment is more important than a bit of subjectively weird space. On May 29, 2014, 9:22 a.m., Kai Uwe Broulik wrote: daemon/actions/bundled/dimdisplayconfig.cpp, line 62 https://git.reviewboard.kde.org/r/118390/diff/1/?file=275942#file275942line62 That should be come dpi independent Right now, that's irrelevant, since Oxygen and QWidgets aren't DPI-dependent. In the future, the currently proposed solution will take care of this automatically. IOW, it's not an issue right now, likely won't be in the future, it's also not a regression. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58693 --- On May 28, 2014, 11:33 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 28, 2014, 11:33 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - kcmodule/profiles/profileEditPage.ui dc2657943a2bb63f137ad11b77b254b3782f0407 kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908dfea30a4a15ccd8c89d4ceb36256e2185 kcmodule/profiles/EditPage.cpp a674ccbdd76ba682c7b7111f2f9d0b9123ffe8b8 kcmodule/global/powerdevilglobalconfig.desktop 1d4aa2238b2fa02dfa984f9163f133c941ff509e kcmodule/global/generalPage.ui 2ce7cef98e30f872ea9233edc7882deea134fdd3 kcmodule/global/GeneralPage.cpp d025e429df7ca191bf56443b2bd30353a74993a9 kcmodule/common/actioneditwidget.cpp 4c67b4feeb2cff0df2e397f44ffba2926bbb7276 kcmodule/common/actionconfigwidget.cpp 2161c84b68e5fc3b56240a482ed77825ce4a5f03 kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b55ec7f4685adb5d102cb21df81f17cf3e3 kcmodule/activities/activitypage.cpp 48e9c6c75f2ab95ce52c96b586475dbb4d6022fd daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273697f11864716dae0204009d52264be99f daemon/actions/bundled/runscriptconfig.cpp c0d3adb6651320702bb6503e505b6ebdc06d6004 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 31772679560a256dcf9f66aefbb4cf02351bd5d3 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd87c06f5dce6d1ff10697837a60cdcc5f29
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 30, 2014, 2:19 p.m.) Review request for Plasma, Solid and KDE Usability. Changes --- Addressed comments. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs (updated) - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b5 kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 1d4aa22 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908 kcmodule/profiles/profileEditPage.ui dc26579 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58836 --- Looks like there are still quite a few Title Case labels in there. Can you fix them as well? - Thomas Pfeiffer On May 30, 2014, 2:19 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 30, 2014, 2:19 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b5 kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 1d4aa22 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908 kcmodule/profiles/profileEditPage.ui dc26579 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58692 --- Good improvements in general! There are two changes which are not HIG-compliant: - Control labels which are written next to the controls (checkboxes, spin boxes etc.) do not use Title Capitalization. See http://techbase.kde.org/Projects/Usability/HIG/Capitalization for details. Therefore most of the capitalization changes have to be reverted, I'm afraid. - For grouping controls (as in the case of Battery Levels and Events) the HIG recommends using group boxes (see http://techbase.kde.org/Projects/Usability/HIG/GroupBox ) instead of simply spacing Apart from those two things, the changes look fine to me! - Thomas Pfeiffer On May 28, 2014, 11:33 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 28, 2014, 11:33 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - kcmodule/profiles/profileEditPage.ui dc2657943a2bb63f137ad11b77b254b3782f0407 kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908dfea30a4a15ccd8c89d4ceb36256e2185 kcmodule/profiles/EditPage.cpp a674ccbdd76ba682c7b7111f2f9d0b9123ffe8b8 kcmodule/global/powerdevilglobalconfig.desktop 1d4aa2238b2fa02dfa984f9163f133c941ff509e kcmodule/global/generalPage.ui 2ce7cef98e30f872ea9233edc7882deea134fdd3 kcmodule/global/GeneralPage.cpp d025e429df7ca191bf56443b2bd30353a74993a9 kcmodule/common/actioneditwidget.cpp 4c67b4feeb2cff0df2e397f44ffba2926bbb7276 kcmodule/common/actionconfigwidget.cpp 2161c84b68e5fc3b56240a482ed77825ce4a5f03 kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b55ec7f4685adb5d102cb21df81f17cf3e3 kcmodule/activities/activitypage.cpp 48e9c6c75f2ab95ce52c96b586475dbb4d6022fd daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273697f11864716dae0204009d52264be99f daemon/actions/bundled/runscriptconfig.cpp c0d3adb6651320702bb6503e505b6ebdc06d6004 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 31772679560a256dcf9f66aefbb4cf02351bd5d3 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd87c06f5dce6d1ff10697837a60cdcc5f29 daemon/actions/bundled/dimdisplayconfig.cpp f683935994e4a5a08fd7da6ceb95ba7b726ac708 daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3ea7cb44c27496ea81f4fe35a8ccfde3acc Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58693 --- Thanks for looking into this! See my issues below, some of them are if you're already at it things. File Attachment: Energy Saving page after - powerdevil-kcm-profiles-after.png https://git.reviewboard.kde.org//r/118390/#fcomment222 Why remove the icons? They make the individual settings recognizable more quickly. File Attachment: Advanced page after - powerdevil-kcm-advanced-after.png https://git.reviewboard.kde.org//r/118390/#fcomment223 Indeed, GroupBoxes should be used here File Attachment: Advanced page after - powerdevil-kcm-advanced-after.png https://git.reviewboard.kde.org//r/118390/#fcomment224 That empty space looks weird File Attachment: Advanced page after - powerdevil-kcm-advanced-after.png https://git.reviewboard.kde.org//r/118390/#fcomment225 Those should have a colon at the end daemon/actions/bundled/dimdisplayconfig.cpp https://git.reviewboard.kde.org/r/118390/#comment40848 That should be come dpi independent - Kai Uwe Broulik On May 28, 2014, 11:33 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 28, 2014, 11:33 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - kcmodule/profiles/profileEditPage.ui dc2657943a2bb63f137ad11b77b254b3782f0407 kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908dfea30a4a15ccd8c89d4ceb36256e2185 kcmodule/profiles/EditPage.cpp a674ccbdd76ba682c7b7111f2f9d0b9123ffe8b8 kcmodule/global/powerdevilglobalconfig.desktop 1d4aa2238b2fa02dfa984f9163f133c941ff509e kcmodule/global/generalPage.ui 2ce7cef98e30f872ea9233edc7882deea134fdd3 kcmodule/global/GeneralPage.cpp d025e429df7ca191bf56443b2bd30353a74993a9 kcmodule/common/actioneditwidget.cpp 4c67b4feeb2cff0df2e397f44ffba2926bbb7276 kcmodule/common/actionconfigwidget.cpp 2161c84b68e5fc3b56240a482ed77825ce4a5f03 kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b55ec7f4685adb5d102cb21df81f17cf3e3 kcmodule/activities/activitypage.cpp 48e9c6c75f2ab95ce52c96b586475dbb4d6022fd daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273697f11864716dae0204009d52264be99f daemon/actions/bundled/runscriptconfig.cpp c0d3adb6651320702bb6503e505b6ebdc06d6004 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 31772679560a256dcf9f66aefbb4cf02351bd5d3 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd87c06f5dce6d1ff10697837a60cdcc5f29 daemon/actions/bundled/dimdisplayconfig.cpp f683935994e4a5a08fd7da6ceb95ba7b726ac708 daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3ea7cb44c27496ea81f4fe35a8ccfde3acc Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after
Re: Review Request 118390: Powerdevil KCM Updates
On May 29, 2014, 8:13 a.m., Thomas Pfeiffer wrote: Good improvements in general! There are two changes which are not HIG-compliant: - Control labels which are written next to the controls (checkboxes, spin boxes etc.) do not use Title Capitalization. See http://techbase.kde.org/Projects/Usability/HIG/Capitalization for details. Therefore most of the capitalization changes have to be reverted, I'm afraid. - For grouping controls (as in the case of Battery Levels and Events) the HIG recommends using group boxes (see http://techbase.kde.org/Projects/Usability/HIG/GroupBox ) instead of simply spacing Apart from those two things, the changes look fine to me! - For grouping controls (as in the case of Battery Levels and Events) the HIG recommends using group boxes (see http://techbase.kde.org/Projects/Usability/HIG/GroupBox ) instead of simply spacing Hmm, may be time to update that portion of the HIG since, from a visual design standpoint, spacing can be quite effective at grouping visual elements while avoiding more visual chrome. In this case, for the Advanced page, a bit more spacing between the Battery Levels group and the Events group should provide enough visual distinction between the groups. Also, the checkboxes in the Events group can probably be left-aligned under Events since they're unrelated to the widgets from the Battery Levels group and likely better match the alignment guidelines for making the checkboxes span two columns (http://techbase.kde.org/Projects/Usability/HIG/Alignment). Otherwise, the changes look quite nice to me! - Andrew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58692 --- On May 28, 2014, 11:33 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 28, 2014, 11:33 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - kcmodule/profiles/profileEditPage.ui dc2657943a2bb63f137ad11b77b254b3782f0407 kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908dfea30a4a15ccd8c89d4ceb36256e2185 kcmodule/profiles/EditPage.cpp a674ccbdd76ba682c7b7111f2f9d0b9123ffe8b8 kcmodule/global/powerdevilglobalconfig.desktop 1d4aa2238b2fa02dfa984f9163f133c941ff509e kcmodule/global/generalPage.ui 2ce7cef98e30f872ea9233edc7882deea134fdd3 kcmodule/global/GeneralPage.cpp d025e429df7ca191bf56443b2bd30353a74993a9 kcmodule/common/actioneditwidget.cpp 4c67b4feeb2cff0df2e397f44ffba2926bbb7276 kcmodule/common/actionconfigwidget.cpp 2161c84b68e5fc3b56240a482ed77825ce4a5f03 kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b55ec7f4685adb5d102cb21df81f17cf3e3 kcmodule/activities/activitypage.cpp 48e9c6c75f2ab95ce52c96b586475dbb4d6022fd daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273697f11864716dae0204009d52264be99f daemon/actions/bundled/runscriptconfig.cpp c0d3adb6651320702bb6503e505b6ebdc06d6004 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 31772679560a256dcf9f66aefbb4cf02351bd5d3 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd87c06f5dce6d1ff10697837a60cdcc5f29 daemon/actions/bundled/dimdisplayconfig.cpp f683935994e4a5a08fd7da6ceb95ba7b726ac708 daemon/actions/bundled/brightnesscontrolconfig.cpp
Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - kcmodule/profiles/profileEditPage.ui dc2657943a2bb63f137ad11b77b254b3782f0407 kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908dfea30a4a15ccd8c89d4ceb36256e2185 kcmodule/profiles/EditPage.cpp a674ccbdd76ba682c7b7111f2f9d0b9123ffe8b8 kcmodule/global/powerdevilglobalconfig.desktop 1d4aa2238b2fa02dfa984f9163f133c941ff509e kcmodule/global/generalPage.ui 2ce7cef98e30f872ea9233edc7882deea134fdd3 kcmodule/global/GeneralPage.cpp d025e429df7ca191bf56443b2bd30353a74993a9 kcmodule/common/actioneditwidget.cpp 4c67b4feeb2cff0df2e397f44ffba2926bbb7276 kcmodule/common/actionconfigwidget.cpp 2161c84b68e5fc3b56240a482ed77825ce4a5f03 kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b55ec7f4685adb5d102cb21df81f17cf3e3 kcmodule/activities/activitypage.cpp 48e9c6c75f2ab95ce52c96b586475dbb4d6022fd daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273697f11864716dae0204009d52264be99f daemon/actions/bundled/runscriptconfig.cpp c0d3adb6651320702bb6503e505b6ebdc06d6004 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 31772679560a256dcf9f66aefbb4cf02351bd5d3 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd87c06f5dce6d1ff10697837a60cdcc5f29 daemon/actions/bundled/dimdisplayconfig.cpp f683935994e4a5a08fd7da6ceb95ba7b726ac708 daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3ea7cb44c27496ea81f4fe35a8ccfde3acc Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 28, 2014, 11:33 p.m.) Review request for Plasma, Solid and KDE Usability. Changes --- Fixed screenshot. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - kcmodule/profiles/profileEditPage.ui dc2657943a2bb63f137ad11b77b254b3782f0407 kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908dfea30a4a15ccd8c89d4ceb36256e2185 kcmodule/profiles/EditPage.cpp a674ccbdd76ba682c7b7111f2f9d0b9123ffe8b8 kcmodule/global/powerdevilglobalconfig.desktop 1d4aa2238b2fa02dfa984f9163f133c941ff509e kcmodule/global/generalPage.ui 2ce7cef98e30f872ea9233edc7882deea134fdd3 kcmodule/global/GeneralPage.cpp d025e429df7ca191bf56443b2bd30353a74993a9 kcmodule/common/actioneditwidget.cpp 4c67b4feeb2cff0df2e397f44ffba2926bbb7276 kcmodule/common/actionconfigwidget.cpp 2161c84b68e5fc3b56240a482ed77825ce4a5f03 kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b55ec7f4685adb5d102cb21df81f17cf3e3 kcmodule/activities/activitypage.cpp 48e9c6c75f2ab95ce52c96b586475dbb4d6022fd daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273697f11864716dae0204009d52264be99f daemon/actions/bundled/runscriptconfig.cpp c0d3adb6651320702bb6503e505b6ebdc06d6004 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 31772679560a256dcf9f66aefbb4cf02351bd5d3 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd87c06f5dce6d1ff10697837a60cdcc5f29 daemon/actions/bundled/dimdisplayconfig.cpp f683935994e4a5a08fd7da6ceb95ba7b726ac708 daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3ea7cb44c27496ea81f4fe35a8ccfde3acc Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments (updated) Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 28, 2014, 11:32 p.m.) Review request for Plasma, Solid and KDE Usability. Changes --- Screenshots of Energy Saving and Advanced pages, before and after treatment. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - kcmodule/profiles/profileEditPage.ui dc2657943a2bb63f137ad11b77b254b3782f0407 kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908dfea30a4a15ccd8c89d4ceb36256e2185 kcmodule/profiles/EditPage.cpp a674ccbdd76ba682c7b7111f2f9d0b9123ffe8b8 kcmodule/global/powerdevilglobalconfig.desktop 1d4aa2238b2fa02dfa984f9163f133c941ff509e kcmodule/global/generalPage.ui 2ce7cef98e30f872ea9233edc7882deea134fdd3 kcmodule/global/GeneralPage.cpp d025e429df7ca191bf56443b2bd30353a74993a9 kcmodule/common/actioneditwidget.cpp 4c67b4feeb2cff0df2e397f44ffba2926bbb7276 kcmodule/common/actionconfigwidget.cpp 2161c84b68e5fc3b56240a482ed77825ce4a5f03 kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b55ec7f4685adb5d102cb21df81f17cf3e3 kcmodule/activities/activitypage.cpp 48e9c6c75f2ab95ce52c96b586475dbb4d6022fd daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273697f11864716dae0204009d52264be99f daemon/actions/bundled/runscriptconfig.cpp c0d3adb6651320702bb6503e505b6ebdc06d6004 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 31772679560a256dcf9f66aefbb4cf02351bd5d3 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd87c06f5dce6d1ff10697837a60cdcc5f29 daemon/actions/bundled/dimdisplayconfig.cpp f683935994e4a5a08fd7da6ceb95ba7b726ac708 daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3ea7cb44c27496ea81f4fe35a8ccfde3acc Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments (updated) Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/d9075101-6451-424a-89be-1e3ab37a5c46__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
