Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/
---

(Updated June 24, 2014, 12:18 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 335070
https://bugs.kde.org/show_bug.cgi?id=335070


Repository: plasma-desktop


Description
---

Addresses lack of contrast of folderview containment icon text on certain 
backgrounds: Bug 335070

The color of the text background is just the complement of the icon label text 
with a 0.6 opacity applied.


Diffs
-

  containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
  containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 

Diff: https://git.reviewboard.kde.org/r/118891/diff/


Testing
---


File Attachments


with latest changes showing it with selection background
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/58f07e42-08b4-480a-9c05-40195514edbf__icontextbackground2.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60873
---


This review has been submitted with commit 
5819be48aafef3465451a61f87ca01dc6dd93bd3 by Andrew Lake to branch master.

- Commit Hook


On June 23, 2014, 2:19 p.m., Andrew Lake wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> ---
> 
> (Updated June 23, 2014, 2:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
> https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Addresses lack of contrast of folderview containment icon text on certain 
> backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label 
> text with a 0.6 opacity applied.
> 
> 
> Diffs
> -
> 
>   containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> with latest changes showing it with selection background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/58f07e42-08b4-480a-9c05-40195514edbf__icontextbackground2.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Marco Martin 


> On June 23, 2014, 6:09 p.m., Eike Hein wrote:
> > Thanks for addressing those issues. I'd say let's commit it now. I'm still 
> > not sure that it might not be too heavy visually, but to find out we need 
> > broader feedback I think. So let's put it in and monitor responses :).

I think visually is just fine, at least, a solid rectangle to me will always 
feel lighter than any blur/shadow stuff


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60832
---


On June 23, 2014, 2:19 p.m., Andrew Lake wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> ---
> 
> (Updated June 23, 2014, 2:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
> https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Addresses lack of contrast of folderview containment icon text on certain 
> backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label 
> text with a 0.6 opacity applied.
> 
> 
> Diffs
> -
> 
>   containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> with latest changes showing it with selection background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/58f07e42-08b4-480a-9c05-40195514edbf__icontextbackground2.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Eike Hein 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60832
---

Ship it!


Thanks for addressing those issues. I'd say let's commit it now. I'm still not 
sure that it might not be too heavy visually, but to find out we need broader 
feedback I think. So let's put it in and monitor responses :).

- Eike Hein


On June 23, 2014, 2:19 p.m., Andrew Lake wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> ---
> 
> (Updated June 23, 2014, 2:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
> https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Addresses lack of contrast of folderview containment icon text on certain 
> backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label 
> text with a 0.6 opacity applied.
> 
> 
> Diffs
> -
> 
>   containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> with latest changes showing it with selection background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/58f07e42-08b4-480a-9c05-40195514edbf__icontextbackground2.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/
---

(Updated June 23, 2014, 2:19 p.m.)


Review request for Plasma.


Changes
---

Use units.smallspacing for text background margins. Don't show text background 
on popups or widget view. Also decreased opacity to 0.4 to reduce "heavy" feel. 
 See attached screen capture.


Bugs: 335070
https://bugs.kde.org/show_bug.cgi?id=335070


Repository: plasma-desktop


Description
---

Addresses lack of contrast of folderview containment icon text on certain 
backgrounds: Bug 335070

The color of the text background is just the complement of the icon label text 
with a 0.6 opacity applied.


Diffs (updated)
-

  containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
  containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 

Diff: https://git.reviewboard.kde.org/r/118891/diff/


Testing
---


File Attachments (updated)


with latest changes showing it with selection background
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/58f07e42-08b4-480a-9c05-40195514edbf__icontextbackground2.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Sebastian Kügler 


> On June 23, 2014, 9 a.m., Eike Hein wrote:
> > containments/folder/package/contents/ui/ItemDelegate.qml, line 121
> > 
> >
> > Are you sure you wanted to hard-code pixel values here instead of using 
> > hidpi scaling-aware margins? units.smallSpacing is effectively 2px right 
> > now at 'standard DPI'.

Yes, units.smallSpacing is the API to use here. I've recently changed it (last 
week), to be a bit bigger on higher DPI screens, so perhaps that helps?


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60755
---


On June 23, 2014, 12:41 a.m., Andrew Lake wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> ---
> 
> (Updated June 23, 2014, 12:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
> https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Addresses lack of contrast of folderview containment icon text on certain 
> backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label 
> text with a 0.6 opacity applied.
> 
> 
> Diffs
> -
> 
>   containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Icon text background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Sebastian Kügler 


> On June 22, 2014, 11:29 p.m., Mark Gaiser wrote:
> > Not a +1 or -1. Just my preference for this.
> > - No background (aka, fully transparent) when nothing is selected.
> > - Selected items should show the background as in your screenshot.
> > 
> > Just my preference though :)
> 
> Andrew Lake wrote:
> This change is for readability when nothing is selected. The normal icon 
> selection background is unaffected.
> 
> Mark Gaiser wrote:
> I know, that's why i said:
> "- No background (aka, fully transparent) when nothing is selected."
> 
> as my own preference. + it is consistent between other apps like dolphin 
> which also doesn't have a default background color for deselected items.
> 
> Eike Hein wrote:
> What Andrew was trying to say is that this change is specifically 
> designed to add a background that is guaranteed to contrast with the text, 
> behind the text. Not showing it when the item is not selected breaks this 
> guarantee and makes the change pointless.
> 
> Cf. https://bugs.kde.org/show_bug.cgi?id=335070 for an extended 
> discussion of this.

Dolphin has a fixed color background, folderview on the desktop wallpaper 
doesn't. Therefore, you can't compare it to Dolphin. The patch is not about 
personal preference, but about a contrast problem. Please refer to the 
bugreport when judging whether or not a patch is useful, "I like it" doesn't 
really add a lot.

IMO, this changes looks "reasonably nice", it's technically correct color use. 
I'll let Eike handle / decide further.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60739
---


On June 23, 2014, 12:41 a.m., Andrew Lake wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> ---
> 
> (Updated June 23, 2014, 12:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
> https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Addresses lack of contrast of folderview containment icon text on certain 
> backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label 
> text with a 0.6 opacity applied.
> 
> 
> Diffs
> -
> 
>   containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Icon text background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Eike Hein 


> On June 22, 2014, 11:29 p.m., Mark Gaiser wrote:
> > Not a +1 or -1. Just my preference for this.
> > - No background (aka, fully transparent) when nothing is selected.
> > - Selected items should show the background as in your screenshot.
> > 
> > Just my preference though :)
> 
> Andrew Lake wrote:
> This change is for readability when nothing is selected. The normal icon 
> selection background is unaffected.
> 
> Mark Gaiser wrote:
> I know, that's why i said:
> "- No background (aka, fully transparent) when nothing is selected."
> 
> as my own preference. + it is consistent between other apps like dolphin 
> which also doesn't have a default background color for deselected items.

What Andrew was trying to say is that this change is specifically designed to 
add a background that is guaranteed to contrast with the text, behind the text. 
Not showing it when the item is not selected breaks this guarantee and makes 
the change pointless.

Cf. https://bugs.kde.org/show_bug.cgi?id=335070 for an extended discussion of 
this.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60739
---


On June 23, 2014, 12:41 a.m., Andrew Lake wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> ---
> 
> (Updated June 23, 2014, 12:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
> https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Addresses lack of contrast of folderview containment icon text on certain 
> backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label 
> text with a 0.6 opacity applied.
> 
> 
> Diffs
> -
> 
>   containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Icon text background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Mark Gaiser 


> On June 22, 2014, 11:29 p.m., Mark Gaiser wrote:
> > Not a +1 or -1. Just my preference for this.
> > - No background (aka, fully transparent) when nothing is selected.
> > - Selected items should show the background as in your screenshot.
> > 
> > Just my preference though :)
> 
> Andrew Lake wrote:
> This change is for readability when nothing is selected. The normal icon 
> selection background is unaffected.

I know, that's why i said:
"- No background (aka, fully transparent) when nothing is selected."

as my own preference. + it is consistent between other apps like dolphin which 
also doesn't have a default background color for deselected items.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60739
---


On June 23, 2014, 12:41 a.m., Andrew Lake wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> ---
> 
> (Updated June 23, 2014, 12:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
> https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Addresses lack of contrast of folderview containment icon text on certain 
> backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label 
> text with a 0.6 opacity applied.
> 
> 
> Diffs
> -
> 
>   containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Icon text background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Eike Hein 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60755
---


I'm basically willing to follow the VDG's lead here in the end, although I 
think this approach has some problems:

- It's a fairly heavy deco for the containment case, which does make it feel a 
lot like a selection deco. This is reinforced by the fact that other file item 
delegates in the system (Dolphin, KFileDialog) behave similarly on selection.

- I can't quite make my mind up on whether it's a good thing or a bad thing 
that the deco on narrow single-line text items extends over the entire line 
width instead of bounding to the text. It's different from Dolphin/KFileDialog 
behavior, though.


containments/folder/package/contents/ui/ItemDelegate.qml


Are you sure you wanted to hard-code pixel values here instead of using 
hidpi scaling-aware margins? units.smallSpacing is effectively 2px right now at 
'standard DPI'.



containments/folder/package/contents/ui/ItemDelegate.qml


This causes a subtle brightly-colored rectangle in popups from the 
containment Folder View and in the widget case which I think looks fairly 
awkward to me. The dialog and widget backgrounds are designed to host 
theme.textColor already contrast-wise, so I think it'd be better to just not 
show this rectangle there.


- Eike Hein


On June 23, 2014, 12:41 a.m., Andrew Lake wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> ---
> 
> (Updated June 23, 2014, 12:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
> https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Addresses lack of contrast of folderview containment icon text on certain 
> backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label 
> text with a 0.6 opacity applied.
> 
> 
> Diffs
> -
> 
>   containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Icon text background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-22 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/
---

(Updated June 23, 2014, 12:41 a.m.)


Review request for Plasma.


Changes
---

Updated to remove configuration of the icon text color and use theme colors 
when folderview is the desktop background.


Bugs: 335070
https://bugs.kde.org/show_bug.cgi?id=335070


Repository: plasma-desktop


Description
---

Addresses lack of contrast of folderview containment icon text on certain 
backgrounds: Bug 335070

The color of the text background is just the complement of the icon label text 
with a 0.6 opacity applied.


Diffs (updated)
-

  containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
  containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 

Diff: https://git.reviewboard.kde.org/r/118891/diff/


Testing
---


File Attachments (updated)


Icon text background
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-22 Thread Andrew Lake 


> On June 22, 2014, 11:29 p.m., Mark Gaiser wrote:
> > Not a +1 or -1. Just my preference for this.
> > - No background (aka, fully transparent) when nothing is selected.
> > - Selected items should show the background as in your screenshot.
> > 
> > Just my preference though :)

This change is for readability when nothing is selected. The normal icon 
selection background is unaffected.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60739
---


On June 22, 2014, 11:09 p.m., Andrew Lake wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> ---
> 
> (Updated June 22, 2014, 11:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
> https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Addresses lack of contrast of folderview containment icon text on certain 
> backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label 
> text with a 0.6 opacity applied.
> 
> 
> Diffs
> -
> 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> After: Folderview as desktop
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/488f6ed9-462f-4ff4-b50c-c951c5a0de66__icontextbackground.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

2014-06-22 Thread Mark Gaiser 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60739
---


Not a +1 or -1. Just my preference for this.
- No background (aka, fully transparent) when nothing is selected.
- Selected items should show the background as in your screenshot.

Just my preference though :)

- Mark Gaiser


On June 22, 2014, 11:09 p.m., Andrew Lake wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> ---
> 
> (Updated June 22, 2014, 11:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
> https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Addresses lack of contrast of folderview containment icon text on certain 
> backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label 
> text with a 0.6 opacity applied.
> 
> 
> Diffs
> -
> 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> After: Folderview as desktop
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/488f6ed9-462f-4ff4-b50c-c951c5a0de66__icontextbackground.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118891: Folder view icon text background

2014-06-22 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/
---

Review request for Plasma.


Bugs: 335070
https://bugs.kde.org/show_bug.cgi?id=335070


Repository: plasma-desktop


Description
---

Addresses lack of contrast of folderview containment icon text on certain 
backgrounds: Bug 335070

The color of the text background is just the complement of the icon label text 
with a 0.6 opacity applied.


Diffs
-

  containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 

Diff: https://git.reviewboard.kde.org/r/118891/diff/


Testing
---


File Attachments


After: Folderview as desktop
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/488f6ed9-462f-4ff4-b50c-c951c5a0de66__icontextbackground.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel