Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread Marco Martin 


> On July 28, 2014, 4:40 p.m., David Edmundson wrote:
> > >The ugly thing here is that QtControls ToolButton doesn't have a flat 
> > >property, it should probably be upstreamed, at least for compatibility 
> > >with the qwidgets ToolButton
> > 
> > I can't see a flat property on the widget's toolbutton. 
> > http://qt-project.org/doc/qt-5/qtoolbutton.html, which property are you 
> > thinking of?

right.
it's called autoRaise there, and it's the negation of flat


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/#review63340
---


On July 28, 2014, 3:50 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119464/
> ---
> 
> (Updated July 28, 2014, 3:50 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports ToolButton.
> It's a different style than Button since it's way more complicated.
> 
> The ugly thing here is that QtControls ToolButton doesn't have a flat 
> property, it should probably be upstreamed, at least for compatibility with 
> the qwidgets ToolButton
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml 
> 20caef6 
>   src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b 
>   src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml 
> PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 
> 
> Diff: https://git.reviewboard.kde.org/r/119464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/#review63340
---


>The ugly thing here is that QtControls ToolButton doesn't have a flat 
>property, it should probably be upstreamed, at least for compatibility with 
>the qwidgets ToolButton

I can't see a flat property on the widget's toolbutton. 
http://qt-project.org/doc/qt-5/qtoolbutton.html, which property are you 
thinking of?

- David Edmundson


On July 28, 2014, 3:50 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119464/
> ---
> 
> (Updated July 28, 2014, 3:50 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports ToolButton.
> It's a different style than Button since it's way more complicated.
> 
> The ugly thing here is that QtControls ToolButton doesn't have a flat 
> property, it should probably be upstreamed, at least for compatibility with 
> the qwidgets ToolButton
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml 
> 20caef6 
>   src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b 
>   src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml 
> PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 
> 
> Diff: https://git.reviewboard.kde.org/r/119464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/
---

(Updated July 28, 2014, 3:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports ToolButton.
It's a different style than Button since it's way more complicated.

The ugly thing here is that QtControls ToolButton doesn't have a flat property, 
it should probably be upstreamed, at least for compatibility with the qwidgets 
ToolButton


Diffs
-

  src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml 20caef6 
  src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b 
  src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml 
PRE-CREATION 
  src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 

Diff: https://git.reviewboard.kde.org/r/119464/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/#review63337
---

Ship it!


Ship It!

- David Edmundson


On July 25, 2014, 4:52 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119464/
> ---
> 
> (Updated July 25, 2014, 4:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports ToolButton.
> It's a different style than Button since it's way more complicated.
> 
> The ugly thing here is that QtControls ToolButton doesn't have a flat 
> property, it should probably be upstreamed, at least for compatibility with 
> the qwidgets ToolButton
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml 
> 20caef6 
>   src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b 
>   src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml 
> PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 
> 
> Diff: https://git.reviewboard.kde.org/r/119464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/
---

(Updated July 25, 2014, 4:52 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports ToolButton.
It's a different style than Button since it's way more complicated.

The ugly thing here is that QtControls ToolButton doesn't have a flat property, 
it should probably be upstreamed, at least for compatibility with the qwidgets 
ToolButton


Diffs (updated)
-

  src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml 20caef6 
  src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b 
  src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml 
PRE-CREATION 
  src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 

Diff: https://git.reviewboard.kde.org/r/119464/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Marco Martin 


> On July 25, 2014, 3:57 p.m., Andrew Lake wrote:
> > src/declarativeimports/plasmacomponents/qml/ToolButton.qml, line 30
> > 
> >
> > Just curious, any reason to not use ToolButton here?
> > 
> > http://qt-project.org/doc/qt-5/qml-qtquick-controls-toolbutton.html

I'm inheriting button so reuses some of he custom stuff, since i seen that 
toolbutton in qtcontrols just inherits hit button..
anyways would be easy enough to inherit instead the qtcontrols toolbutton and 
duplicate the custom stuff needed for compatibility instead


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/#review63169
---


On July 25, 2014, 1:47 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119464/
> ---
> 
> (Updated July 25, 2014, 1:47 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports ToolButton.
> It's a different style than Button since it's way more complicated.
> 
> The ugly thing here is that QtControls ToolButton doesn't have a flat 
> property, it should probably be upstreamed, at least for compatibility with 
> the qwidgets ToolButton
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b 
>   src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 
>   src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml 
> 20caef6 
>   src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/#review63169
---



src/declarativeimports/plasmacomponents/qml/ToolButton.qml


Just curious, any reason to not use ToolButton here?

http://qt-project.org/doc/qt-5/qml-qtquick-controls-toolbutton.html


- Andrew Lake


On July 25, 2014, 1:47 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119464/
> ---
> 
> (Updated July 25, 2014, 1:47 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports ToolButton.
> It's a different style than Button since it's way more complicated.
> 
> The ugly thing here is that QtControls ToolButton doesn't have a flat 
> property, it should probably be upstreamed, at least for compatibility with 
> the qwidgets ToolButton
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b 
>   src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 
>   src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml 
> 20caef6 
>   src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports ToolButton.
It's a different style than Button since it's way more complicated.

The ugly thing here is that QtControls ToolButton doesn't have a flat property, 
it should probably be upstreamed, at least for compatibility with the qwidgets 
ToolButton


Diffs
-

  src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b 
  src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 
  src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml 20caef6 
  src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml 
PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119464/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel