Re: Review Request 119513: reintroduce containmentForScreen(int screen, const QString &defaultPluginIfNonExistent, args)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119513/ --- (Updated July 28, 2014, 11:46 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- reintroduces an api call from plasma1: its the only way to solve https://bugs.kde.org/show_bug.cgi?id=337200 basically to avoid a crash when plasma starts with missing containments in the appletsrc and a locked corona, or a screen added with locked widgets. it's the only entry point that allows a creation of a containment when widgets are locked Diffs - src/plasma/corona.h f60fd74 src/plasma/corona.cpp c6bd949 Diff: https://git.reviewboard.kde.org/r/119513/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119513: reintroduce containmentForScreen(int screen, const QString &defaultPluginIfNonExistent, args)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119513/#review63318 --- Ship it! Ship It! - Sebastian Kügler On July 28, 2014, 11:13 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119513/ > --- > > (Updated July 28, 2014, 11:13 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > reintroduces an api call from plasma1: > its the only way to solve > https://bugs.kde.org/show_bug.cgi?id=337200 > basically to avoid a crash when plasma starts with missing containments in > the appletsrc and a locked corona, or a screen added with locked widgets. > > it's the only entry point that allows a creation of a containment when > widgets are locked > > > Diffs > - > > src/plasma/corona.h f60fd74 > src/plasma/corona.cpp c6bd949 > > Diff: https://git.reviewboard.kde.org/r/119513/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119513: reintroduce containmentForScreen(int screen, const QString &defaultPluginIfNonExistent, args)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119513/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- reintroduces an api call from plasma1: its the only way to solve https://bugs.kde.org/show_bug.cgi?id=337200 basically to avoid a crash when plasma starts with missing containments in the appletsrc and a locked corona, or a screen added with locked widgets. it's the only entry point that allows a creation of a containment when widgets are locked Diffs - src/plasma/corona.h f60fd74 src/plasma/corona.cpp c6bd949 Diff: https://git.reviewboard.kde.org/r/119513/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
