Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-08-17 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/
---

Review request for Plasma and Àlex Fiestas.


Repository: plasma-workspace


Description
---

[ksld] ScreenLocker inhibits sleep on logind

When the system is going to sleep we want to ensure that the screen gets
locked before the system goes to sleep. Logind provides the inhibitor
locks which can be used for this.

If logind is available ksld gains an inhibitor lock for sleep when the
screen is unlocked. As soon as the screen gets locked the inhibitor lock
is released. In addition it connects to the prepareForSleep signal by
logind and locks the screen.

The solution needs to be extended to have a config option whether the
screen should be locked on sleep. Currently this is provided by
powerdevil. Also the solution can only work properly if power devil uses
logind's sleep dbus interface.

[ksld] Don't block till the greeter is started

We only want to ensure that the greeter gets started. There is no
need to block for that. Instead we can connect to the error signal
and unlock in case the greeter failed to start.


-
@Alex: what do you think is the best solution for handling the "lock screen on 
resume" config option? My idea would be to move it to screen locker and expose 
the value through DBus, so that powerdevil can still read it.


Diffs
-

  ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
  ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
  ksmserver/screenlocker/CMakeLists.txt 
5378a10df2be70cee95b5612c23046eae639f610 
  ksmserver/screenlocker/autotests/CMakeLists.txt 
4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
  ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
  ksmserver/screenlocker/ksldapp.cpp 04c7db366722f61dd87407d557ccf7d04ce83bcc 

Diff: https://git.reviewboard.kde.org/r/119814/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-08-17 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review64680
---


"what do you think is the best solution for handling the "lock screen on 
resume" config option?"

++1 That thing really ought to be in the Screen Locker config

- Kai Uwe Broulik


On Aug. 17, 2014, 3:10 nachm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Aug. 17, 2014, 3:10 nachm.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 04c7db366722f61dd87407d557ccf7d04ce83bcc 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-08-21 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review64981
---



ksmserver/screenlocker/ksldapp.cpp


this is adding monitoring logind telling us we're going to sleep, but it 
worked before, so this must mean now we're going to be trying to lock from two 
places?



ksmserver/screenlocker/ksldapp.cpp


this seems rather major.



ksmserver/screenlocker/ksldapp.cpp


this needs the config check.



ksmserver/screenlocker/ksldapp.cpp


and this needs the config check too.


- David Edmundson


On Aug. 17, 2014, 3:10 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Aug. 17, 2014, 3:10 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 04c7db366722f61dd87407d557ccf7d04ce83bcc 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-08-21 Thread Martin Gräßlin 


> On Aug. 21, 2014, 3:57 p.m., David Edmundson wrote:
> > ksmserver/screenlocker/ksldapp.cpp, line 213
> > 
> >
> > this is adding monitoring logind telling us we're going to sleep, but 
> > it worked before, so this must mean now we're going to be trying to lock 
> > from two places?

> but it worked before

That is true and not true at the same time. Ksld never noticed whether the 
system goes to sleep. Try it yourself:
systemctl suspend

and it doesn't lock.

But if one suspend through powerdevil (which is broken on my system and the 
reason for this change) it calls the DBus interface of ksld to lock. But this 
brings the disadvantage that it's not properly controlled - powerdevil can 
never know when the lock is in place and as far as I read the code it just 
starts it. That's why my commit message states that it needs adjustements in 
powerdevil to prefer suspending through logind if available.


> On Aug. 21, 2014, 3:57 p.m., David Edmundson wrote:
> > ksmserver/screenlocker/ksldapp.cpp, line 219
> > 
> >
> > this seems rather major.

see my initial comment: I'm requesting feedack on where to put the config 
option.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review64981
---


On Aug. 17, 2014, 5:10 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Aug. 17, 2014, 5:10 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 04c7db366722f61dd87407d557ccf7d04ce83bcc 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-12-14 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review72002
---


Ping?

PowerDevil already uses the Logind1 interfaces for suspending in case it finds 
a systemd version >= 195

- Kai Uwe Broulik


On Aug. 17, 2014, 3:10 nachm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Aug. 17, 2014, 3:10 nachm.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 04c7db366722f61dd87407d557ccf7d04ce83bcc 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-12-15 Thread Martin Gräßlin 


> On Dec. 14, 2014, 8:57 p.m., Kai Uwe Broulik wrote:
> > Ping?
> > 
> > PowerDevil already uses the Logind1 interfaces for suspending in case it 
> > finds a systemd version >= 195

Thanks for that info. This removes a road blocker. So all that's left is moving 
the config option to screen locker and remove all that's left in Powerdevil to 
lock the screen.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review72002
---


On Aug. 17, 2014, 5:10 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Aug. 17, 2014, 5:10 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 04c7db366722f61dd87407d557ccf7d04ce83bcc 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-12-15 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/
---

(Updated Dec. 15, 2014, 11:18 a.m.)


Review request for Plasma and Àlex Fiestas.


Changes
---

* rebased on current master
* added config option for "lock screen on resume"


Repository: plasma-workspace


Description
---

[ksld] ScreenLocker inhibits sleep on logind

When the system is going to sleep we want to ensure that the screen gets
locked before the system goes to sleep. Logind provides the inhibitor
locks which can be used for this.

If logind is available ksld gains an inhibitor lock for sleep when the
screen is unlocked. As soon as the screen gets locked the inhibitor lock
is released. In addition it connects to the prepareForSleep signal by
logind and locks the screen.

The solution needs to be extended to have a config option whether the
screen should be locked on sleep. Currently this is provided by
powerdevil. Also the solution can only work properly if power devil uses
logind's sleep dbus interface.

[ksld] Don't block till the greeter is started

We only want to ensure that the greeter gets started. There is no
need to block for that. Instead we can connect to the error signal
and unlock in case the greeter failed to start.


-
@Alex: what do you think is the best solution for handling the "lock screen on 
resume" config option? My idea would be to move it to screen locker and expose 
the value through DBus, so that powerdevil can still read it.


Diffs (updated)
-

  ksmserver/screenlocker/CMakeLists.txt 
5378a10df2be70cee95b5612c23046eae639f610 
  ksmserver/screenlocker/autotests/CMakeLists.txt 
4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
  ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
a0253d687150702aa4c22200d9f6a577d0cab6be 
  ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
  ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
  ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 
  ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
  ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 

Diff: https://git.reviewboard.kde.org/r/119814/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-12-15 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review72034
---


https://git.reviewboard.kde.org/r/121530/ handles removal of the option from 
powerdevil

- Martin Gräßlin


On Dec. 15, 2014, 11:18 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Dec. 15, 2014, 11:18 a.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
> a0253d687150702aa4c22200d9f6a577d0cab6be 
>   ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-12-15 Thread Lukáš Tinkl 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review72049
---


Solid:Powermanagement has a signal resumingfromSuspend(), conversely, we could 
add a backend-independent signal goingToSleep() which ScreenLocker could 
connect to.

- Lukáš Tinkl


On Pro. 15, 2014, 11:18 dop., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Pro. 15, 2014, 11:18 dop.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
> a0253d687150702aa4c22200d9f6a577d0cab6be 
>   ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-12-15 Thread Martin Gräßlin 


> On Dec. 15, 2014, 2:01 p.m., Lukáš Tinkl wrote:
> > Solid:Powermanagement has a signal resumingfromSuspend(), conversely, we 
> > could add a backend-independent signal goingToSleep() which ScreenLocker 
> > could connect to.

so we could connent to the resumingFromSuspend for the non-logind backends. 
That would work...


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review72049
---


On Dec. 15, 2014, 11:18 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Dec. 15, 2014, 11:18 a.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
> a0253d687150702aa4c22200d9f6a577d0cab6be 
>   ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2015-01-02 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review72925
---


@Kai Uwe: you added a signal somewhere for non-logind systems. How can I adjust 
this change to make use of it?

- Martin Gräßlin


On Dec. 15, 2014, 11:18 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Dec. 15, 2014, 11:18 a.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
> a0253d687150702aa4c22200d9f6a577d0cab6be 
>   ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2015-01-04 Thread Kai Uwe Broulik 


> On Jan. 2, 2015, 11:16 vorm., Martin Gräßlin wrote:
> > @Kai Uwe: you added a signal somewhere for non-logind systems. How can I 
> > adjust this change to make use of it?

The signal you should connect to is:
  org.kde.Solid.PowerManagement
  /org/kde/Solid/PowerManagement/Actions/SuspendSession
  org.kde.Solid.PowerManagement.Actions.SuspendSession
  aboutToSuspend


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review72925
---


On Dez. 15, 2014, 10:18 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Dez. 15, 2014, 10:18 vorm.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
> a0253d687150702aa4c22200d9f6a577d0cab6be 
>   ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2015-01-04 Thread Kai Uwe Broulik 


> On Jan. 2, 2015, 11:16 vorm., Martin Gräßlin wrote:
> > @Kai Uwe: you added a signal somewhere for non-logind systems. How can I 
> > adjust this change to make use of it?
> 
> Kai Uwe Broulik wrote:
> The signal you should connect to is:
>   org.kde.Solid.PowerManagement
>   /org/kde/Solid/PowerManagement/Actions/SuspendSession
>   org.kde.Solid.PowerManagement.Actions.SuspendSession
>   aboutToSuspend

Note that this signal is emitted unconditionally, so if you're listening for 
Logind1, don't listen for/ignore this signal.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review72925
---


On Dez. 15, 2014, 10:18 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Dez. 15, 2014, 10:18 vorm.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
> a0253d687150702aa4c22200d9f6a577d0cab6be 
>   ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2015-01-04 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review73084
---


One issue I found while running this patch is that when the session resumes the 
screen is blank until I move the mouse or press a key. PowerDevil calls 
simulateUserActivity but that doesn't seem to work anymore with your recent 
Wayland changes.

- Kai Uwe Broulik


On Dez. 15, 2014, 10:18 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Dez. 15, 2014, 10:18 vorm.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
> a0253d687150702aa4c22200d9f6a577d0cab6be 
>   ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2015-01-05 Thread Martin Gräßlin 


> On Jan. 4, 2015, 6:05 p.m., Kai Uwe Broulik wrote:
> > One issue I found while running this patch is that when the session resumes 
> > the screen is blank until I move the mouse or press a key. PowerDevil calls 
> > simulateUserActivity but that doesn't seem to work anymore with your recent 
> > Wayland changes.

That might be totally unrelated. The screen is black for me since I pushed 
http://commits.kde.org/plasma-workspace/0ac34dca5d6a6ea8fc5c06e1dae96fb1ad4ce7c9
 - I still need to investigate the race condition there.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review73084
---


On Dec. 15, 2014, 11:18 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Dec. 15, 2014, 11:18 a.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
> a0253d687150702aa4c22200d9f6a577d0cab6be 
>   ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2015-01-05 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/
---

(Updated Jan. 5, 2015, 10:46 a.m.)


Review request for Plasma and Àlex Fiestas.


Changes
---

* added fallback through solid DBus signal. Note: this is untested as my system 
has logind.
* rebased to current master


Repository: plasma-workspace


Description
---

[ksld] ScreenLocker inhibits sleep on logind

When the system is going to sleep we want to ensure that the screen gets
locked before the system goes to sleep. Logind provides the inhibitor
locks which can be used for this.

If logind is available ksld gains an inhibitor lock for sleep when the
screen is unlocked. As soon as the screen gets locked the inhibitor lock
is released. In addition it connects to the prepareForSleep signal by
logind and locks the screen.

The solution needs to be extended to have a config option whether the
screen should be locked on sleep. Currently this is provided by
powerdevil. Also the solution can only work properly if power devil uses
logind's sleep dbus interface.

[ksld] Don't block till the greeter is started

We only want to ensure that the greeter gets started. There is no
need to block for that. Instead we can connect to the error signal
and unlock in case the greeter failed to start.


-
@Alex: what do you think is the best solution for handling the "lock screen on 
resume" config option? My idea would be to move it to screen locker and expose 
the value through DBus, so that powerdevil can still read it.


Diffs (updated)
-

  ksmserver/screenlocker/CMakeLists.txt 
83a5b39e3373ffef5e03218d2047ab0250b7c448 
  ksmserver/screenlocker/autotests/CMakeLists.txt 
4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
  ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
a0253d687150702aa4c22200d9f6a577d0cab6be 
  ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
  ksmserver/screenlocker/ksldapp.h a606aa84cb5d9628d6e8a68360b53ddc483c2778 
  ksmserver/screenlocker/ksldapp.cpp addf49e2f9cada9f1c0c69bc78837a30a7ab77e0 
  ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
  ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 

Diff: https://git.reviewboard.kde.org/r/119814/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2015-01-07 Thread Lukáš Tinkl 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review73392
---

Ship it!


Ship It!

- Lukáš Tinkl


On Led. 5, 2015, 10:46 dop., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Led. 5, 2015, 10:46 dop.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> 83a5b39e3373ffef5e03218d2047ab0250b7c448 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
> a0253d687150702aa4c22200d9f6a577d0cab6be 
>   ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
>   ksmserver/screenlocker/ksldapp.h a606aa84cb5d9628d6e8a68360b53ddc483c2778 
>   ksmserver/screenlocker/ksldapp.cpp addf49e2f9cada9f1c0c69bc78837a30a7ab77e0 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2015-01-07 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/#review73394
---

Ship it!


Ship It!

- Kai Uwe Broulik


On Jan. 5, 2015, 9:46 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119814/
> ---
> 
> (Updated Jan. 5, 2015, 9:46 vorm.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [ksld] ScreenLocker inhibits sleep on logind
> 
> When the system is going to sleep we want to ensure that the screen gets
> locked before the system goes to sleep. Logind provides the inhibitor
> locks which can be used for this.
> 
> If logind is available ksld gains an inhibitor lock for sleep when the
> screen is unlocked. As soon as the screen gets locked the inhibitor lock
> is released. In addition it connects to the prepareForSleep signal by
> logind and locks the screen.
> 
> The solution needs to be extended to have a config option whether the
> screen should be locked on sleep. Currently this is provided by
> powerdevil. Also the solution can only work properly if power devil uses
> logind's sleep dbus interface.
> 
> [ksld] Don't block till the greeter is started
> 
> We only want to ensure that the greeter gets started. There is no
> need to block for that. Instead we can connect to the error signal
> and unlock in case the greeter failed to start.
> 
> 
> -
> @Alex: what do you think is the best solution for handling the "lock screen 
> on resume" config option? My idea would be to move it to screen locker and 
> expose the value through DBus, so that powerdevil can still read it.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> 83a5b39e3373ffef5e03218d2047ab0250b7c448 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
> a0253d687150702aa4c22200d9f6a577d0cab6be 
>   ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
>   ksmserver/screenlocker/ksldapp.h a606aa84cb5d9628d6e8a68360b53ddc483c2778 
>   ksmserver/screenlocker/ksldapp.cpp addf49e2f9cada9f1c0c69bc78837a30a7ab77e0 
>   ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
>   ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 
> 
> Diff: https://git.reviewboard.kde.org/r/119814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2015-01-07 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/
---

(Updated Jan. 8, 2015, 7:24 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Àlex Fiestas.


Repository: plasma-workspace


Description
---

[ksld] ScreenLocker inhibits sleep on logind

When the system is going to sleep we want to ensure that the screen gets
locked before the system goes to sleep. Logind provides the inhibitor
locks which can be used for this.

If logind is available ksld gains an inhibitor lock for sleep when the
screen is unlocked. As soon as the screen gets locked the inhibitor lock
is released. In addition it connects to the prepareForSleep signal by
logind and locks the screen.

The solution needs to be extended to have a config option whether the
screen should be locked on sleep. Currently this is provided by
powerdevil. Also the solution can only work properly if power devil uses
logind's sleep dbus interface.

[ksld] Don't block till the greeter is started

We only want to ensure that the greeter gets started. There is no
need to block for that. Instead we can connect to the error signal
and unlock in case the greeter failed to start.


-
@Alex: what do you think is the best solution for handling the "lock screen on 
resume" config option? My idea would be to move it to screen locker and expose 
the value through DBus, so that powerdevil can still read it.


Diffs
-

  ksmserver/screenlocker/CMakeLists.txt 
83a5b39e3373ffef5e03218d2047ab0250b7c448 
  ksmserver/screenlocker/autotests/CMakeLists.txt 
4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
  ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
a0253d687150702aa4c22200d9f6a577d0cab6be 
  ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
  ksmserver/screenlocker/ksldapp.h a606aa84cb5d9628d6e8a68360b53ddc483c2778 
  ksmserver/screenlocker/ksldapp.cpp addf49e2f9cada9f1c0c69bc78837a30a7ab77e0 
  ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
  ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 

Diff: https://git.reviewboard.kde.org/r/119814/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel