Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---

(Updated Sept. 24, 2014, 3:22 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: kinfocenter


Description
---

By using the KWayland library we don't need to interact with the
low level C-library.


Diffs
-

  Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
  Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
  Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
  Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
  CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
  Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
  Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 

Diff: https://git.reviewboard.kde.org/r/120279/diff/


Testing
---


File Attachments


Screenshot showing that the Output Modes can be retrieved
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/23/0dc428e6-9ac0-4727-a1b8-0556ac849ee4__modes.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review67339
---

Ship it!


Ship It!

- David Edmundson


On Sept. 23, 2014, 1:58 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 23, 2014, 1:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot showing that the Output Modes can be retrieved
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/23/0dc428e6-9ac0-4727-a1b8-0556ac849ee4__modes.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---

(Updated Sept. 23, 2014, 3:58 p.m.)


Review request for Plasma.


Changes
---

added a screenshot of the modes


Repository: kinfocenter


Description
---

By using the KWayland library we don't need to interact with the
low level C-library.


Diffs
-

  Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
  Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
  Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
  Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
  CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
  Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
  Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 

Diff: https://git.reviewboard.kde.org/r/120279/diff/


Testing
---


File Attachments (updated)


Screenshot showing that the Output Modes can be retrieved
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/23/0dc428e6-9ac0-4727-a1b8-0556ac849ee4__modes.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---

(Updated Sept. 23, 2014, 3:57 p.m.)


Review request for Plasma.


Changes
---

Exposing yet another newly added feature to KWayland: modes in Output


Repository: kinfocenter


Description
---

By using the KWayland library we don't need to interact with the
low level C-library.


Diffs (updated)
-

  Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
  Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
  Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
  Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
  CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
  Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
  Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 

Diff: https://git.reviewboard.kde.org/r/120279/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---

(Updated Sept. 23, 2014, 1:07 p.m.)


Review request for Plasma.


Changes
---

Added an EventQueue (new class in KWayland).


Repository: kinfocenter


Description
---

By using the KWayland library we don't need to interact with the
low level C-library.


Diffs (updated)
-

  CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
  Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
  Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
  Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
  Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
  Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
  Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 

Diff: https://git.reviewboard.kde.org/r/120279/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 236
> > 
> >
> > This will add a row when the keyboard is added, but won't delete it 
> > when you remove it.
> > 
> > When you add a keyboard again you'll now have two.
> 
> Martin Gräßlin wrote:
> no, this is not how the seat works, unplugging the keyboard will not 
> remove the capability keyboard from the seat, neither will adding one at the 
> capability. One would have to reconfigure the system (in a way which I do not 
> know how to do).
> 
> Given that I think it's a very unlikely scenario that it would change 
> while the KCM is open.
> 
> David Edmundson wrote:
> then why are we using a connect? 
> Or is it more like we're going from from unknown -> "might have keyboard" 
> as we load the data?
> 
> Martin Gräßlin wrote:
> what I should add: I also don't want the KCM to update to changes. That's 
> why the Output gets deleted once the change signal is recieved. Unfortunately 
> wl_seat doesn't provide a mechanismn like wl_output to get a callback once 
> all data is submitted.
> 
> Martin Gräßlin wrote:
> > Or is it more like we're going from from unknown -> "might have 
> keyboard" as we load the data?
> 
> yes exactly. The information is pushed from wayland in an async way.
> 
> David Edmundson wrote:
> I don't know about Wayland, but on DBus having a client library that 
> hides the difference between false and just not loaded tends to be a headache 
> later on.
> 
> Martin Gräßlin wrote:
> Thanks for the suggestion. This might be added to KWayland::Client::Seat. 
> Unfortunately the Wayland interface is not really useful here. As I wrote 
> above: wl_output has a mechanism to announce when all information is set, 
> wl_seat doesn't. This should be fixed in the wl_seat interface and then we 
> could expose it in a useful way in the library.
> 
> David Edmundson wrote:
> and it doesn't always do the capabilitiesCallback/nameCallback on 
> connection?

no, that depends on the version. If the version is less than 2, the 
nameCallback will not be invoked. Also it's not specified in the documentation 
that the callbacks have to be invoked when connecting (which is explicitly 
stated for other interfaces). I don't know whether that is a documentation 
oversight or whether the capabilities don't have to be announced. For other 
interfaces (e.g. the _wl_fullscreen_shell) the capabilities are not announced 
if there are none.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66922
---


On Sept. 22, 2014, 3:46 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 22, 2014, 3:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[David Edmundson]

> On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 236
> > 
> >
> > This will add a row when the keyboard is added, but won't delete it 
> > when you remove it.
> > 
> > When you add a keyboard again you'll now have two.
> 
> Martin Gräßlin wrote:
> no, this is not how the seat works, unplugging the keyboard will not 
> remove the capability keyboard from the seat, neither will adding one at the 
> capability. One would have to reconfigure the system (in a way which I do not 
> know how to do).
> 
> Given that I think it's a very unlikely scenario that it would change 
> while the KCM is open.
> 
> David Edmundson wrote:
> then why are we using a connect? 
> Or is it more like we're going from from unknown -> "might have keyboard" 
> as we load the data?
> 
> Martin Gräßlin wrote:
> what I should add: I also don't want the KCM to update to changes. That's 
> why the Output gets deleted once the change signal is recieved. Unfortunately 
> wl_seat doesn't provide a mechanismn like wl_output to get a callback once 
> all data is submitted.
> 
> Martin Gräßlin wrote:
> > Or is it more like we're going from from unknown -> "might have 
> keyboard" as we load the data?
> 
> yes exactly. The information is pushed from wayland in an async way.
> 
> David Edmundson wrote:
> I don't know about Wayland, but on DBus having a client library that 
> hides the difference between false and just not loaded tends to be a headache 
> later on.
> 
> Martin Gräßlin wrote:
> Thanks for the suggestion. This might be added to KWayland::Client::Seat. 
> Unfortunately the Wayland interface is not really useful here. As I wrote 
> above: wl_output has a mechanism to announce when all information is set, 
> wl_seat doesn't. This should be fixed in the wl_seat interface and then we 
> could expose it in a useful way in the library.

and it doesn't always do the capabilitiesCallback/nameCallback on connection?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66922
---


On Sept. 22, 2014, 1:46 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 22, 2014, 1:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 236
> > 
> >
> > This will add a row when the keyboard is added, but won't delete it 
> > when you remove it.
> > 
> > When you add a keyboard again you'll now have two.
> 
> Martin Gräßlin wrote:
> no, this is not how the seat works, unplugging the keyboard will not 
> remove the capability keyboard from the seat, neither will adding one at the 
> capability. One would have to reconfigure the system (in a way which I do not 
> know how to do).
> 
> Given that I think it's a very unlikely scenario that it would change 
> while the KCM is open.
> 
> David Edmundson wrote:
> then why are we using a connect? 
> Or is it more like we're going from from unknown -> "might have keyboard" 
> as we load the data?
> 
> Martin Gräßlin wrote:
> what I should add: I also don't want the KCM to update to changes. That's 
> why the Output gets deleted once the change signal is recieved. Unfortunately 
> wl_seat doesn't provide a mechanismn like wl_output to get a callback once 
> all data is submitted.
> 
> Martin Gräßlin wrote:
> > Or is it more like we're going from from unknown -> "might have 
> keyboard" as we load the data?
> 
> yes exactly. The information is pushed from wayland in an async way.
> 
> David Edmundson wrote:
> I don't know about Wayland, but on DBus having a client library that 
> hides the difference between false and just not loaded tends to be a headache 
> later on.

Thanks for the suggestion. This might be added to KWayland::Client::Seat. 
Unfortunately the Wayland interface is not really useful here. As I wrote 
above: wl_output has a mechanism to announce when all information is set, 
wl_seat doesn't. This should be fixed in the wl_seat interface and then we 
could expose it in a useful way in the library.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66922
---


On Sept. 22, 2014, 3:46 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 22, 2014, 3:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[David Edmundson]

> On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 289
> > 
> >
> > Why make this a function and use it once? It seems rather pointless.
> 
> Martin Gräßlin wrote:
> simple: I didn't want to have a temporary variable I have to use.

a function pointer is a temproary variable.

If we're gonna make static methods, we may as well make a static method.


> On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 236
> > 
> >
> > This will add a row when the keyboard is added, but won't delete it 
> > when you remove it.
> > 
> > When you add a keyboard again you'll now have two.
> 
> Martin Gräßlin wrote:
> no, this is not how the seat works, unplugging the keyboard will not 
> remove the capability keyboard from the seat, neither will adding one at the 
> capability. One would have to reconfigure the system (in a way which I do not 
> know how to do).
> 
> Given that I think it's a very unlikely scenario that it would change 
> while the KCM is open.
> 
> David Edmundson wrote:
> then why are we using a connect? 
> Or is it more like we're going from from unknown -> "might have keyboard" 
> as we load the data?
> 
> Martin Gräßlin wrote:
> what I should add: I also don't want the KCM to update to changes. That's 
> why the Output gets deleted once the change signal is recieved. Unfortunately 
> wl_seat doesn't provide a mechanismn like wl_output to get a callback once 
> all data is submitted.
> 
> Martin Gräßlin wrote:
> > Or is it more like we're going from from unknown -> "might have 
> keyboard" as we load the data?
> 
> yes exactly. The information is pushed from wayland in an async way.

I don't know about Wayland, but on DBus having a client library that hides the 
difference between false and just not loaded tends to be a headache later on.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66922
---


On Sept. 22, 2014, 1:46 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 22, 2014, 1:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---

(Updated Sept. 22, 2014, 3:46 p.m.)


Review request for Plasma.


Changes
---

fixed the two reported styling issues.


Repository: kinfocenter


Description
---

By using the KWayland library we don't need to interact with the
low level C-library.


Diffs (updated)
-

  CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
  Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
  Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
  Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
  Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
  Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
  Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 

Diff: https://git.reviewboard.kde.org/r/120279/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

> On Sept. 20, 2014, 11:27 p.m., Pier Luigi Fiorini wrote:
> > Modules/base/info_wayland.cpp, line 210
> > 
> >
> > Why we need a new connection?
> > QPA already has one.

there is no QPA in this case. It's for reporting information for everything 
available even if Qt doesn't support it. Likewise the X11 info module opens an 
own connection.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review67091
---


On Sept. 19, 2014, 12:49 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 19, 2014, 12:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Pier Luigi Fiorini]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review67092
---



Modules/base/info_wayland.cpp


need a space after comma, before registry



Modules/base/info_wayland.cpp


name is used


- Pier Luigi Fiorini


On Sept. 19, 2014, 10:49 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 19, 2014, 10:49 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Pier Luigi Fiorini]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review67091
---



Modules/base/info_wayland.cpp


Why we need a new connection?
QPA already has one.


- Pier Luigi Fiorini


On Sept. 19, 2014, 10:49 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 19, 2014, 10:49 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---

(Updated Sept. 19, 2014, 12:49 p.m.)


Review request for Plasma.


Changes
---

* removed the superfluuos new ConnectionThread
* removed the two lambda functions which are only used once

Not changed:
* lambda nesting
* the seat changed connections


Repository: kinfocenter


Description
---

By using the KWayland library we don't need to interact with the
low level C-library.


Diffs (updated)
-

  CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
  Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
  Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
  Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
  Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
  Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
  Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 

Diff: https://git.reviewboard.kde.org/r/120279/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

> On Sept. 19, 2014, 11:53 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 194
> > 
> >
> > aren't we doing this in the ctor too?

good spot, I moved the code later-on to the class and oversaw that one!.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66928
---


On Sept. 19, 2014, 11:07 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 19, 2014, 11:07 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 236
> > 
> >
> > This will add a row when the keyboard is added, but won't delete it 
> > when you remove it.
> > 
> > When you add a keyboard again you'll now have two.
> 
> Martin Gräßlin wrote:
> no, this is not how the seat works, unplugging the keyboard will not 
> remove the capability keyboard from the seat, neither will adding one at the 
> capability. One would have to reconfigure the system (in a way which I do not 
> know how to do).
> 
> Given that I think it's a very unlikely scenario that it would change 
> while the KCM is open.
> 
> David Edmundson wrote:
> then why are we using a connect? 
> Or is it more like we're going from from unknown -> "might have keyboard" 
> as we load the data?
> 
> Martin Gräßlin wrote:
> what I should add: I also don't want the KCM to update to changes. That's 
> why the Output gets deleted once the change signal is recieved. Unfortunately 
> wl_seat doesn't provide a mechanismn like wl_output to get a callback once 
> all data is submitted.

> Or is it more like we're going from from unknown -> "might have keyboard" as 
> we load the data?

yes exactly. The information is pushed from wayland in an async way.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66922
---


On Sept. 19, 2014, 11:07 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 19, 2014, 11:07 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 236
> > 
> >
> > This will add a row when the keyboard is added, but won't delete it 
> > when you remove it.
> > 
> > When you add a keyboard again you'll now have two.
> 
> Martin Gräßlin wrote:
> no, this is not how the seat works, unplugging the keyboard will not 
> remove the capability keyboard from the seat, neither will adding one at the 
> capability. One would have to reconfigure the system (in a way which I do not 
> know how to do).
> 
> Given that I think it's a very unlikely scenario that it would change 
> while the KCM is open.
> 
> David Edmundson wrote:
> then why are we using a connect? 
> Or is it more like we're going from from unknown -> "might have keyboard" 
> as we load the data?

what I should add: I also don't want the KCM to update to changes. That's why 
the Output gets deleted once the change signal is recieved. Unfortunately 
wl_seat doesn't provide a mechanismn like wl_output to get a callback once all 
data is submitted.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66922
---


On Sept. 19, 2014, 11:07 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 19, 2014, 11:07 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66928
---



Modules/base/info_wayland.cpp


aren't we doing this in the ctor too?


- David Edmundson


On Sept. 19, 2014, 9:07 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 19, 2014, 9:07 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[David Edmundson]

> On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 236
> > 
> >
> > This will add a row when the keyboard is added, but won't delete it 
> > when you remove it.
> > 
> > When you add a keyboard again you'll now have two.
> 
> Martin Gräßlin wrote:
> no, this is not how the seat works, unplugging the keyboard will not 
> remove the capability keyboard from the seat, neither will adding one at the 
> capability. One would have to reconfigure the system (in a way which I do not 
> know how to do).
> 
> Given that I think it's a very unlikely scenario that it would change 
> while the KCM is open.

then why are we using a connect? 
Or is it more like we're going from from unknown -> "might have keyboard" as we 
load the data?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66922
---


On Sept. 19, 2014, 9:07 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 19, 2014, 9:07 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 236
> > 
> >
> > This will add a row when the keyboard is added, but won't delete it 
> > when you remove it.
> > 
> > When you add a keyboard again you'll now have two.

no, this is not how the seat works, unplugging the keyboard will not remove the 
capability keyboard from the seat, neither will adding one at the capability. 
One would have to reconfigure the system (in a way which I do not know how to 
do).

Given that I think it's a very unlikely scenario that it would change while the 
KCM is open.


> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 289
> > 
> >
> > Why make this a function and use it once? It seems rather pointless.

simple: I didn't want to have a temporary variable I have to use.


> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
> > Modules/base/info_wayland.cpp, line 258
> > 
> >
> > a lambda in a lambda in a lambda in a lamba is just getting silly.

any better suggestion for connecting to the signals without having to add slots 
to the class and then starting to add member variables to the class?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66922
---


On Sept. 19, 2014, 11:07 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 19, 2014, 11:07 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120279: Port to KWayland client library

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66922
---



Modules/base/info_wayland.cpp


This will add a row when the keyboard is added, but won't delete it when 
you remove it.

When you add a keyboard again you'll now have two.



Modules/base/info_wayland.cpp


a lambda in a lambda in a lambda in a lamba is just getting silly.



Modules/base/info_wayland.cpp


Why make this a function and use it once? It seems rather pointless.


- David Edmundson


On Sept. 19, 2014, 9:07 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> ---
> 
> (Updated Sept. 19, 2014, 9:07 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> ---
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -
> 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120279: Port to KWayland client library

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---

Review request for Plasma.


Repository: kinfocenter


Description
---

By using the KWayland library we don't need to interact with the
low level C-library.


Diffs
-

  Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
  CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
  Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
  Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
  Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
  Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
  Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 

Diff: https://git.reviewboard.kde.org/r/120279/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel