subject:"Review Request 120314\: Add timezones support into clock applet"

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/
---

(Updated Sept. 24, 2014, 9:02 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

I've picked up Kai's branch where he started the timezone support and finished 
it.

New features:
 * timezones tab in the config
 * changing timezones by scrolling a wheel on the clock
   * that's optional, defaults to off
 * displaying non-local timezones as either city or abbreviation
 * "Show time zone" config option is now changed to "Show local time zone" as 
foreign zones are always displayed by default
 
What's still missing:
 * selecting default timezone in the config (should be fairly easy; currently 
the last used is restored on login
 * timezones in the popup, this would require either large changes to the 
applet (moving functions around) or displaying the time in non-locale way
 
 


Diffs
-

  applets/digital-clock/package/contents/config/config.qml f897c9a 
  applets/digital-clock/package/contents/config/main.xml cbeb02f 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
  applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
  applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e78f1f3 
  applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
  applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
  applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
  applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
  applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
  applets/digital-clock/plugin/qmldir 3d57bbb 
  applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
  dataengines/time/timesource.cpp b79fd7c 

Diff: https://git.reviewboard.kde.org/r/120314/diff/


Testing
---

I've been using it for couple days, all those features from above work nicely 
here, with all sorts of config configurations (eg. if date is displayed, it 
also changes properly with timezone change).


File Attachments


Timezone & date displayed
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
Timezone without date
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Eike Hein


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67393
---

Ship it!


Summing up from IRC:

a) The new message widget approach is really nice, but still needs to handle 
button alignment, text overflow and probably layout mirroring.

b) Still has the problem with the delegate check state not updating in the 
Local fallback mechanic.

Overall: Since we're running up against message+feature freeze IMHO it should 
go in; the above issues are solvable in the QA period.

- Eike Hein


On Sept. 24, 2014, 8:40 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 24, 2014, 8:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Kai Uwe Broulik



> On Sept. 24, 2014, 2:42 nachm., Eike Hein wrote:
> > Doesn't always keeping Local enabled create an awkward situation if you 
> > want to default a clock to a non-Local timezone but want wheel scrolling 
> > disabled for accident-safety a la sebas?
> > 
> > Then you need to:
> > 
> > 1. Enable additional timezone
> > 2. Enable wheelscroll
> > 3. OK dialog
> > 4. Change TZ by scrolling
> > 5. Go back to dialog to disable wheelscroll
> 
> Kai Uwe Broulik wrote:
> In Plasma 4.x there is a combo box that allows you to change the timezone 
> without a mousewheel (which should be possible nonetheless, since mousewheels 
> are neither always available nor discoverable).
> 
> And imho a message box is the worst possible solution. A message widget I 
> could live with but then we don't have that in QML yet.

Sorry, I misread the change message, it now actually is using a messagewidget 
like thing. Ship it from my side.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67360
---


On Sept. 24, 2014, 8:40 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 24, 2014, 8:40 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Kai Uwe Broulik



> On Sept. 24, 2014, 2:42 nachm., Eike Hein wrote:
> > Doesn't always keeping Local enabled create an awkward situation if you 
> > want to default a clock to a non-Local timezone but want wheel scrolling 
> > disabled for accident-safety a la sebas?
> > 
> > Then you need to:
> > 
> > 1. Enable additional timezone
> > 2. Enable wheelscroll
> > 3. OK dialog
> > 4. Change TZ by scrolling
> > 5. Go back to dialog to disable wheelscroll

In Plasma 4.x there is a combo box that allows you to change the timezone 
without a mousewheel (which should be possible nonetheless, since mousewheels 
are neither always available nor discoverable).

And imho a message box is the worst possible solution. A message widget I could 
live with but then we don't have that in QML yet.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67360
---


On Sept. 24, 2014, 8:40 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 24, 2014, 8:40 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/
---

(Updated Sept. 24, 2014, 10:40 p.m.)


Review request for Plasma.


Changes
---

Fix the issue from Eike - Local is now not always selected, but when 
deselecting all the timezones, a KMessageWidget-like widget appears telling the 
user that the Local was enabled.

Tooltip date was not yet fixed; will require more work.


Repository: plasma-workspace


Description
---

I've picked up Kai's branch where he started the timezone support and finished 
it.

New features:
 * timezones tab in the config
 * changing timezones by scrolling a wheel on the clock
   * that's optional, defaults to off
 * displaying non-local timezones as either city or abbreviation
 * "Show time zone" config option is now changed to "Show local time zone" as 
foreign zones are always displayed by default
 
What's still missing:
 * selecting default timezone in the config (should be fairly easy; currently 
the last used is restored on login
 * timezones in the popup, this would require either large changes to the 
applet (moving functions around) or displaying the time in non-locale way
 
 


Diffs (updated)
-

  applets/digital-clock/package/contents/config/config.qml f897c9a 
  applets/digital-clock/package/contents/config/main.xml cbeb02f 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
  applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
  applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e78f1f3 
  applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
  applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
  applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
  applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
  applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
  applets/digital-clock/plugin/qmldir 3d57bbb 
  applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
  dataengines/time/timesource.cpp b79fd7c 

Diff: https://git.reviewboard.kde.org/r/120314/diff/


Testing
---

I've been using it for couple days, all those features from above work nicely 
here, with all sorts of config configurations (eg. if date is displayed, it 
also changes properly with timezone change).


File Attachments


Timezone & date displayed
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
Timezone without date
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Lukáš Tinkl



> On Zář. 24, 2014, 4:33 odp., Lukáš Tinkl wrote:
> > Please put the city as the 2nd column, otherwise a ship it from me 
> > definitely, great work!

For the record, the tooltip can be wrong for certain TZs (yesterday/tomorrow 
with the correct day name should be shown instead)


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67357
---


On Zář. 24, 2014, 11:43 dop., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Zář. 24, 2014, 11:43 dop.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Eike Hein


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67360
---


Doesn't always keeping Local enabled create an awkward situation if you want to 
default a clock to a non-Local timezone but want wheel scrolling disabled for 
accident-safety a la sebas?

Then you need to:

1. Enable additional timezone
2. Enable wheelscroll
3. OK dialog
4. Change TZ by scrolling
5. Go back to dialog to disable wheelscroll

- Eike Hein


On Sept. 24, 2014, 9:43 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 24, 2014, 9:43 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Lukáš Tinkl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67357
---

Ship it!


Please put the city as the 2nd column, otherwise a ship it from me definitely, 
great work!

- Lukáš Tinkl


On Zář. 24, 2014, 11:43 dop., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Zář. 24, 2014, 11:43 dop.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/
---

(Updated Sept. 24, 2014, 11:43 a.m.)


Review request for Plasma.


Changes
---

Revert the latest changes and simply disable the "Local" checkbox, this makes 
sure it always stays selected. Makes things simpler.


Repository: plasma-workspace


Description
---

I've picked up Kai's branch where he started the timezone support and finished 
it.

New features:
 * timezones tab in the config
 * changing timezones by scrolling a wheel on the clock
   * that's optional, defaults to off
 * displaying non-local timezones as either city or abbreviation
 * "Show time zone" config option is now changed to "Show local time zone" as 
foreign zones are always displayed by default
 
What's still missing:
 * selecting default timezone in the config (should be fairly easy; currently 
the last used is restored on login
 * timezones in the popup, this would require either large changes to the 
applet (moving functions around) or displaying the time in non-locale way
 
 


Diffs (updated)
-

  applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e78f1f3 
  applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
  applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
  applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
  applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
  applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
  applets/digital-clock/plugin/qmldir 3d57bbb 
  applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
  dataengines/time/timesource.cpp b79fd7c 
  applets/digital-clock/package/contents/config/config.qml f897c9a 
  applets/digital-clock/package/contents/config/main.xml cbeb02f 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
  applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 

Diff: https://git.reviewboard.kde.org/r/120314/diff/


Testing
---

I've been using it for couple days, all those features from above work nicely 
here, with all sorts of config configurations (eg. if date is displayed, it 
also changes properly with timezone change).


File Attachments


Timezone & date displayed
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
Timezone without date
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-23 Thread Martin Klapetek



> On Sept. 23, 2014, 12:24 a.m., Eike Hein wrote:
> > Place names with multiple names use _ as word separator, and don't get 
> > scaled down enough nor elided to fit a narrow vertical panel:
> > 
> > ![Long place name](http://wstaw.org/m/2014/09/23/crop.png)
> 
> Martin Klapetek wrote:
> Right, there's that translations issue. So the city comes from the 
> Timezone ID, but it's not proper name. There is no better way in Qt currently.
> 
> I'd propose creating a map of id<-->i18n city name for now, like
> 
> {"Adis_Ababa", i18n("Adis Ababa");}
> 
> Sebastian Kügler wrote:
> I think it should be safe here to just replace the _ with " ", a map with 
> translations of all cities sounds like overkill to me.

There is another use of/need for that - these cities parsed from the id are 
used everywhere in the UIs and we want those to be translated, eg. having 
"Praha" rather than "Prague" for Czech users


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67241
---


On Sept. 23, 2014, 10:55 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 23, 2014, 10:55 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-23 Thread Sebastian Kügler



> On Sept. 22, 2014, 10:24 p.m., Eike Hein wrote:
> > Place names with multiple names use _ as word separator, and don't get 
> > scaled down enough nor elided to fit a narrow vertical panel:
> > 
> > ![Long place name](http://wstaw.org/m/2014/09/23/crop.png)
> 
> Martin Klapetek wrote:
> Right, there's that translations issue. So the city comes from the 
> Timezone ID, but it's not proper name. There is no better way in Qt currently.
> 
> I'd propose creating a map of id<-->i18n city name for now, like
> 
> {"Adis_Ababa", i18n("Adis Ababa");}

I think it should be safe here to just replace the _ with " ", a map with 
translations of all cities sounds like overkill to me.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67241
---


On Sept. 23, 2014, 8:55 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 23, 2014, 8:55 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-23 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/
---

(Updated Sept. 23, 2014, 10:55 a.m.)


Review request for Plasma.


Changes
---

Fixes an issue which allowed deselecting all timezones, now it popups a 
messagebox informing the user and then proceeds to select the Local zone.

Two things, in this diff I forgot the i18n for the dialog text (fixed locally) 
and for some reason the checkbox next to Local does not get checked properly in 
the above case, even though the model /has/ correct data, not sure what's going 
on in there (I'll be gone for most of today so if anyone has any idea, please 
let me know).


Repository: plasma-workspace


Description
---

I've picked up Kai's branch where he started the timezone support and finished 
it.

New features:
 * timezones tab in the config
 * changing timezones by scrolling a wheel on the clock
   * that's optional, defaults to off
 * displaying non-local timezones as either city or abbreviation
 * "Show time zone" config option is now changed to "Show local time zone" as 
foreign zones are always displayed by default
 
What's still missing:
 * selecting default timezone in the config (should be fairly easy; currently 
the last used is restored on login
 * timezones in the popup, this would require either large changes to the 
applet (moving functions around) or displaying the time in non-locale way
 
 


Diffs (updated)
-

  applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
  dataengines/time/timesource.cpp b79fd7c 
  applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
  applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
  applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
  applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
  applets/digital-clock/plugin/qmldir 3d57bbb 
  applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
  applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e78f1f3 
  applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
  applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
  applets/digital-clock/package/contents/config/config.qml f897c9a 
  applets/digital-clock/package/contents/config/main.xml cbeb02f 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 

Diff: https://git.reviewboard.kde.org/r/120314/diff/


Testing
---

I've been using it for couple days, all those features from above work nicely 
here, with all sorts of config configurations (eg. if date is displayed, it 
also changes properly with timezone change).


File Attachments


Timezone & date displayed
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
Timezone without date
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-23 Thread Martin Klapetek



> On Sept. 23, 2014, 12:24 a.m., Eike Hein wrote:
> > Place names with multiple names use _ as word separator, and don't get 
> > scaled down enough nor elided to fit a narrow vertical panel:
> > 
> > ![Long place name](http://wstaw.org/m/2014/09/23/crop.png)

Right, there's that translations issue. So the city comes from the Timezone ID, 
but it's not proper name. There is no better way in Qt currently.

I'd propose creating a map of id<-->i18n city name for now, like

{"Adis_Ababa", i18n("Adis Ababa");}


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67241
---


On Sept. 22, 2014, 11:59 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 11:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-23 Thread Martin Klapetek



> On Sept. 23, 2014, 12:22 a.m., Eike Hein wrote:
> > I can no longer reproduce my problem from earlier, but note it's possible 
> > to deselect all timezones in the config and then you get:
> > 
> > plasmashell(28432)/default unknown: 
> > file:///home/sho/devel/install/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/DigitalClock.qml:84:
> >  TypeError: Cannot read property 'DateTime' of undefined

Alright, I fixed this by adding a check and when all timezones are deselected, 
a dialog box appears telling the user that Local will be selected and Local is 
then selected. So this should not happen anymore.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67240
---


On Sept. 22, 2014, 11:59 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 11:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein



> On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote:
> > I think scaling could use a little more love:
> > 
> > ![http://wstaw.org/m/2014/09/22/scaling.png](Text scaling)
> > 
> > Specifically, notice how the time part isn't of uniform size. I guess it 
> > gets scaled to fit in with the city text size, which is scaled to fit 
> > horizontally. But in an arrangement like this, it would look nicer if the 
> > time size was uniform.
> 
> Eike Hein wrote:
> Sorry, botched the image embed:
> 
> ![Text scaling](http://wstaw.org/m/2014/09/22/scaling.png)
> 
> Martin Klapetek wrote:
> Ah yeah, that is because just one label is used for the whole thing, so 
> when it needs to scale the font down to fit "Manila", it also scales down the 
> clock font :S
> 
> At this point I'd like to leave this as is for now as fixing it would 
> require splitting this into two standalone labels and given this change would 
> not be trivial, I'd leave it for after this gets merged.
> 
> Eike Hein wrote:
> Yeah I think that's fine, it's an edge case.

That said, it also means the time size changes a lot while mouse-wheeling to 
change zones, which is a little less edge case-y and pretty ugly.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67225
---


On Sept. 22, 2014, 9:59 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 9:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67241
---


Place names with multiple names use _ as word separator, and don't get scaled 
down enough nor elided to fit a narrow vertical panel:

![Long place name](http://wstaw.org/m/2014/09/23/crop.png)

- Eike Hein


On Sept. 22, 2014, 9:59 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 9:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67240
---


I can no longer reproduce my problem from earlier, but note it's possible to 
deselect all timezones in the config and then you get:

plasmashell(28432)/default unknown: 
file:///home/sho/devel/install/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/DigitalClock.qml:84:
 TypeError: Cannot read property 'DateTime' of undefined

- Eike Hein


On Sept. 22, 2014, 9:59 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 9:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein



> On Sept. 22, 2014, 10:18 p.m., Eike Hein wrote:
> > Patch doesn't apply cleanly to master:
> > 
> > 
> > The next patch would delete the file 
> > a/applets/digital-clock/plugin/processrunnerplugin.h,
> > which does not exist!  Assume -R? [n]

Uh never mind - fat-fingered the patch level. It's late ...


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67238
---


On Sept. 22, 2014, 9:59 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 9:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67238
---


Patch doesn't apply cleanly to master:


The next patch would delete the file 
a/applets/digital-clock/plugin/processrunnerplugin.h,
which does not exist!  Assume -R? [n]

- Eike Hein


On Sept. 22, 2014, 9:59 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 9:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/
---

(Updated Sept. 22, 2014, 11:59 p.m.)


Review request for Plasma.


Changes
---

\* Removed the combobox for the default timezone
  \* The last displayed timezone is used instead
\* More robust remembering the last used timezone
\* Don't force Local to be always selected
\* Cannot reproduce Eike's issue with not remembering config, can anyone else 
confirm?


Repository: plasma-workspace


Description
---

I've picked up Kai's branch where he started the timezone support and finished 
it.

New features:
 * timezones tab in the config
 * changing timezones by scrolling a wheel on the clock
   * that's optional, defaults to off
 * displaying non-local timezones as either city or abbreviation
 * "Show time zone" config option is now changed to "Show local time zone" as 
foreign zones are always displayed by default
 
What's still missing:
 * selecting default timezone in the config (should be fairly easy; currently 
the last used is restored on login
 * timezones in the popup, this would require either large changes to the 
applet (moving functions around) or displaying the time in non-locale way
 
 


Diffs (updated)
-

  applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
  applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
  applets/digital-clock/plugin/qmldir 3d57bbb 
  applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
  dataengines/time/timesource.cpp b79fd7c 
  applets/digital-clock/package/contents/config/config.qml f897c9a 
  applets/digital-clock/package/contents/config/main.xml cbeb02f 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
  applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
  applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e78f1f3 
  applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
  applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
  applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120314/diff/


Testing
---

I've been using it for couple days, all those features from above work nicely 
here, with all sorts of config configurations (eg. if date is displayed, it 
also changes properly with timezone change).


File Attachments


Timezone & date displayed
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
Timezone without date
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein



> On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote:
> > I think scaling could use a little more love:
> > 
> > ![http://wstaw.org/m/2014/09/22/scaling.png](Text scaling)
> > 
> > Specifically, notice how the time part isn't of uniform size. I guess it 
> > gets scaled to fit in with the city text size, which is scaled to fit 
> > horizontally. But in an arrangement like this, it would look nicer if the 
> > time size was uniform.
> 
> Eike Hein wrote:
> Sorry, botched the image embed:
> 
> ![Text scaling](http://wstaw.org/m/2014/09/22/scaling.png)
> 
> Martin Klapetek wrote:
> Ah yeah, that is because just one label is used for the whole thing, so 
> when it needs to scale the font down to fit "Manila", it also scales down the 
> clock font :S
> 
> At this point I'd like to leave this as is for now as fixing it would 
> require splitting this into two standalone labels and given this change would 
> not be trivial, I'd leave it for after this gets merged.

Yeah I think that's fine, it's an edge case.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67225
---


On Sept. 22, 2014, 2:33 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 2:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek



> On Sept. 22, 2014, 9:03 p.m., Eike Hein wrote:
> > I think scaling could use a little more love:
> > 
> > ![http://wstaw.org/m/2014/09/22/scaling.png](Text scaling)
> > 
> > Specifically, notice how the time part isn't of uniform size. I guess it 
> > gets scaled to fit in with the city text size, which is scaled to fit 
> > horizontally. But in an arrangement like this, it would look nicer if the 
> > time size was uniform.
> 
> Eike Hein wrote:
> Sorry, botched the image embed:
> 
> ![Text scaling](http://wstaw.org/m/2014/09/22/scaling.png)

Ah yeah, that is because just one label is used for the whole thing, so when it 
needs to scale the font down to fit "Manila", it also scales down the clock 
font :S

At this point I'd like to leave this as is for now as fixing it would require 
splitting this into two standalone labels and given this change would not be 
trivial, I'd leave it for after this gets merged.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67225
---


On Sept. 22, 2014, 4:33 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 4:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67225
---


I think scaling could use a little more love:

![http://wstaw.org/m/2014/09/22/scaling.png](Text scaling)

Specifically, notice how the time part isn't of uniform size. I guess it gets 
scaled to fit in with the city text size, which is scaled to fit horizontally. 
But in an arrangement like this, it would look nicer if the time size was 
uniform.

- Eike Hein


On Sept. 22, 2014, 2:33 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 2:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein



> On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote:
> > I think scaling could use a little more love:
> > 
> > ![http://wstaw.org/m/2014/09/22/scaling.png](Text scaling)
> > 
> > Specifically, notice how the time part isn't of uniform size. I guess it 
> > gets scaled to fit in with the city text size, which is scaled to fit 
> > horizontally. But in an arrangement like this, it would look nicer if the 
> > time size was uniform.

Sorry, botched the image embed:

![Text scaling](http://wstaw.org/m/2014/09/22/scaling.png)


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67225
---


On Sept. 22, 2014, 2:33 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 2:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67205
---


The following steps lead to unexpected behavior for me:

a) Add Digital Clock to panel.

b) Set display to "Timezone city".

c) Disable "Local".

d) Enable "Manila".

e) Set default to "Manila".

f) Click OK.

Expected result: A Digital Clock showing Manila.

Actual result: No changes. Opening the config again, Manila is disabled and 
default is Berlin. All changes seem to have been lost.

Seems to be related to disabling "Local".

- Eike Hein


On Sept. 22, 2014, 2:33 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 2:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/
---

(Updated Sept. 22, 2014, 4:33 p.m.)


Review request for Plasma.


Changes
---

Change showTimezone property to showLocalTimezone to better reflect what it 
actually does


Repository: plasma-workspace


Description
---

I've picked up Kai's branch where he started the timezone support and finished 
it.

New features:
 * timezones tab in the config
 * changing timezones by scrolling a wheel on the clock
   * that's optional, defaults to off
 * displaying non-local timezones as either city or abbreviation
 * "Show time zone" config option is now changed to "Show local time zone" as 
foreign zones are always displayed by default
 
What's still missing:
 * selecting default timezone in the config (should be fairly easy; currently 
the last used is restored on login
 * timezones in the popup, this would require either large changes to the 
applet (moving functions around) or displaying the time in non-locale way
 
 


Diffs (updated)
-

  applets/digital-clock/package/contents/config/config.qml f897c9a 
  applets/digital-clock/package/contents/config/main.xml cbeb02f 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
  applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
  applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e78f1f3 
  applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
  applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
  applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
  applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
  applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
  applets/digital-clock/plugin/qmldir 3d57bbb 
  applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
  dataengines/time/timesource.cpp b79fd7c 

Diff: https://git.reviewboard.kde.org/r/120314/diff/


Testing
---

I've been using it for couple days, all those features from above work nicely 
here, with all sorts of config configurations (eg. if date is displayed, it 
also changes properly with timezone change).


File Attachments


Timezone & date displayed
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
Timezone without date
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/
---

(Updated Sept. 22, 2014, 2:55 p.m.)


Review request for Plasma.


Changes
---

Fix issues pointed by Kai


Repository: plasma-workspace


Description
---

I've picked up Kai's branch where he started the timezone support and finished 
it.

New features:
 * timezones tab in the config
 * changing timezones by scrolling a wheel on the clock
   * that's optional, defaults to off
 * displaying non-local timezones as either city or abbreviation
 * "Show time zone" config option is now changed to "Show local time zone" as 
foreign zones are always displayed by default
 
What's still missing:
 * selecting default timezone in the config (should be fairly easy; currently 
the last used is restored on login
 * timezones in the popup, this would require either large changes to the 
applet (moving functions around) or displaying the time in non-locale way
 
 


Diffs (updated)
-

  applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
  applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e78f1f3 
  applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
  applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
  applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
  applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
  applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
  applets/digital-clock/plugin/qmldir 3d57bbb 
  applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
  dataengines/time/timesource.cpp b79fd7c 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
  applets/digital-clock/package/contents/config/config.qml f897c9a 
  applets/digital-clock/package/contents/config/main.xml cbeb02f 

Diff: https://git.reviewboard.kde.org/r/120314/diff/


Testing
---

I've been using it for couple days, all those features from above work nicely 
here, with all sorts of config configurations (eg. if date is displayed, it 
also changes properly with timezone change).


File Attachments


Timezone & date displayed
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
Timezone without date
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67181
---


Thanks for your work! :)


applets/digital-clock/package/contents/ui/DigitalClock.qml


I think this should be i18n'd

just time
 -> return time
time + timezone
 -> return i18nc("explain", "%1 (%2)", time, timezone)
time + date 
 -> return time + "" + date
time + timezone + date
 -> return time + "" + i18nc("explain", "%1 (%2)", date, timezone)



applets/digital-clock/package/contents/ui/DigitalClock.qml


delta > 0



applets/digital-clock/package/contents/ui/DigitalClock.qml


Remove



applets/digital-clock/package/contents/ui/configTimeZones.qml


Whitespace



applets/digital-clock/plugin/CMakeLists.txt


Still needed after your changes?


- Kai Uwe Broulik


On Sept. 22, 2014, 11:05 vorm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> ---
> 
> (Updated Sept. 22, 2014, 11:05 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I've picked up Kai's branch where he started the timezone support and 
> finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>* that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as 
> foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently 
> the last used is restored on login
>  * timezones in the popup, this would require either large changes to the 
> applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> ---
> 
> I've been using it for couple days, all those features from above work nicely 
> here, with all sorts of config configurations (eg. if date is displayed, it 
> also changes properly with timezone change).
> 
> 
> File Attachments
> 
> 
> Timezone & date displayed
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/
---

(Updated Sept. 22, 2014, 1:05 p.m.)


Review request for Plasma.


Changes
---

Remove commented-out stuff, add some comments


Repository: plasma-workspace


Description
---

I've picked up Kai's branch where he started the timezone support and finished 
it.

New features:
 * timezones tab in the config
 * changing timezones by scrolling a wheel on the clock
   * that's optional, defaults to off
 * displaying non-local timezones as either city or abbreviation
 * "Show time zone" config option is now changed to "Show local time zone" as 
foreign zones are always displayed by default
 
What's still missing:
 * selecting default timezone in the config (should be fairly easy; currently 
the last used is restored on login
 * timezones in the popup, this would require either large changes to the 
applet (moving functions around) or displaying the time in non-locale way
 
 


Diffs (updated)
-

  applets/digital-clock/package/contents/config/main.xml cbeb02f 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
  applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
  applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e78f1f3 
  applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
  applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
  applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
  applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
  applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
  applets/digital-clock/plugin/qmldir 3d57bbb 
  applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
  dataengines/time/timesource.cpp b79fd7c 
  applets/digital-clock/package/contents/config/config.qml f897c9a 

Diff: https://git.reviewboard.kde.org/r/120314/diff/


Testing
---

I've been using it for couple days, all those features from above work nicely 
here, with all sorts of config configurations (eg. if date is displayed, it 
also changes properly with timezone change).


File Attachments


Timezone & date displayed
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
Timezone without date
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/
---

(Updated Sept. 22, 2014, 12:56 p.m.)


Review request for Plasma.


Changes
---

Add screenshots


Repository: plasma-workspace


Description
---

I've picked up Kai's branch where he started the timezone support and finished 
it.

New features:
 * timezones tab in the config
 * changing timezones by scrolling a wheel on the clock
   * that's optional, defaults to off
 * displaying non-local timezones as either city or abbreviation
 * "Show time zone" config option is now changed to "Show local time zone" as 
foreign zones are always displayed by default
 
What's still missing:
 * selecting default timezone in the config (should be fairly easy; currently 
the last used is restored on login
 * timezones in the popup, this would require either large changes to the 
applet (moving functions around) or displaying the time in non-locale way
 
 


Diffs
-

  applets/digital-clock/package/contents/config/config.qml f897c9a 
  applets/digital-clock/package/contents/config/main.xml cbeb02f 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
  applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
  applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e78f1f3 
  applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
  applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
  applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
  applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
  applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
  applets/digital-clock/plugin/qmldir 3d57bbb 
  applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
  dataengines/time/timesource.cpp b79fd7c 

Diff: https://git.reviewboard.kde.org/r/120314/diff/


Testing
---

I've been using it for couple days, all those features from above work nicely 
here, with all sorts of config configurations (eg. if date is displayed, it 
also changes properly with timezone change).


File Attachments (updated)


Timezone & date displayed
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
Timezone without date
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

I've picked up Kai's branch where he started the timezone support and finished 
it.

New features:
 * timezones tab in the config
 * changing timezones by scrolling a wheel on the clock
   * that's optional, defaults to off
 * displaying non-local timezones as either city or abbreviation
 * "Show time zone" config option is now changed to "Show local time zone" as 
foreign zones are always displayed by default
 
What's still missing:
 * selecting default timezone in the config (should be fairly easy; currently 
the last used is restored on login
 * timezones in the popup, this would require either large changes to the 
applet (moving functions around) or displaying the time in non-locale way
 
 


Diffs
-

  applets/digital-clock/package/contents/config/config.qml f897c9a 
  applets/digital-clock/package/contents/config/main.xml cbeb02f 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
  applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
  applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e78f1f3 
  applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
  applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
  applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
  applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
  applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
  applets/digital-clock/plugin/qmldir 3d57bbb 
  applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
  applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
  dataengines/time/timesource.cpp b79fd7c 

Diff: https://git.reviewboard.kde.org/r/120314/diff/


Testing
---

I've been using it for couple days, all those features from above work nicely 
here, with all sorts of config configurations (eg. if date is displayed, it 
also changes properly with timezone change).


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Re: Review Request 120314: Add timezones support into clock applet

Review Request 120314: Add timezones support into clock applet

31 matches

Site Navigation

Mail list logo

Footer information