Review Request 120513: Set the shortcut for running ksysguard as global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120513: Set the shortcut for running ksysguard as global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/#review67994 --- systemmonitor/kdedksysguard.cpp https://git.reviewboard.kde.org/r/120513/#comment47395 It doesn't have to be a QList() - Lukáš Tinkl On Říj. 6, 2014, 4:14 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Říj. 6, 2014, 4:14 odp.) Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120513: Set the shortcut for running ksysguard as global
On Okt. 6, 2014, 4:18 nachm., Lukáš Tinkl wrote: systemmonitor/kdedksysguard.cpp, line 57 https://git.reviewboard.kde.org/r/120513/diff/1/?file=316750#file316750line57 It doesn't have to be a QList() even if it were a list I would recommend to use the initializer list instead of first creating the list and then appending the shortcut. Otherwise +1 to the change. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/#review67994 --- On Okt. 6, 2014, 4:14 nachm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Okt. 6, 2014, 4:14 nachm.) Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120513: Set the shortcut for running ksysguard as global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Oct. 6, 2014, 7:41 p.m.) Review request for Plasma and Martin Gräßlin. Changes --- Fix issues Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs (updated) - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120513: Set the shortcut for running ksysguard as global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/#review68018 --- Ship it! Ship It! - Martin Gräßlin On Oct. 6, 2014, 7:41 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Oct. 6, 2014, 7:41 p.m.) Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120513: Set the shortcut for running ksysguard as global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Oct. 6, 2014, 7:09 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
