Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 24, 2014, 4:42 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 21, 2014, 9:06 a.m.) Review request for Plasma and Hugo Pereira Da Costa. Changes --- get rid of QCoreApplication Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs (updated) - misc/gtkbreeze/main.cpp PRE-CREATION misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 21, 2014, 10 a.m.) Review request for Plasma and Hugo Pereira Da Costa. Changes --- add gtk3 css file to remove window shadows to tidy up client side decorations Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs (updated) - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
On Oct. 19, 2014, 3:47 p.m., David Edmundson wrote: misc/gtkbreeze/main.cpp, line 96 https://git.reviewboard.kde.org/r/120624/diff/1/?file=320198#file320198line96 mid-long term we probably want to split this out into a file that we copy Otherwise this isn't really going to scale especially wrt GTK Config and changing themes later. I don't think it would make much difference to include it as a file, it wouldn't make it any easier to update later if we want to change the theme - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68708 --- On Oct. 21, 2014, 10 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 21, 2014, 10 a.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68848 --- Ship it! Looking mostly good to my eyes. misc/gtkbreeze/CMakeLists.txt https://git.reviewboard.kde.org/r/120624/#comment48150 off-hand, I don't see why we need QWidgets here. Can you check? misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48149 QDir::separator() here as well misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48148 if setGtk2 fails and setGtk3 succeeds, it will return success. It should probably return success only if both failed. - Sebastian Kügler On Oct. 21, 2014, 10 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 21, 2014, 10 a.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68757 --- Found a bunch of issues around string handling, error handling and compiler definitions. misc/gtkbreeze/CMakeLists.txt https://git.reviewboard.kde.org/r/120624/#comment48061 This (and a few other includes here) don't seem necessary. Could be cleaned up a tad. misc/gtkbreeze/CMakeLists.txt https://git.reviewboard.kde.org/r/120624/#comment48049 Is this really needed here? I think we can just make the code work with these flags set, and be happier about it. Why did you add those? misc/gtkbreeze/CMakeLists.txt https://git.reviewboard.kde.org/r/120624/#comment48062 Might aswell just put main.cpp here and remove the additional temporary var gtkbreeze_SRCS. It's only one source file, anyway. misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48050 foreach ( missing space misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48048 / should be a QDir::Separator, this will make it much faster since it can skip the more expensive QString ctor. Also, inconsistent spacing on that line. misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48051 QDir::separator() instead of / misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48052 QStringLiteral(oxygen-gtk) is faster misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48053 exists (grammar) misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48054 Use QStringLiteral here and on the following line for faster string creation misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48055 no spacing inside parentheses misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48056 Error handling when opening the file fails? misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48057 Wrapping all the strings on this and the following lines in QStringLiterals will make creation of all those strings much faster. (And removes the need for non-standard compiler flags.) misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48058 Superfluous, the QFile object goes out of scope here anyway, and will be closed in the dtor. misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48046 const misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48047 const misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48059 const misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48045 I don't understand this. Does our startkde set the Ubuntu font? (I'm pretty sure that it's not.) Can you clarify, or perhaps explain how the Oxygen font is set here? misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment48060 Error handling here could be improved. I don't now exactly what makes sense here (return !0 if no settings have changed, if settings files aren't writable, perhaps?). - Sebastian Kügler On Oct. 19, 2014, 3:15 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 19, 2014, 3:15 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
On Oct. 17, 2014, 5:59 p.m., Andrew Lake wrote: Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app? Jonathan Riddell wrote: http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png GTK 2 http://people.ubuntu.com/~jr/tmp/breeze-gtk3.png GTK 3 (the demo app uses client side windows but the window border is still shown, I'm told this bug is fixed in newer GTK) http://people.ubuntu.com/~jr/tmp/breeze-qt4.png Qt 4 Martin Gräßlin wrote: for GTK 3 it's important that the style doesn't set a shadow because that's causing the strange effect you have in the screenshot. Andrew Lake wrote: Just on the visual result, I think the proposal is quite reasonable. There's a QtCurve Breeze settings file available in the breeze repo that comes pretty close to matching the feel of the native Breeze style, but I'm not aware of a QtCurve implementation in GTK3 (is there?). So I'm fine with this solution to keeping GTK2/3 apps looking similar and not looking too out of place when running in Plasma. Right the QtCurve GTK3 port was abandoned because GTK3 removed useful themeing abilities - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68621 --- On Oct. 19, 2014, 3:15 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 19, 2014, 3:15 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 19, 2014, 3:15 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
On Oct. 17, 2014, 5:59 p.m., Andrew Lake wrote: Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app? http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png GTK 2 http://people.ubuntu.com/~jr/tmp/breeze-gtk3.png GTK 3 (the demo app uses client side windows but the window border is still shown, I'm told this bug is fixed in newer GTK) http://people.ubuntu.com/~jr/tmp/breeze-qt4.png Qt 4 - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68621 --- On Oct. 19, 2014, 3:15 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 19, 2014, 3:15 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68708 --- misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment47901 mid-long term we probably want to split this out into a file that we copy Otherwise this isn't really going to scale especially wrt GTK Config and changing themes later. misc/gtkbreeze/main.cpp https://git.reviewboard.kde.org/r/120624/#comment47902 do we even need the app? we're not using it. - David Edmundson On Oct. 19, 2014, 3:15 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 19, 2014, 3:15 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
On Oct. 17, 2014, 7:59 p.m., Andrew Lake wrote: Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app? Jonathan Riddell wrote: http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png GTK 2 http://people.ubuntu.com/~jr/tmp/breeze-gtk3.png GTK 3 (the demo app uses client side windows but the window border is still shown, I'm told this bug is fixed in newer GTK) http://people.ubuntu.com/~jr/tmp/breeze-qt4.png Qt 4 for GTK 3 it's important that the style doesn't set a shadow because that's causing the strange effect you have in the screenshot. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68621 --- On Oct. 19, 2014, 5:15 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 19, 2014, 5:15 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
On Oct. 17, 2014, 5:59 p.m., Andrew Lake wrote: Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app? Jonathan Riddell wrote: http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png GTK 2 http://people.ubuntu.com/~jr/tmp/breeze-gtk3.png GTK 3 (the demo app uses client side windows but the window border is still shown, I'm told this bug is fixed in newer GTK) http://people.ubuntu.com/~jr/tmp/breeze-qt4.png Qt 4 Martin Gräßlin wrote: for GTK 3 it's important that the style doesn't set a shadow because that's causing the strange effect you have in the screenshot. Just on the visual result, I think the proposal is quite reasonable. There's a QtCurve Breeze settings file available in the breeze repo that comes pretty close to matching the feel of the native Breeze style, but I'm not aware of a QtCurve implementation in GTK3 (is there?). So I'm fine with this solution to keeping GTK2/3 apps looking similar and not looking too out of place when running in Plasma. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68621 --- On Oct. 19, 2014, 3:15 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 19, 2014, 3:15 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- Review request for Plasma. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68621 --- Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app? - Andrew Lake On Oct. 17, 2014, 3:47 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 17, 2014, 3:47 p.m.) Review request for Plasma. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
