Review Request 120667: set the polkit helper id to let polkit change the settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120667/ --- Review request for Plasma and David Edmundson. Repository: plasma-desktop Description --- set the polkit helper id to let polkit change the settings Diffs - kcms/dateandtime/main.cpp 0041a9d7b115b4e6f74973ff23a78fa619bd4a24 Diff: https://git.reviewboard.kde.org/r/120667/diff/ Testing --- installed and clicked apply Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120667: set the polkit helper id to let polkit change the settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120667/#review68761 --- Ship it! Plasma 5.1 too. - David Edmundson On Oct. 20, 2014, 2:44 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120667/ --- (Updated Oct. 20, 2014, 2:44 p.m.) Review request for Plasma and David Edmundson. Repository: plasma-desktop Description --- set the polkit helper id to let polkit change the settings. without this the kcm just blocks when you click Apply. but the key icons don't appear on the ok/apply buttons in kcmshell5 which makes me suspicious Diffs - kcms/dateandtime/main.cpp 0041a9d7b115b4e6f74973ff23a78fa619bd4a24 Diff: https://git.reviewboard.kde.org/r/120667/diff/ Testing --- installed and clicked apply Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120667: set the polkit helper id to let polkit change the settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120667/#review68762 --- Ship it! Weird, this was working just fine in 5.0... wondering what changed in KAuth - Lukáš Tinkl On Říj. 20, 2014, 4:44 odp., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120667/ --- (Updated Říj. 20, 2014, 4:44 odp.) Review request for Plasma and David Edmundson. Repository: plasma-desktop Description --- set the polkit helper id to let polkit change the settings. without this the kcm just blocks when you click Apply. but the key icons don't appear on the ok/apply buttons in kcmshell5 which makes me suspicious Diffs - kcms/dateandtime/main.cpp 0041a9d7b115b4e6f74973ff23a78fa619bd4a24 Diff: https://git.reviewboard.kde.org/r/120667/diff/ Testing --- installed and clicked apply Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120667: set the polkit helper id to let polkit change the settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120667/#review68764 --- On further reflection this may not be broken, it may just being slow - Jonathan Riddell On Oct. 20, 2014, 2:44 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120667/ --- (Updated Oct. 20, 2014, 2:44 p.m.) Review request for Plasma and David Edmundson. Repository: plasma-desktop Description --- set the polkit helper id to let polkit change the settings. without this the kcm just blocks when you click Apply. but the key icons don't appear on the ok/apply buttons in kcmshell5 which makes me suspicious Diffs - kcms/dateandtime/main.cpp 0041a9d7b115b4e6f74973ff23a78fa619bd4a24 Diff: https://git.reviewboard.kde.org/r/120667/diff/ Testing --- installed and clicked apply Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120667: set the polkit helper id to let polkit change the settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120667/ --- (Updated Oct. 20, 2014, 4:10 p.m.) Status -- This change has been discarded. Review request for Plasma and David Edmundson. Repository: plasma-desktop Description --- set the polkit helper id to let polkit change the settings. without this the kcm just blocks when you click Apply. but the key icons don't appear on the ok/apply buttons in kcmshell5 which makes me suspicious Diffs - kcms/dateandtime/main.cpp 0041a9d7b115b4e6f74973ff23a78fa619bd4a24 Diff: https://git.reviewboard.kde.org/r/120667/diff/ Testing --- installed and clicked apply Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
