Re: Review Request 121152: Provide async API for QmlObject

2014-11-19 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121152/
---

(Updated Nov. 19, 2014, 10:52 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: kdeclarative


Description
---

Introduces a method called ::delayedCompleteInitialization that will trigger 
the initialization then notify when it's done.

Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of 
limitations in reviewboard.


Diffs
-

  src/kdeclarative/qmlobject.h cd74829 
  src/kdeclarative/qmlobject.cpp 029edaf 

Diff: https://git.reviewboard.kde.org/r/121152/diff/


Testing
---

See https://git.reviewboard.kde.org/r/121148/


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121152: Provide async API for QmlObject

2014-11-19 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121152/#review70634
---

Ship it!


Ship It!

- Marco Martin


On Nov. 18, 2014, 10:04 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121152/
> ---
> 
> (Updated Nov. 18, 2014, 10:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Introduces a method called ::delayedCompleteInitialization that will trigger 
> the initialization then notify when it's done.
> 
> Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of 
> limitations in reviewboard.
> 
> 
> Diffs
> -
> 
>   src/kdeclarative/qmlobject.h cd74829 
>   src/kdeclarative/qmlobject.cpp 029edaf 
> 
> Diff: https://git.reviewboard.kde.org/r/121152/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/121148/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121152: Provide async API for QmlObject

2014-11-18 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121152/
---

(Updated Nov. 18, 2014, 10:04 p.m.)


Review request for Plasma.


Changes
---

Use the setInitializationDelayed property, as suggested by Marco.


Repository: kdeclarative


Description
---

Introduces a method called ::delayedCompleteInitialization that will trigger 
the initialization then notify when it's done.

Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of 
limitations in reviewboard.


Diffs (updated)
-

  src/kdeclarative/qmlobject.h cd74829 
  src/kdeclarative/qmlobject.cpp 029edaf 

Diff: https://git.reviewboard.kde.org/r/121152/diff/


Testing
---

See https://git.reviewboard.kde.org/r/121148/


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121152: Provide async API for QmlObject

2014-11-18 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121152/#review70599
---



src/kdeclarative/qmlobject.h


I think this method can be avoided, and have an internal private slot 
called instead when initializationDelayed is true


- Marco Martin


On Nov. 17, 2014, 4:39 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121152/
> ---
> 
> (Updated Nov. 17, 2014, 4:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Introduces a method called ::delayedCompleteInitialization that will trigger 
> the initialization then notify when it's done.
> 
> Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of 
> limitations in reviewboard.
> 
> 
> Diffs
> -
> 
>   src/kdeclarative/qmlobject.h cd748294e4933c30c8c0afbb91d4375a418b0510 
>   src/kdeclarative/qmlobject.cpp 029edaffa8af5ef143be3cabe33c49ee375ab1a6 
> 
> Diff: https://git.reviewboard.kde.org/r/121152/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/121148/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121152: Provide async API for QmlObject

2014-11-17 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121152/#review70559
---


I think this makes sense. +1

- David Edmundson


On Nov. 17, 2014, 4:39 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121152/
> ---
> 
> (Updated Nov. 17, 2014, 4:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Introduces a method called ::delayedCompleteInitialization that will trigger 
> the initialization then notify when it's done.
> 
> Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of 
> limitations in reviewboard.
> 
> 
> Diffs
> -
> 
>   src/kdeclarative/qmlobject.h cd748294e4933c30c8c0afbb91d4375a418b0510 
>   src/kdeclarative/qmlobject.cpp 029edaffa8af5ef143be3cabe33c49ee375ab1a6 
> 
> Diff: https://git.reviewboard.kde.org/r/121152/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/121148/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121152: Provide async API for QmlObject

2014-11-17 Thread Lukáš Tinkl 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121152/#review70530
---



src/kdeclarative/qmlobject.h


No API doc


- Lukáš Tinkl


On Lis. 17, 2014, 5:39 odp., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121152/
> ---
> 
> (Updated Lis. 17, 2014, 5:39 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Introduces a method called ::delayedCompleteInitialization that will trigger 
> the initialization then notify when it's done.
> 
> Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of 
> limitations in reviewboard.
> 
> 
> Diffs
> -
> 
>   src/kdeclarative/qmlobject.h cd748294e4933c30c8c0afbb91d4375a418b0510 
>   src/kdeclarative/qmlobject.cpp 029edaffa8af5ef143be3cabe33c49ee375ab1a6 
> 
> Diff: https://git.reviewboard.kde.org/r/121152/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/121148/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121152: Provide async API for QmlObject

2014-11-17 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121152/
---

Review request for Plasma.


Repository: kdeclarative


Description
---

Introduces a method called ::delayedCompleteInitialization that will trigger 
the initialization then notify when it's done.

Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of 
limitations in reviewboard.


Diffs
-

  src/kdeclarative/qmlobject.h cd748294e4933c30c8c0afbb91d4375a418b0510 
  src/kdeclarative/qmlobject.cpp 029edaffa8af5ef143be3cabe33c49ee375ab1a6 

Diff: https://git.reviewboard.kde.org/r/121152/diff/


Testing
---

See https://git.reviewboard.kde.org/r/121148/


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel