Re: Review Request 121229: Highlight first entry when searching
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121229/ --- (Updated Nov. 25, 2014, 12:50 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Sebastian Kügler. Bugs: 340067 https://bugs.kde.org/show_bug.cgi?id=340067 Repository: plasma-desktop Description --- Since pressing enter invokes the first entry it should be highlighted. Diffs - applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 Diff: https://git.reviewboard.kde.org/r/121229/diff/ Testing --- Works as expected. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121229: Highlight first entry when searching
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121229/#review70913 --- Ship it! nice! - Sebastian Kügler On Nov. 24, 2014, 5:27 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121229/ > --- > > (Updated Nov. 24, 2014, 5:27 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Bugs: 340067 > https://bugs.kde.org/show_bug.cgi?id=340067 > > > Repository: plasma-desktop > > > Description > --- > > Since pressing enter invokes the first entry it should be highlighted. > > > Diffs > - > > applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 > > Diff: https://git.reviewboard.kde.org/r/121229/diff/ > > > Testing > --- > > Works as expected. > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121229: Highlight first entry when searching
> On Nov. 24, 2014, 5:36 p.m., Aleix Pol Gonzalez wrote: > > Definitely, does pressing up & down work as expected too? > > > > In fact, here it looks like I already get a highlight delegate... > > Kai Uwe Broulik wrote: > Yes, pressing up and down works as expected, only if you type again > (which resets the list anyway) you end up at the top again. > > Make sure you don't have your mouse hovering there, I had the same and > thought it already worked :) I made sure. But your patch seems to make sense and fix the bug, so +1. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121229/#review70859 --- On Nov. 24, 2014, 5:27 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121229/ > --- > > (Updated Nov. 24, 2014, 5:27 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Bugs: 340067 > https://bugs.kde.org/show_bug.cgi?id=340067 > > > Repository: plasma-desktop > > > Description > --- > > Since pressing enter invokes the first entry it should be highlighted. > > > Diffs > - > > applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 > > Diff: https://git.reviewboard.kde.org/r/121229/diff/ > > > Testing > --- > > Works as expected. > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121229: Highlight first entry when searching
> On Nov. 24, 2014, 5:36 nachm., Aleix Pol Gonzalez wrote: > > Definitely, does pressing up & down work as expected too? > > > > In fact, here it looks like I already get a highlight delegate... Yes, pressing up and down works as expected, only if you type again (which resets the list anyway) you end up at the top again. Make sure you don't have your mouse hovering there, I had the same and thought it already worked :) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121229/#review70859 --- On Nov. 24, 2014, 5:27 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121229/ > --- > > (Updated Nov. 24, 2014, 5:27 nachm.) > > > Review request for Plasma and Sebastian Kügler. > > > Bugs: 340067 > https://bugs.kde.org/show_bug.cgi?id=340067 > > > Repository: plasma-desktop > > > Description > --- > > Since pressing enter invokes the first entry it should be highlighted. > > > Diffs > - > > applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 > > Diff: https://git.reviewboard.kde.org/r/121229/diff/ > > > Testing > --- > > Works as expected. > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121229: Highlight first entry when searching
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121229/#review70859 --- Definitely, does pressing up & down work as expected too? In fact, here it looks like I already get a highlight delegate... - Aleix Pol Gonzalez On Nov. 24, 2014, 5:27 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121229/ > --- > > (Updated Nov. 24, 2014, 5:27 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Bugs: 340067 > https://bugs.kde.org/show_bug.cgi?id=340067 > > > Repository: plasma-desktop > > > Description > --- > > Since pressing enter invokes the first entry it should be highlighted. > > > Diffs > - > > applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 > > Diff: https://git.reviewboard.kde.org/r/121229/diff/ > > > Testing > --- > > Works as expected. > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121229: Highlight first entry when searching
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121229/ --- Review request for Plasma and Sebastian Kügler. Bugs: 340067 https://bugs.kde.org/show_bug.cgi?id=340067 Repository: plasma-desktop Description --- Since pressing enter invokes the first entry it should be highlighted. Diffs - applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 Diff: https://git.reviewboard.kde.org/r/121229/diff/ Testing --- Works as expected. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
