Re: Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/ --- (Updated Dec. 2, 2014, 5:42 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Eike Hein and Vishesh Handa. Repository: plasma-desktop Description --- The StartupInfoId is supposed to contain information about the process and event which triggered the startup of the application. E.g. in the case of Kickoff it should be the last input event and the pid of Plasma. By creating the StartupInfoId directly in Kickoff and passing it to KRun we can ensure that this information is correct. The code so far lost this information and the launch information was not correct. The timestamp is set to a random timestamp after the event and the pid is set to the one of the klauncher process. Furthermore this saves a roundtrip to the X Server from klauncher. @Eike and Vishesh: I'd suggest to add the same change to Kicker and KRunner. Diffs - applets/kickoff/CMakeLists.txt 817c7e41f4454aab66db5ad84e4b494395e5484f applets/kickoff/core/urlitemlauncher.cpp 2ed074709c88ed10cdd72bae7d2b6bf2879183ae Diff: https://git.reviewboard.kde.org/r/121234/diff/ Testing --- started applications through plasmoidviewer and inspected the /proc/x/environ to check the DESKTOP_STARTUP_ID env variable. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/#review70914 --- Ship it! Ship It! - Eike Hein On Nov. 24, 2014, 7:05 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/ --- (Updated Nov. 24, 2014, 7:05 p.m.) Review request for Plasma, Eike Hein and Vishesh Handa. Repository: plasma-desktop Description --- The StartupInfoId is supposed to contain information about the process and event which triggered the startup of the application. E.g. in the case of Kickoff it should be the last input event and the pid of Plasma. By creating the StartupInfoId directly in Kickoff and passing it to KRun we can ensure that this information is correct. The code so far lost this information and the launch information was not correct. The timestamp is set to a random timestamp after the event and the pid is set to the one of the klauncher process. Furthermore this saves a roundtrip to the X Server from klauncher. @Eike and Vishesh: I'd suggest to add the same change to Kicker and KRunner. Diffs - applets/kickoff/CMakeLists.txt 817c7e41f4454aab66db5ad84e4b494395e5484f applets/kickoff/core/urlitemlauncher.cpp 2ed074709c88ed10cdd72bae7d2b6bf2879183ae Diff: https://git.reviewboard.kde.org/r/121234/diff/ Testing --- started applications through plasmoidviewer and inspected the /proc/x/environ to check the DESKTOP_STARTUP_ID env variable. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/#review70918 --- Ship it! Ship It! - Sebastian Kügler On Nov. 24, 2014, 7:05 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/ --- (Updated Nov. 24, 2014, 7:05 p.m.) Review request for Plasma, Eike Hein and Vishesh Handa. Repository: plasma-desktop Description --- The StartupInfoId is supposed to contain information about the process and event which triggered the startup of the application. E.g. in the case of Kickoff it should be the last input event and the pid of Plasma. By creating the StartupInfoId directly in Kickoff and passing it to KRun we can ensure that this information is correct. The code so far lost this information and the launch information was not correct. The timestamp is set to a random timestamp after the event and the pid is set to the one of the klauncher process. Furthermore this saves a roundtrip to the X Server from klauncher. @Eike and Vishesh: I'd suggest to add the same change to Kicker and KRunner. Diffs - applets/kickoff/CMakeLists.txt 817c7e41f4454aab66db5ad84e4b494395e5484f applets/kickoff/core/urlitemlauncher.cpp 2ed074709c88ed10cdd72bae7d2b6bf2879183ae Diff: https://git.reviewboard.kde.org/r/121234/diff/ Testing --- started applications through plasmoidviewer and inspected the /proc/x/environ to check the DESKTOP_STARTUP_ID env variable. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/#review70866 --- Questions: a) I can't find createNewStartupIdForTimestamp in the apidox, I assume this is new and means this is master-only since it needs fresh KWS? b) If it's new API assume you know it doesn't break on non-x11? c) Should Task Manager launchers do it, too? - Eike Hein On Nov. 24, 2014, 7:05 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/ --- (Updated Nov. 24, 2014, 7:05 p.m.) Review request for Plasma, Eike Hein and Vishesh Handa. Repository: plasma-desktop Description --- The StartupInfoId is supposed to contain information about the process and event which triggered the startup of the application. E.g. in the case of Kickoff it should be the last input event and the pid of Plasma. By creating the StartupInfoId directly in Kickoff and passing it to KRun we can ensure that this information is correct. The code so far lost this information and the launch information was not correct. The timestamp is set to a random timestamp after the event and the pid is set to the one of the klauncher process. Furthermore this saves a roundtrip to the X Server from klauncher. @Eike and Vishesh: I'd suggest to add the same change to Kicker and KRunner. Diffs - applets/kickoff/CMakeLists.txt 817c7e41f4454aab66db5ad84e4b494395e5484f applets/kickoff/core/urlitemlauncher.cpp 2ed074709c88ed10cdd72bae7d2b6bf2879183ae Diff: https://git.reviewboard.kde.org/r/121234/diff/ Testing --- started applications through plasmoidviewer and inspected the /proc/x/environ to check the DESKTOP_STARTUP_ID env variable. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/ --- Review request for Plasma, Eike Hein and Vishesh Handa. Repository: plasma-desktop Description --- The StartupInfoId is supposed to contain information about the process and event which triggered the startup of the application. E.g. in the case of Kickoff it should be the last input event and the pid of Plasma. By creating the StartupInfoId directly in Kickoff and passing it to KRun we can ensure that this information is correct. The code so far lost this information and the launch information was not correct. The timestamp is set to a random timestamp after the event and the pid is set to the one of the klauncher process. Furthermore this saves a roundtrip to the X Server from klauncher. @Eike and Vishesh: I'd suggest to add the same change to Kicker and KRunner. Diffs - applets/kickoff/CMakeLists.txt 817c7e41f4454aab66db5ad84e4b494395e5484f applets/kickoff/core/urlitemlauncher.cpp 2ed074709c88ed10cdd72bae7d2b6bf2879183ae Diff: https://git.reviewboard.kde.org/r/121234/diff/ Testing --- started applications through plasmoidviewer and inspected the /proc/x/environ to check the DESKTOP_STARTUP_ID env variable. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId
On Nov. 24, 2014, 8:13 p.m., Eike Hein wrote: Questions: a) I can't find createNewStartupIdForTimestamp in the apidox, I assume this is new and means this is master-only since it needs fresh KWS? b) If it's new API assume you know it doesn't break on non-x11? c) Should Task Manager launchers do it, too? a) see the depends on review requests: https://git.reviewboard.kde.org/r/121197/ b) no I do not, but I hardly doubt that Windows and OSX use the DESKTOP_STARTUP_ID env variable as defined for X11. The code works and doesn't break but I doubt it does anything. c) probably yes - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/#review70866 --- On Nov. 24, 2014, 8:05 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/ --- (Updated Nov. 24, 2014, 8:05 p.m.) Review request for Plasma, Eike Hein and Vishesh Handa. Repository: plasma-desktop Description --- The StartupInfoId is supposed to contain information about the process and event which triggered the startup of the application. E.g. in the case of Kickoff it should be the last input event and the pid of Plasma. By creating the StartupInfoId directly in Kickoff and passing it to KRun we can ensure that this information is correct. The code so far lost this information and the launch information was not correct. The timestamp is set to a random timestamp after the event and the pid is set to the one of the klauncher process. Furthermore this saves a roundtrip to the X Server from klauncher. @Eike and Vishesh: I'd suggest to add the same change to Kicker and KRunner. Diffs - applets/kickoff/CMakeLists.txt 817c7e41f4454aab66db5ad84e4b494395e5484f applets/kickoff/core/urlitemlauncher.cpp 2ed074709c88ed10cdd72bae7d2b6bf2879183ae Diff: https://git.reviewboard.kde.org/r/121234/diff/ Testing --- started applications through plasmoidviewer and inspected the /proc/x/environ to check the DESKTOP_STARTUP_ID env variable. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
