Re: Review Request 121244: Remove workarounds we had for the nested event loops

2014-11-25 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121244/
---

(Updated Nov. 25, 2014, 11:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

Instead of keeping the state, expect the code to follow the order it's expected 
from it.

Needs to bump the KF5 requirement to current KDeclarative (master), or it can 
run in problems.


Diffs
-

  CMakeLists.txt 7856833 
  shell/shellcorona.h 37f8b0e 
  shell/shellcorona.cpp fd8e9b7 

Diff: https://git.reviewboard.kde.org/r/121244/diff/


Testing
---

Been running it for the last week.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121244: Remove workarounds we had for the nested event loops

2014-11-25 Thread Aleix Pol Gonzalez 


> On Nov. 25, 2014, 6:43 p.m., Marco Martin wrote:
> > CMakeLists.txt, line 16
> > 
> >
> > unrelated commit?

No, I just can't enforce 5.4 if Baloo is 5.2, so I moved it into a separate 
find_package call.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121244/#review70944
---


On Nov. 25, 2014, 6:33 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121244/
> ---
> 
> (Updated Nov. 25, 2014, 6:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of keeping the state, expect the code to follow the order it's 
> expected from it.
> 
> Needs to bump the KF5 requirement to current KDeclarative (master), or it can 
> run in problems.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 7856833 
>   shell/shellcorona.h 37f8b0e 
>   shell/shellcorona.cpp fd8e9b7 
> 
> Diff: https://git.reviewboard.kde.org/r/121244/diff/
> 
> 
> Testing
> ---
> 
> Been running it for the last week.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121244: Remove workarounds we had for the nested event loops

2014-11-25 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121244/#review70944
---

Ship it!



CMakeLists.txt


unrelated commit?


- Marco Martin


On Nov. 25, 2014, 6:33 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121244/
> ---
> 
> (Updated Nov. 25, 2014, 6:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of keeping the state, expect the code to follow the order it's 
> expected from it.
> 
> Needs to bump the KF5 requirement to current KDeclarative (master), or it can 
> run in problems.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 7856833 
>   shell/shellcorona.h 37f8b0e 
>   shell/shellcorona.cpp fd8e9b7 
> 
> Diff: https://git.reviewboard.kde.org/r/121244/diff/
> 
> 
> Testing
> ---
> 
> Been running it for the last week.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121244: Remove workarounds we had for the nested event loops

2014-11-25 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121244/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Instead of keeping the state, expect the code to follow the order it's expected 
from it.

Needs to bump the KF5 requirement to current KDeclarative (master), or it can 
run in problems.


Diffs
-

  CMakeLists.txt 7856833 
  shell/shellcorona.h 37f8b0e 
  shell/shellcorona.cpp fd8e9b7 

Diff: https://git.reviewboard.kde.org/r/121244/diff/


Testing
---

Been running it for the last week.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel