Review Request 121419: Improve Capslock Enabled warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121419/ --- Review request for Plasma and Daniel Vrátil. Repository: plasma-workspace Description --- Don't use a separate label which causes the layout to shift but just use the notification label and prepend the warning to any actual message. Diffs - lookandfeel/contents/lockscreen/LockScreen.qml ca9beb2 Diff: https://git.reviewboard.kde.org/r/121419/diff/ Testing --- Yup. Looks better imho. File Attachments Just the warning https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/ff5b6404-f55a-4e72-afd3-1348f2e12258__capslockwarning1.png Warning with failed unlock https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/f29104c3-3b76-4508-b9be-3fad2a3d7baa__capslockwarning2.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121419: Improve Capslock Enabled warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121419/#review71679 --- +1 from me - Lukáš Tinkl On Pro. 9, 2014, 11:15 odp., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121419/ > --- > > (Updated Pro. 9, 2014, 11:15 odp.) > > > Review request for Plasma and Daniel Vrátil. > > > Repository: plasma-workspace > > > Description > --- > > Don't use a separate label which causes the layout to shift but just use the > notification label and prepend the warning to any actual message. > > > Diffs > - > > lookandfeel/contents/lockscreen/LockScreen.qml ca9beb2 > > Diff: https://git.reviewboard.kde.org/r/121419/diff/ > > > Testing > --- > > Yup. Looks better imho. > > > File Attachments > > > Just the warning > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/ff5b6404-f55a-4e72-afd3-1348f2e12258__capslockwarning1.png > Warning with failed unlock > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/f29104c3-3b76-4508-b9be-3fad2a3d7baa__capslockwarning2.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121419: Improve Capslock Enabled warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121419/#review71681 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 9, 2014, 10:15 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121419/ > --- > > (Updated Dec. 9, 2014, 10:15 p.m.) > > > Review request for Plasma and Daniel Vrátil. > > > Repository: plasma-workspace > > > Description > --- > > Don't use a separate label which causes the layout to shift but just use the > notification label and prepend the warning to any actual message. > > > Diffs > - > > lookandfeel/contents/lockscreen/LockScreen.qml ca9beb2 > > Diff: https://git.reviewboard.kde.org/r/121419/diff/ > > > Testing > --- > > Yup. Looks better imho. > > > File Attachments > > > Just the warning > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/ff5b6404-f55a-4e72-afd3-1348f2e12258__capslockwarning1.png > Warning with failed unlock > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/f29104c3-3b76-4508-b9be-3fad2a3d7baa__capslockwarning2.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121419: Improve Capslock Enabled warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121419/ --- (Updated Dec. 10, 2014, 9:40 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Daniel Vrátil. Repository: plasma-workspace Description --- Don't use a separate label which causes the layout to shift but just use the notification label and prepend the warning to any actual message. Diffs - lookandfeel/contents/lockscreen/LockScreen.qml ca9beb2 Diff: https://git.reviewboard.kde.org/r/121419/diff/ Testing --- Yup. Looks better imho. File Attachments Just the warning https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/ff5b6404-f55a-4e72-afd3-1348f2e12258__capslockwarning1.png Warning with failed unlock https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/f29104c3-3b76-4508-b9be-3fad2a3d7baa__capslockwarning2.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
