Re: Review Request 121424: Porting Accessibility Config Module away from KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/ --- (Updated Dec. 10, 2014, 6:10 p.m.) Review request for Plasma and David Edmundson. Repository: plasma-desktop Description (updated) --- [GCI2014]Remove the depencence on KDELibs4Support form KCMAccess Diffs - kcms/access/kaccess.h 716bfcf kcms/access/kaccess.cpp aea6f86 kcms/access/kcmaccess.h d3cb40f kcms/access/kcmaccess.cpp 6c8bc65 kcms/access/main.cpp 09864fc kcms/access/CMakeLists.txt 64b1cc9 Diff: https://git.reviewboard.kde.org/r/121424/diff/ Testing --- I have ran kcmshell5 kcmaccess, did see no problem. Thanks, Toby Chen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121424: Porting Accessibility Config Module away from KDELibs4Support
> On Dec. 10, 2014, 1:50 p.m., Lukáš Tinkl wrote: > > Did you test the accessibility features? Yes, they work fine. - Toby --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71700 --- On Dec. 10, 2014, 1:44 p.m., Toby Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121424/ > --- > > (Updated Dec. 10, 2014, 1:44 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-desktop > > > Description > --- > > Remove the depencence on KDELibs4Support form KCMAccess > > > Diffs > - > > kcms/access/kaccess.h 716bfcf > kcms/access/kaccess.cpp aea6f86 > kcms/access/kcmaccess.h d3cb40f > kcms/access/kcmaccess.cpp 6c8bc65 > kcms/access/main.cpp 09864fc > kcms/access/CMakeLists.txt 64b1cc9 > > Diff: https://git.reviewboard.kde.org/r/121424/diff/ > > > Testing > --- > > I have ran kcmshell5 kcmaccess, did see no problem. > > > Thanks, > > Toby Chen > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121424: Porting Accessibility Config Module away from KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71700 --- Did you test the accessibility features? - Lukáš Tinkl On Pro. 10, 2014, 2:44 odp., Toby Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121424/ > --- > > (Updated Pro. 10, 2014, 2:44 odp.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-desktop > > > Description > --- > > Remove the depencence on KDELibs4Support form KCMAccess > > > Diffs > - > > kcms/access/kaccess.h 716bfcf > kcms/access/kaccess.cpp aea6f86 > kcms/access/kcmaccess.h d3cb40f > kcms/access/kcmaccess.cpp 6c8bc65 > kcms/access/main.cpp 09864fc > kcms/access/CMakeLists.txt 64b1cc9 > > Diff: https://git.reviewboard.kde.org/r/121424/diff/ > > > Testing > --- > > I have ran kcmshell5 kcmaccess, did see no problem. > > > Thanks, > > Toby Chen > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121424: Porting Accessibility Config Module away from KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/ --- (Updated Dec. 10, 2014, 1:44 p.m.) Review request for Plasma and David Edmundson. Repository: plasma-desktop Description --- Remove the depencence on KDELibs4Support form KCMAccess Diffs - kcms/access/kaccess.h 716bfcf kcms/access/kaccess.cpp aea6f86 kcms/access/kcmaccess.h d3cb40f kcms/access/kcmaccess.cpp 6c8bc65 kcms/access/main.cpp 09864fc kcms/access/CMakeLists.txt 64b1cc9 Diff: https://git.reviewboard.kde.org/r/121424/diff/ Testing --- I have ran kcmshell5 kcmaccess, did see no problem. Thanks, Toby Chen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
