Re: Review Request 121507: Add silent parameter to PM dataengine brightness jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/#review72427 --- Ping The required PowerDevil changes have been committed - Kai Uwe Broulik On Dez. 14, 2014, 1:05 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/ --- (Updated Dez. 14, 2014, 1:05 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a silent argument to the setBrightness jobs in the PM dataengine allowing the caller to suppress the OSD. I will use this in the battery monitor to not show the OSD when the user is actively dragging the slider since confirming an action he/she just did is redundant. It will show it when mouse wheeling the icon, however, to provide feedback there. Diffs - dataengines/powermanagement/powermanagementjob.h 8dd1731 dataengines/powermanagement/powermanagementjob.cpp 24ef2db dataengines/powermanagement/powermanagementservice.operations c9abbf9 Diff: https://git.reviewboard.kde.org/r/121507/diff/ Testing --- Works as expected. Also it seems to be backwards compatible so clients not explicitly setting the silent property won't break but just default to false. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121507: Add silent parameter to PM dataengine brightness jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/#review72428 --- Ship it! Ship It! - Lukáš Tinkl On Pro. 14, 2014, 2:05 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/ --- (Updated Pro. 14, 2014, 2:05 odp.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a silent argument to the setBrightness jobs in the PM dataengine allowing the caller to suppress the OSD. I will use this in the battery monitor to not show the OSD when the user is actively dragging the slider since confirming an action he/she just did is redundant. It will show it when mouse wheeling the icon, however, to provide feedback there. Diffs - dataengines/powermanagement/powermanagementjob.h 8dd1731 dataengines/powermanagement/powermanagementjob.cpp 24ef2db dataengines/powermanagement/powermanagementservice.operations c9abbf9 Diff: https://git.reviewboard.kde.org/r/121507/diff/ Testing --- Works as expected. Also it seems to be backwards compatible so clients not explicitly setting the silent property won't break but just default to false. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121507: Add silent parameter to PM dataengine brightness jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/ --- (Updated Dec. 22, 2014, 3:02 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- This adds a silent argument to the setBrightness jobs in the PM dataengine allowing the caller to suppress the OSD. I will use this in the battery monitor to not show the OSD when the user is actively dragging the slider since confirming an action he/she just did is redundant. It will show it when mouse wheeling the icon, however, to provide feedback there. Diffs - dataengines/powermanagement/powermanagementjob.h 8dd1731 dataengines/powermanagement/powermanagementjob.cpp 24ef2db dataengines/powermanagement/powermanagementservice.operations c9abbf9 Diff: https://git.reviewboard.kde.org/r/121507/diff/ Testing --- Works as expected. Also it seems to be backwards compatible so clients not explicitly setting the silent property won't break but just default to false. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121507: Add silent parameter to PM dataengine brightness jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/ --- Review request for Plasma. Repository: plasma-workspace Description --- This adds a silent argument to the setBrightness jobs in the PM dataengine allowing the caller to suppress the OSD. I will use this in the battery monitor to now show the OSD when the user is actively dragging the slider since confirming an action he/she just did is just redundant. It will show it when mouse wheeling the icon. Diffs - dataengines/powermanagement/powermanagementjob.h 8dd1731 dataengines/powermanagement/powermanagementjob.cpp 24ef2db dataengines/powermanagement/powermanagementservice.operations c9abbf9 Diff: https://git.reviewboard.kde.org/r/121507/diff/ Testing --- Works as expected. Also it seems to be backwards compatible so clients not explicitly setting the silent property won't break but just default to false. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121507: Add silent parameter to PM dataengine brightness jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/ --- (Updated Dez. 14, 2014, 1:05 nachm.) Review request for Plasma. Repository: plasma-workspace Description (updated) --- This adds a silent argument to the setBrightness jobs in the PM dataengine allowing the caller to suppress the OSD. I will use this in the battery monitor to not show the OSD when the user is actively dragging the slider since confirming an action he/she just did is redundant. It will show it when mouse wheeling the icon, however, to provide feedback there. Diffs - dataengines/powermanagement/powermanagementjob.h 8dd1731 dataengines/powermanagement/powermanagementjob.cpp 24ef2db dataengines/powermanagement/powermanagementservice.operations c9abbf9 Diff: https://git.reviewboard.kde.org/r/121507/diff/ Testing --- Works as expected. Also it seems to be backwards compatible so clients not explicitly setting the silent property won't break but just default to false. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121507: Add silent parameter to PM dataengine brightness jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/#review71983 --- dataengines/powermanagement/powermanagementjob.cpp https://git.reviewboard.kde.org/r/121507/#comment50196 does this method exists already or is there another patch? - David Edmundson On Dec. 14, 2014, 1:05 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/ --- (Updated Dec. 14, 2014, 1:05 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a silent argument to the setBrightness jobs in the PM dataengine allowing the caller to suppress the OSD. I will use this in the battery monitor to not show the OSD when the user is actively dragging the slider since confirming an action he/she just did is redundant. It will show it when mouse wheeling the icon, however, to provide feedback there. Diffs - dataengines/powermanagement/powermanagementjob.h 8dd1731 dataengines/powermanagement/powermanagementjob.cpp 24ef2db dataengines/powermanagement/powermanagementservice.operations c9abbf9 Diff: https://git.reviewboard.kde.org/r/121507/diff/ Testing --- Works as expected. Also it seems to be backwards compatible so clients not explicitly setting the silent property won't break but just default to false. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121507: Add silent parameter to PM dataengine brightness jobs
On Dez. 14, 2014, 3:14 nachm., David Edmundson wrote: dataengines/powermanagement/powermanagementjob.cpp, line 123 https://git.reviewboard.kde.org/r/121507/diff/1/?file=333131#file333131line123 does this method exists already or is there another patch? See Depends on Review 121506 :) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/#review71983 --- On Dez. 14, 2014, 1:05 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/ --- (Updated Dez. 14, 2014, 1:05 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a silent argument to the setBrightness jobs in the PM dataengine allowing the caller to suppress the OSD. I will use this in the battery monitor to not show the OSD when the user is actively dragging the slider since confirming an action he/she just did is redundant. It will show it when mouse wheeling the icon, however, to provide feedback there. Diffs - dataengines/powermanagement/powermanagementjob.h 8dd1731 dataengines/powermanagement/powermanagementjob.cpp 24ef2db dataengines/powermanagement/powermanagementservice.operations c9abbf9 Diff: https://git.reviewboard.kde.org/r/121507/diff/ Testing --- Works as expected. Also it seems to be backwards compatible so clients not explicitly setting the silent property won't break but just default to false. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
